From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 305BFC61DA4 for ; Fri, 3 Feb 2023 16:26:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233015AbjBCQ0p (ORCPT ); Fri, 3 Feb 2023 11:26:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233017AbjBCQ0l (ORCPT ); Fri, 3 Feb 2023 11:26:41 -0500 Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7128EA6C1A for ; Fri, 3 Feb 2023 08:26:38 -0800 (PST) Received: by mail-il1-x130.google.com with SMTP id z2so2275623ilq.2 for ; Fri, 03 Feb 2023 08:26:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jzLSTilkTqHv5zqJq4XrgBlNDh4B17SJN2rgulEb5xk=; b=d7kPQhIauFu7vhvmYuzzHJii3z93jbo8da5vvEAJvij6FF2hHODbovtTwaR//XIqB6 IDIvXVPISW0bwGn6f/uwmd8dHTwDSn2kOobXOqmYAgqMSghpBvDM48pRn5IzbuO+8qvj YLDPv1eR3uAXHCfCs/3lhe8N2TuQC4ReiAR7M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jzLSTilkTqHv5zqJq4XrgBlNDh4B17SJN2rgulEb5xk=; b=m3gzR6IoOFus0L2kyjmjTi4bQdilaZU6iVlnv5fpc4uLcM5julitT8YnfOKaeCJr+w pGFvC9MX2M/GYwEeZyjy3ODv1+2Oor9GdpOJkPCvVPjT/m8zn9t9/lTjOQ0j/VvFg/u3 q8KRHP59o1WbjhAB2hwrZRbrilfIVDigM3HRukZsHt9ewIchIgRhRZ/O5ZdR6o/+0dc+ 79f8UPdAJ8PAWRKLb+cBLl7awDZiRmigwZ/YXfTj3Eusx2xNbK2kTRozqxEpeLiXhmgx 5N56JwZH41RcUe2yJvBlXvGaPPGvmgitprLcxvhSo+IYOiHMpd6Scn/gQtXcinj25SH6 1UXg== X-Gm-Message-State: AO0yUKWU+1qe+Kbe8upvwtRKryw9A6CO7mhAzvijocmPwqDLuUX9QIfP Wrafqem28jOdWisu933zNWCUpQ== X-Google-Smtp-Source: AK7set+SWBkzsLF7SwKMgA+I+wyLq5+0NPN1Gmn1itfKTHMLjlocRZMy3fHFcQDgtVDC6mqhqZ7xwg== X-Received: by 2002:a05:6e02:1ba7:b0:310:b84b:c893 with SMTP id n7-20020a056e021ba700b00310b84bc893mr7862837ili.1.1675441597740; Fri, 03 Feb 2023 08:26:37 -0800 (PST) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id q21-20020a056638345500b003af38f526aesm943667jav.81.2023.02.03.08.26.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Feb 2023 08:26:37 -0800 (PST) Message-ID: Date: Fri, 3 Feb 2023 09:26:36 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] selftests: find echo binary to use -ne options Content-Language: en-US To: Guillaume Tucker , Guillaume Tucker , Shuah Khan , Gautam Cc: kernel@collabora.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, kernelci@lists.linux.dev, Shuah Khan References: <20230203152603.11450-1-guillaume.tucker@collabora.com> From: Shuah Khan In-Reply-To: <20230203152603.11450-1-guillaume.tucker@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/3/23 08:26, Guillaume Tucker wrote: > Find the actual echo binary using $(which echo) and use it for > formatted output with -ne. On some systems, the default echo command > doesn't handle the -e option and the output looks like this (arm64 > build): > > -ne Emit Tests for alsa > > -ne Emit Tests for amd-pstate > > -ne Emit Tests for arm64 > > This is for example the case with the KernelCI Docker images > e.g. kernelci/gcc-10:x86-kselftest-kernelci. With the actual echo > binary (e.g. in /bin/echo), the output is formatted as expected (x86 > build this time): > > Emit Tests for alsa > Emit Tests for amd-pstate > Skipping non-existent dir: arm64 > > Only the install target is using "echo -ne" so keep the $ECHO variable > local to it. > > Reported-by: "kernelci.org bot" > Fixes: 3297a4df805d ("kselftests: Enable the echo command to print newlines in Makefile") > Signed-off-by: Guillaume Tucker > --- Thank you - will appear shortly in linuxk-selftest next. thanks, -- Shuah