From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAF262C15BE for ; Tue, 12 May 2026 09:16:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778577384; cv=none; b=bkQm7Fn6DlMSLADNMC3wm2nrbKe4epFhJZrCK0p+BSA4/4CfSx7peXl0TCEyuJduG2WnVfdKMqJ4gsd9ILuQSQOjgr78MybulVL7qfoATGunFkO7XOWcyjSriYICpMGRK3eCUCR4B2tMau3djKRYUPCT9+5fFW0poxQb2rCXpCc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778577384; c=relaxed/simple; bh=futRt67P5rvSyTaYMVnQ8pClOdHlc11Lor1YFVdYXk8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aqfZkrwxckHmP12Y2fuULMJOug/I+B6UKdeTw6pMNYSqu9DmScKYL17kqe1irH/TU3CnwgQh/AqZs+M9b0SzVppKL7NDz18kWLSqg5rlBd8O+2IB0aTEs9kohamAqb8dFbGNTbI+5moBVQ7XJlB+N5M15igzE84QBDOlePfAnHM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gihkmJos; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=ru1UWVw7; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gihkmJos"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="ru1UWVw7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778577381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CNE3Rk33BLnqQIXsr/N6cTDhMglkdYFEZqFp6412RHc=; b=gihkmJosfrVd2PgqQJ9jKvaK4nlXkiZX4ffIgZ3/E2qYOzE8LtMTVRP593TilKF7jKL4fK 7uXx5sLXUoCshbYK1dWZez/iNgwtP5At4Pv/ZEeWeirhA7bzikKFktgjy8cORDWnZcR9fW NSxreF2HllsRJehdHkacBTKaBLENr5U= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-490-EUH5WL62OzeRh5fgpvAC4w-1; Tue, 12 May 2026 05:16:20 -0400 X-MC-Unique: EUH5WL62OzeRh5fgpvAC4w-1 X-Mimecast-MFC-AGG-ID: EUH5WL62OzeRh5fgpvAC4w_1778577379 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-44cc3c9b2feso4882094f8f.1 for ; Tue, 12 May 2026 02:16:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778577379; x=1779182179; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CNE3Rk33BLnqQIXsr/N6cTDhMglkdYFEZqFp6412RHc=; b=ru1UWVw7vjGZb9dVNK44LdA7e5LOCZw8PvmF0L9KRGFd/Z7vhjPNfCmwbhfdZmgc8I fUgDkcM9f7kIwf3y/ajxWUqMKf3TCpD0cWHd+VKzh70126LjovW/sEeIlep3DAFkJpfa 779+9URTGsQ5cKM05DtQiltZLUXA3OwNHRtEwABRzmg71uYWpNufvHnLHptaJNouwk/i 4aqadAQ3U702r64r8RavEPNUIH3N/+4Mvg3tdPIb3hRAn+x+8CGpcEhqv5CWwaiSsNxe 5cvLJW/ow1QAtulhzbOOWj94KlQA13afDrPhOMPNP7mB26jtg1GCIwkZ92VQtvy/Buv8 uPjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778577379; x=1779182179; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CNE3Rk33BLnqQIXsr/N6cTDhMglkdYFEZqFp6412RHc=; b=I5drvCMUjoZFSigDGqXufH6iSEUExyabJrdsQyj7Nbv/7ZTrCtXI6kBInG5JKqx7xn /vEQ5Gbn3ApiwZOugSELBplp2E8XLiQJVe5Ad5xifQyni3cXD4WbJK0uj8tUH8piK9j5 ThCWww2b/5UBBeFfi+y55+W/1KqzgVzQ9TZbKPjtke4pjj99LvxncnAOYFMPzMQ4rjEi iqv0oX9hDVdo0PqbLnTWEIuYqzS2vlY4Ul0HtAuUN5Pp8WPqL7x4GiPO95SV+u+pSViv hd6uLeCyxP7zqgUG5zrEqejalE2kK7MPvRzK3hqmCLeJXOhHPHdnnGm5jcVJ8l/rBJaM lirg== X-Gm-Message-State: AOJu0YzrX7dwxxrhCpjIBMFleXNqu4OY5ITk1CBk2STHc3fHA4gdIjN3 RziyKdg9nztlk6eCubw356KdJYKLOfB+WeiWZQX4GotEg1uex81p+oyTkPGpN8wTjrUk4QE7sCg Tta26mGDSFY0wk8NkOxrQ2lpdEhF2oj1SdlsI3W7Jg9wQwsLP3Tw/IENsNeVIIZ5fdw== X-Gm-Gg: Acq92OHc9u9RpXVhCx2MwQ1MvKzzLpkoqj71BWKmlpXTwuSjATU1/IJcq/JtQz/pKgZ kTpS3BWskOj1AtoaLYvnT0CPSlXtNStXId4jvNRvT95Cb09KD74/mNIDgDvSzFnPvXLgrBpT5zT x1WfjBj9s6+Wy4XLknoq7bgq7GF661LJV3dCEKkp9VPduoP+yMVvIrvkNt+fr+BqF06zDHXZUhs 2+FKWFZZDs+q74b5k/HPxn/wgPjFqpNy3wk3nOCM44Csdfv61FFyinczFHlZllM3tDxn8EOXKSD beLnBiyMLfw98E+Oty+kradAXVEzTLFBerddKaz80mTzoSZnKTHjnPr31yrPpvXg8YxVRXPYqGH obn9E8eiSy0JD/3X6N6lQAubIduBppF2kG7O5wyq5u076qg+qV8BAf+k= X-Received: by 2002:a05:600c:3011:b0:48a:568f:ae6d with SMTP id 5b1f17b1804b1-48e73f1baebmr108985495e9.8.1778577379138; Tue, 12 May 2026 02:16:19 -0700 (PDT) X-Received: by 2002:a05:600c:3011:b0:48a:568f:ae6d with SMTP id 5b1f17b1804b1-48e73f1baebmr108985195e9.8.1778577378567; Tue, 12 May 2026 02:16:18 -0700 (PDT) Received: from [192.168.88.32] ([216.128.9.106]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e906a757esm29406065e9.4.2026.05.12.02.16.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 May 2026 02:16:18 -0700 (PDT) Message-ID: Date: Tue, 12 May 2026 11:16:16 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [net-next v3 3/3] net: phy: motorcomm: Add YT8522 100M RMII PHY support To: Minda Chen , Frank , Andrew Lunn , Heiner Kallweit , "David S . Miller" , Eric Dumazet , Jakub Kicinski , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org References: <20260508094522.3952-1-minda.chen@starfivetech.com> <20260508094522.3952-4-minda.chen@starfivetech.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260508094522.3952-4-minda.chen@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/8/26 11:45 AM, Minda Chen wrote: > Add YT8522 100M RMII ethernet PHY base driver support, including > PHY ID and base config init function. > > Signed-off-by: Minda Chen > --- > drivers/net/phy/motorcomm.c | 49 ++++++++++++++++++++++++++++++++++++- > 1 file changed, 48 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c > index ebc24f51e626..13d57aba5487 100644 > --- a/drivers/net/phy/motorcomm.c > +++ b/drivers/net/phy/motorcomm.c > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0+ > /* > - * Motorcomm 8511/8521/8531/8531S/8821 PHY driver. > + * Motorcomm 8511/8521/8522/8531/8531S/8821 PHY driver. > * > * Author: Peter Geis > * Author: Frank > @@ -14,6 +14,7 @@ > > #define PHY_ID_YT8511 0x0000010a > #define PHY_ID_YT8521 0x0000011a > +#define PHY_ID_YT8522 0x4f51e928 > #define PHY_ID_YT8531 0x4f51e91b > #define PHY_ID_YT8531S 0x4f51e91a > #define PHY_ID_YT8821 0x4f51ea19 > @@ -227,6 +228,13 @@ > #define YT8521_LED_100_ON_EN BIT(5) > #define YT8521_LED_10_ON_EN BIT(4) > > +#define YT8522_EXTREG_SLEEP_CONTROL 0x2027 > +#define YT8522_EN_SLEEP_SW 15 Sashiko noted that the above value looks unusual/inconsistent with other register dedinition. Should it be: BIT(15) instead? Otherwise using GENMASK() would possibly be more clear. /P