From: Damien Le Moal <dlemoal@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>,
Khalid Aziz <khalid@gonehiking.org>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Alexey Gladkov <legion@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Geoff Levand <geoff@infradead.org>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Bart Van Assche <bvanassche@acm.org>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: buslogic: mark blogic_pci_tbl as __maybe_unused
Date: Thu, 31 Jul 2025 12:55:14 +0900 [thread overview]
Message-ID: <ebc412c1-1fff-4dea-8efa-c062b66982cc@kernel.org> (raw)
In-Reply-To: <20250730214451.441025-1-arnd@kernel.org>
On 7/31/25 6:44 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> A previous patch removed an #ifdef check around the array definition, but
> this is not actually used when the driver is built-in, and now causes
> a warning when -Wunused-const-variable is set:
>
> drivers/scsi/BusLogic.c:3727:35: error: 'blogic_pci_tbl' defined but not used [-Werror=unused-const-variable=]
>
> Mark it as __maybe_unused for this configuration.
>
> Ideally this should be fixed instead by using the array as part of
> a pci_driver definition, instead of the linux-2.4 style manual bus
> scan.
>
> Fixes: 204689f0ea20 ("scsi: Always define blogic_pci_tbl structure")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2025-07-31 3:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 21:44 [PATCH] scsi: buslogic: mark blogic_pci_tbl as __maybe_unused Arnd Bergmann
2025-07-31 3:22 ` Martin K. Petersen
2025-07-31 3:55 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebc412c1-1fff-4dea-8efa-c062b66982cc@kernel.org \
--to=dlemoal@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bvanassche@acm.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=geoff@infradead.org \
--cc=khalid@gonehiking.org \
--cc=legion@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).