public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] drm/tegra: dc: Link DC1 to DC0 on Tegra20
Date: Mon, 11 Dec 2017 17:59:29 +0300	[thread overview]
Message-ID: <ebdfcd95-2141-2912-d653-59eb3c68c982@gmail.com> (raw)
In-Reply-To: <20171211101222.GF10671@ulmo>

On 11.12.2017 13:12, Thierry Reding wrote:
> On Mon, Dec 11, 2017 at 02:19:43AM +0300, Dmitry Osipenko wrote:
>> HW reset isn't actually broken on Tegra20, but there is a dependency on
>> first display controller to be taken out of reset for the second to be
>> enabled successfully.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> ---
>>  drivers/gpu/drm/tegra/dc.c | 77 +++++++++++++++++++++++++++++-----------------
>>  drivers/gpu/drm/tegra/dc.h |  4 ++-
>>  2 files changed, 51 insertions(+), 30 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c
>> index fc70351b9017..6139d3e9cedf 100644
>> --- a/drivers/gpu/drm/tegra/dc.c
>> +++ b/drivers/gpu/drm/tegra/dc.c
>> @@ -24,6 +24,8 @@
>>  #include <drm/drm_atomic_helper.h>
>>  #include <drm/drm_plane_helper.h>
>>  
>> +static struct tegra_dc *dc0;
> 
> I'd like to avoid the global variable. Perhaps you can use the
> driver_for_each_device() or driver_find_device() functions to find the
> correct device?

driver_find_device() fit perfectly, thank you for the suggestion.

      reply	other threads:[~2017-12-11 14:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-10 23:19 [PATCH v1 1/2] drm/tegra: dc: Link DC1 to DC0 on Tegra20 Dmitry Osipenko
2017-12-10 23:19 ` [PATCH v1 2/2] drm/tegra: Support disabled CONFIG_PM Dmitry Osipenko
2017-12-11 10:13   ` Thierry Reding
2017-12-11 13:53     ` Dmitry Osipenko
2017-12-11 14:08       ` Dmitry Osipenko
2017-12-11 14:27       ` Thierry Reding
2017-12-11 15:26         ` Dmitry Osipenko
2017-12-14 21:41           ` Lucas Stach
2017-12-14 22:45             ` Dmitry Osipenko
2017-12-15 20:25               ` Lucas Stach
2017-12-15 20:54                 ` Dmitry Osipenko
2017-12-14 23:19             ` Dmitry Osipenko
2017-12-11 10:12 ` [PATCH v1 1/2] drm/tegra: dc: Link DC1 to DC0 on Tegra20 Thierry Reding
2017-12-11 14:59   ` Dmitry Osipenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ebdfcd95-2141-2912-d653-59eb3c68c982@gmail.com \
    --to=digetx@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox