The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: daniel@ffwll.ch, mingo@redhat.com, will@kernel.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/syncobj: make lockdep complain on WAIT_FOR_SUBMIT v2
Date: Tue, 19 Jan 2021 11:08:54 +0100	[thread overview]
Message-ID: <ebf6940b-223c-9b92-3220-a79063723373@amd.com> (raw)
In-Reply-To: <YAau1CBmMNPM5KqV@hirez.programming.kicks-ass.net>

Am 19.01.21 um 11:05 schrieb Peter Zijlstra:
> On Tue, Jan 19, 2021 at 10:46:53AM +0100, Christian König wrote:
>> But I'm going to double check if drm_syncobj_fence_add_wait() isn't used
>> elsewhere as well.
> drm_syncobj_array_wait_timeout()
>
> Which is why I asked.. :-)

Ok, good point as well. But this isn't driver interface and rather IOCTL 
implementation.

So if we hold any locks there it is our own stupidity. Going to add the 
appropriate annotation anyway.

Thanks,
Christian.

      reply	other threads:[~2021-01-19 10:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-18 18:03 Let lockdep complain when locks are taken while waiting for userspace Christian König
2021-01-18 18:03 ` [PATCH] drm/syncobj: make lockdep complain on WAIT_FOR_SUBMIT v2 Christian König
2021-01-18 19:42   ` Randy Dunlap
2021-01-19  9:35   ` Peter Zijlstra
2021-01-19  9:46     ` Christian König
2021-01-19 10:05       ` Peter Zijlstra
2021-01-19 10:08         ` Christian König [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ebf6940b-223c-9b92-3220-a79063723373@amd.com \
    --to=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox