From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751805AbeA2V0k (ORCPT ); Mon, 29 Jan 2018 16:26:40 -0500 Received: from mout.web.de ([212.227.15.3]:61956 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751398AbeA2V0i (ORCPT ); Mon, 29 Jan 2018 16:26:38 -0500 To: linux-iio@vger.kernel.org, linux-input@vger.kernel.org, Hartmut Knaack , Jiri Kosina , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Srinivas Pandruvada Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] iio/orientation: Delete an error message for a failed memory allocation in two functions Message-ID: Date: Mon, 29 Jan 2018 22:26:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:tCfgkEJpQcMPUSHUF3a7hWQK7bet7xxSQMmIaa/ICRkMKIPifMR AEHitkL6F0bHzhhmm6E/VMil6DekrKqeBcbbsGVvd/RDbwWCxFzJ+BNTZBxiu7hEXlVRD8I 46I7k3WYQJ0fLH20DevdJPNA4ZTQBT0tzDD1aCfKs/PUUJt5CB4r0iFKK1gaIeYFw9EX5GB vwNJMTLo2wePVFG8vc/zw== X-UI-Out-Filterresults: notjunk:1;V01:K0:0C2A+irfkzs=:+dmilspa5ScKCLooHNrMm8 Y4lHGPd31Qb6WWxUQS2keswTtGJRd5D9V5Z+WgjJJMNTE9XM7IAvoce771BfQtiRxsArehcXG 8Ce+HyQMiCyA64EFwRSnR6yfryZm2/NAjKLgBGRg11wSMtX+GDPJjydEzB9j4Zozz2DdKxU8Y CrDEoGzaHw0WeU+7a7Xh3ngdEGymhhowVKaPDLT75ryoCPmICIzPZlv4/nHRYEHS1grqoJMHd VXlrbGwJ4M6gRZTWthTfGsBIcvCDg1RPICGRYfdF2vdZ+iz40HnyW7TyEPFAfVlCy4QTda0rW LFdnEaNlB/kf8yQI5u9LIUwnsLhVu7D2/9h7Kv2mmWxbBXCMYspa6HcNYMr7qzLziyx+Wz6Sp AAOAZdrkK7Bz3ABmaEuizEM6yAG259Mri5yCggcwmiZ/K03iDrVqO/u70dqiEv5mRqV4ulvtx XjueykYO3dTnhBQaI7CDcYD8CGecxe53PkvScCvcskkW3P0NGtnxGZv8zgGAqCsz+tQgj8xJC uyQhd+mV4sm9+Smaam/D9yfJdjioOPRvNbrKfOZBPq1TgxEXQ4IGpbphVZ9ev17zAQVAUHNeH Itnt3BP/qQJsN4clEm3r05Hg+AHK1cEodSiRArRZj5zAP4oJ2SgKBDkfDNE7iP8zbYEcE3Evp qj2EAVf31mgaze3pYWH+PFUnnAPt5KSyh3Xw0TLB5JF0ozlescuqC2XAuSkotq9NvLwJYV3gG JQTgXcWNxdYRbzYbsau2uLCF021/Bt+glzsAWnl+N8dRgXWIOW47K9vxFDn+w9nNr0TBZJr0M YmjxeKU+aENffrBMavh+VhdTsAi1CxwWBH353lUtVRv49mdJyc= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 29 Jan 2018 22:20:07 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/iio/orientation/hid-sensor-incl-3d.c | 4 +--- drivers/iio/orientation/hid-sensor-rotation.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/iio/orientation/hid-sensor-incl-3d.c b/drivers/iio/orientation/hid-sensor-incl-3d.c index 1e5451d1ff88..742c0e0eb4cf 100644 --- a/drivers/iio/orientation/hid-sensor-incl-3d.c +++ b/drivers/iio/orientation/hid-sensor-incl-3d.c @@ -336,10 +336,8 @@ static int hid_incl_3d_probe(struct platform_device *pdev) indio_dev->channels = kmemdup(incl_3d_channels, sizeof(incl_3d_channels), GFP_KERNEL); - if (!indio_dev->channels) { - dev_err(&pdev->dev, "failed to duplicate channels\n"); + if (!indio_dev->channels) return -ENOMEM; - } ret = incl_3d_parse_report(pdev, hsdev, (struct iio_chan_spec *)indio_dev->channels, diff --git a/drivers/iio/orientation/hid-sensor-rotation.c b/drivers/iio/orientation/hid-sensor-rotation.c index a69db2002414..cbf5e406b1ee 100644 --- a/drivers/iio/orientation/hid-sensor-rotation.c +++ b/drivers/iio/orientation/hid-sensor-rotation.c @@ -277,10 +277,8 @@ static int hid_dev_rot_probe(struct platform_device *pdev) indio_dev->channels = devm_kmemdup(&pdev->dev, dev_rot_channels, sizeof(dev_rot_channels), GFP_KERNEL); - if (!indio_dev->channels) { - dev_err(&pdev->dev, "failed to duplicate channels\n"); + if (!indio_dev->channels) return -ENOMEM; - } ret = dev_rot_parse_report(pdev, hsdev, (struct iio_chan_spec *)indio_dev->channels, -- 2.16.1