From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C1B0C433E2 for ; Wed, 15 Jul 2020 00:13:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 744132074B for ; Wed, 15 Jul 2020 00:13:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728051AbgGOANf (ORCPT ); Tue, 14 Jul 2020 20:13:35 -0400 Received: from mga06.intel.com ([134.134.136.31]:47113 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726630AbgGOANe (ORCPT ); Tue, 14 Jul 2020 20:13:34 -0400 IronPort-SDR: CtM1WORkacd972AGW0Obh+ilLGh5FpFSaMrYp/XaCxXmqbZyWbEdGzw3zGSddBmaqOuwnxzPqN enYvT6XRJcNg== X-IronPort-AV: E=McAfee;i="6000,8403,9682"; a="210594433" X-IronPort-AV: E=Sophos;i="5.75,353,1589266800"; d="scan'208";a="210594433" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2020 17:13:33 -0700 IronPort-SDR: PK7uvFFOTnYHCNwAm816+GkW7R98emeBsMeQ7hEr5zc8vpsrTpRdOnFz4YETKMDpX4Z4W5ksCN EVJ3G/ppb6kA== X-IronPort-AV: E=Sophos;i="5.75,353,1589266800"; d="scan'208";a="485538272" Received: from spandruv-mobl.amr.corp.intel.com ([10.255.228.223]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2020 17:13:32 -0700 Message-ID: Subject: Re: [PATCH v2] powercap: Add Power Limit4 support From: Srinivas Pandruvada To: "Rafael J. Wysocki" , Sumeet Pawnikar Cc: "Rafael J. Wysocki" , "Zhang, Rui" , Linux PM , Linux Kernel Mailing List , "Shevchenko, Andriy" Date: Tue, 14 Jul 2020 17:13:32 -0700 In-Reply-To: References: <1594715306-10411-1-git-send-email-sumeet.r.pawnikar@intel.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2020-07-14 at 15:21 +0200, Rafael J. Wysocki wrote: > > [...] > On Tue, Jul 14, 2020 at 10:22 AM Sumeet Pawnikar > wrote: > > Srinivas, does the patch look good to you? Some minor comments then Summet can add my Reviewed-and-tested-by: Srinivas Pandruvada < srinivas.pandruvada@linux.intel.com> > > --- > > Changes in v2: > > - Addressed review comments from Rafael. > > - Made the commit message more clearer. > > - Updated powercap documentation. > > --- > > [...] > > 0,1). > > +Depending on different power zones, the Intel RAPL technology > > allows > > +one or multiple constraints like short term, long term and peak > > power, > > +with different time windows to be applied to each power zone. I think better to spell out that time window is not applicable to "peak power". Otherwise someone will send a bug report. [...] > > static int rapl_msr_probe(struct platform_device *pdev) > > { > > int ret; > > + const struct x86_cpu_id *id = > > x86_match_cpu(pl4_support_ids); To match coding style in this file: const struct x86_cpu_id *id = x86_match_cpu(pl4_support_ids); int ret; > > rapl_msr_priv.read_raw = rapl_msr_read_raw; Thanks, Srinivas