From: "Jürgen Groß" <jgross@suse.com>
To: xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: Peter Jones <pjones@redhat.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH] efi: avoid error message when booting under Xen
Date: Thu, 9 Jul 2020 11:17:44 +0200 [thread overview]
Message-ID: <ec21b883-dc5c-f3fe-e989-7fa13875a4c4@suse.com> (raw)
In-Reply-To: <094be567-2c82-7d5b-e432-288286c6c3fb@suse.com>
On 28.06.20 10:50, Jürgen Groß wrote:
> Ping?
>
> On 10.06.20 16:10, Juergen Gross wrote:
>> efifb_probe() will issue an error message in case the kernel is booted
>> as Xen dom0 from UEFI as EFI_MEMMAP won't be set in this case. Avoid
>> that message by calling efi_mem_desc_lookup() only if EFI_PARAVIRT
>> isn't set.
>>
>> Fixes: 38ac0287b7f4 ("fbdev/efifb: Honour UEFI memory map attributes
>> when mapping the FB")
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> ---
>> drivers/video/fbdev/efifb.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
>> index 65491ae74808..f5eccd1373e9 100644
>> --- a/drivers/video/fbdev/efifb.c
>> +++ b/drivers/video/fbdev/efifb.c
>> @@ -453,7 +453,7 @@ static int efifb_probe(struct platform_device *dev)
>> info->apertures->ranges[0].base = efifb_fix.smem_start;
>> info->apertures->ranges[0].size = size_remap;
>> - if (efi_enabled(EFI_BOOT) &&
>> + if (efi_enabled(EFI_BOOT) && !efi_enabled(EFI_PARAVIRT) &&
>> !efi_mem_desc_lookup(efifb_fix.smem_start, &md)) {
>> if ((efifb_fix.smem_start + efifb_fix.smem_len) >
>> (md.phys_addr + (md.num_pages << EFI_PAGE_SHIFT))) {
>>
>
In case I see no reaction from the maintainer for another week I'll take
this patch through the Xen tree.
Juergen
next prev parent reply other threads:[~2020-07-09 9:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 14:10 [PATCH] efi: avoid error message when booting under Xen Juergen Gross
2020-06-28 8:50 ` Jürgen Groß
2020-07-09 9:17 ` Jürgen Groß [this message]
2020-07-10 10:16 ` Bartlomiej Zolnierkiewicz
2020-07-10 13:27 ` Ard Biesheuvel
2020-07-10 13:38 ` Jürgen Groß
2020-07-10 13:41 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec21b883-dc5c-f3fe-e989-7fa13875a4c4@suse.com \
--to=jgross@suse.com \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pjones@redhat.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox