Re: [PATCH RFC v1 07/20] KVM: nVMX: Support the extended instruction info field

Chang S. Bae
2025-11-13T23:21:21Z

On 11/11/2025 5:54 PM, Chao Gao wrote:
>
> Shouldn't we check guest's capabilities rather than host's,
>
> i.e., guest_cpu_cap_has(X86_FEATURE_APX)?

Perhaps adding a comment like this would help clarify it:

/*
* The APX enumeration guarantees the presence of the extended
* field. The host CPUID bit alone is sufficient to rely on it.
*/
static inline bool vmx_ext_insn_info_available(void) {
return static_cpu_has(X86_FEATURE_APX);
}