From: shuah <shuah@kernel.org>
To: Frank Rowand <frowand.list@gmail.com>,
David Gow <davidgow@google.com>,
brendanhiggins@google.com, skhan@linuxfoundation.org,
corbet@lwn.net
Cc: kunit-dev@googlegroups.com, linux-doc@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Tim.Bird@sony.com, Frank Rowand <frank.rowand@sony.com>,
shuah <shuah@kernel.org>
Subject: Re: [PATCH v4] Documentation: kunit: Make the KUnit documentation less UML-specific
Date: Fri, 13 Mar 2020 10:05:30 -0600 [thread overview]
Message-ID: <ec2f35ef-54d2-cd67-5e30-33ce7612a6d4@kernel.org> (raw)
In-Reply-To: <dd15aa59-d2ef-d42e-1a4f-82b42e2ea350@gmail.com>
On 3/2/20 9:50 AM, Frank Rowand wrote:
> Hi David,
>
> On 2/28/20 1:18 PM, David Gow wrote:
>> Remove some of the outmoded "Why KUnit" rationale, and move some
>> UML-specific information to the kunit_tool page. Also update the Getting
>> Started guide to mention running tests without the kunit_tool wrapper.
>>
>> Signed-off-by: David Gow <davidgow@google.com>
>> Reviewed-by: Frank Rowand <frank.rowand@sony.com>
>> ---
>> Sorry: I missed a couple of issues in the last version. They're fixed
>> here, and I think this should be ready to go.
>>
>> Changelog:
>>
>> v4:
>> - Fix typo: s/offsers/offers
>> - Talk about KUnit tests running on most "architectures" instead of
>> "kernel configurations.
>> v3:
>> https://lore.kernel.org/linux-kselftest/20200214235723.254228-1-davidgow@google.com/T/#u
>> - Added a note that KUnit can be used with UML, both with and without
>> kunit_tool to replace the section moved to kunit_tool.
>> v2:
>> https://lore.kernel.org/linux-kselftest/f99a3d4d-ad65-5fd1-3407-db33f378b1fa@gmail.com/T/
>> - Reinstated the "Why Kunit?" section, minus the comparison with other
>> testing frameworks (covered in the FAQ), and the description of UML.
>> - Moved the description of UML into to kunit_tool page.
>> - Tidied up the wording around how KUnit is built and run to make it
>> work
>> without the UML description.
>> v1:
>> https://lore.kernel.org/linux-kselftest/9c703dea-a9e1-94e2-c12d-3cb0a09e75ac@gmail.com/T/
>> - Initial patch
>
> Thanks for all the changes. The documents are now much more understandable
> and useful.
>
Is this ready to go? If it goes through doc tree:
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
Otherwise, I can pic it up.
thanks,
-- Shuah
next prev parent reply other threads:[~2020-03-13 16:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 19:18 [PATCH v4] Documentation: kunit: Make the KUnit documentation less UML-specific David Gow
2020-03-02 16:50 ` Frank Rowand
2020-03-13 16:05 ` shuah [this message]
2020-03-13 23:36 ` Brendan Higgins
2020-03-13 23:35 ` Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec2f35ef-54d2-cd67-5e30-33ce7612a6d4@kernel.org \
--to=shuah@kernel.org \
--cc=Tim.Bird@sony.com \
--cc=brendanhiggins@google.com \
--cc=corbet@lwn.net \
--cc=davidgow@google.com \
--cc=frank.rowand@sony.com \
--cc=frowand.list@gmail.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox