public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kevin Brodsky <kevin.brodsky@arm.com>
To: Jinjie Ruan <ruanjinjie@huawei.com>,
	catalin.marinas@arm.com, will@kernel.org, oleg@redhat.com,
	tglx@linutronix.de, peterz@infradead.org, luto@kernel.org,
	shuah@kernel.org, kees@kernel.org, wad@chromium.org,
	deller@gmx.de, macro@orcam.me.uk, charlie@rivosinc.com,
	ldv@strace.io, mark.rutland@arm.com, song@kernel.org,
	ryan.roberts@arm.com, ada.coupriediaz@arm.com,
	anshuman.khandual@arm.com, broonie@kernel.org,
	pengcan@kylinos.cn, dvyukov@google.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v9 13/16] arm64: entry: Convert to generic entry
Date: Tue, 9 Dec 2025 14:47:35 +0100	[thread overview]
Message-ID: <ec404a91-2e24-4198-975b-e26c6a8330f8@arm.com> (raw)
In-Reply-To: <20251204082123.2792067-14-ruanjinjie@huawei.com>

On 04/12/2025 09:21, Jinjie Ruan wrote:
> Currently, x86, Riscv, Loongarch use the generic entry which makes
> maintainers' work easier and codes more elegant. arm64 has already
> switched to the generic IRQ entry, so completely convert arm64 to use
> the generic entry infrastructure from kernel/entry/*.
>
> The changes are below:
>  - Remove TIF_SYSCALL_* flag.
>
>  - Remove _TIF_SYSCALL_WORK and has_syscall_work(), as _TIF_SYSCALL_WORK
>    is equal with SYSCALL_WORK_ENTER.

Should be updated considering patch 7 (has_syscall_work() no longer
exists and there is also _TIF_SYSCALL_EXIT_WORK).

>  - Implement arch_ptrace_report_syscall_entry/exit() with
>    report_syscall_entry/exit() to do arm64-specific save/restore
>    during syscall entry/exit.
>
>  - Add "ARCH_SYSCALL_WORK_EXIT" to be defined as "_TIF_SECCOMP |
>    _TIF_SYSCALL_EMU" to keep the arm64 behaviour unchanged.

No longer the case.

>  - Remove arm64 syscall_trace_enter(), syscall_exit_to_user_mode_prepare(),
>    and related sub-functions including syscall_exit_work() and
>    syscall_enter_audit(), by calling generic entry's functions with similar
>    functionality.

Would be good to talk about SYSCALL_EXIT_TRAP as well.

Otherwise:

Reviewed-by: Kevin Brodsky <kevin.brodsky@arm.com>

> - Implement arch_syscall_is_vdso_sigreturn() to support "Syscall User
>   Dispatch".
>
> Suggested-by: Kevin Brodsky <kevin.brodsky@arm.com>
> Suggested-by: Mark Rutland <mark.rutland@arm.com>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
>
> [...]

  reply	other threads:[~2025-12-09 13:47 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-04  8:21 [PATCH v9 00/16] arm64: entry: Convert to Generic Entry Jinjie Ruan
2025-12-04  8:21 ` [PATCH v9 01/16] arm64: Remove unused _TIF_WORK_MASK Jinjie Ruan
2025-12-08  4:42   ` Anshuman Khandual
2025-12-04  8:21 ` [PATCH v9 02/16] arm64/ptrace: Split report_syscall() Jinjie Ruan
2025-12-08  5:02   ` Anshuman Khandual
2025-12-04  8:21 ` [PATCH v9 03/16] arm64/ptrace: Return early for ptrace_report_syscall_entry() error Jinjie Ruan
2025-12-08  5:24   ` Anshuman Khandual
2025-12-08  6:31     ` Jinjie Ruan
2025-12-09 13:46   ` Kevin Brodsky
2025-12-12  4:00     ` Jinjie Ruan
2025-12-15 15:24       ` Kevin Brodsky
2025-12-04  8:21 ` [PATCH v9 04/16] arm64/ptrace: Refactor syscall_trace_enter/exit() Jinjie Ruan
2025-12-08  5:48   ` Anshuman Khandual
2025-12-08  6:24     ` Jinjie Ruan
2025-12-04  8:21 ` [PATCH v9 05/16] arm64: ptrace: Move rseq_syscall() before audit_syscall_exit() Jinjie Ruan
2025-12-04  8:21 ` [PATCH v9 06/16] arm64: syscall: Rework el0_svc_common() Jinjie Ruan
2025-12-04  8:21 ` [PATCH v9 07/16] arm64/ptrace: Not check _TIF_SECCOMP/SYSCALL_EMU for syscall_exit_work() Jinjie Ruan
2025-12-04  8:21 ` [PATCH v9 08/16] arm64/ptrace: Do not report_syscall_exit() for PTRACE_SYSEMU_SINGLESTEP Jinjie Ruan
2025-12-04  8:21 ` [PATCH v9 09/16] arm64/ptrace: Expand secure_computing() in place Jinjie Ruan
2025-12-04  8:21 ` [PATCH v9 10/16] arm64/ptrace: Use syscall_get_arguments() helper Jinjie Ruan
2025-12-04  8:21 ` [PATCH v9 11/16] entry: Split syscall_exit_to_user_mode_work() for arch reuse Jinjie Ruan
2025-12-04  8:21 ` [PATCH v9 12/16] entry: Add arch_ptrace_report_syscall_entry/exit() Jinjie Ruan
2025-12-04  8:21 ` [PATCH v9 13/16] arm64: entry: Convert to generic entry Jinjie Ruan
2025-12-09 13:47   ` Kevin Brodsky [this message]
2025-12-04  8:21 ` [PATCH v9 14/16] arm64: Inline el0_svc_common() Jinjie Ruan
2025-12-09 13:48   ` Kevin Brodsky
2025-12-10  2:56     ` Jinjie Ruan
2025-12-04  8:21 ` [PATCH v9 15/16] entry: Inline syscall_exit_work() Jinjie Ruan
2025-12-09 13:48   ` Kevin Brodsky
2025-12-11  6:55     ` Thomas Gleixner
2025-12-11  9:52       ` Kevin Brodsky
2025-12-12  1:12         ` Thomas Gleixner
2025-12-12  1:26       ` Jinjie Ruan
2025-12-12  3:49     ` Jinjie Ruan
2025-12-04  8:21 ` [PATCH v9 16/16] selftests: sud_test: Support aarch64 Jinjie Ruan
2025-12-20 14:53   ` kemal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec404a91-2e24-4198-975b-e26c6a8330f8@arm.com \
    --to=kevin.brodsky@arm.com \
    --cc=ada.coupriediaz@arm.com \
    --cc=anshuman.khandual@arm.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=charlie@rivosinc.com \
    --cc=deller@gmx.de \
    --cc=dvyukov@google.com \
    --cc=kees@kernel.org \
    --cc=ldv@strace.io \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=macro@orcam.me.uk \
    --cc=mark.rutland@arm.com \
    --cc=oleg@redhat.com \
    --cc=pengcan@kylinos.cn \
    --cc=peterz@infradead.org \
    --cc=ruanjinjie@huawei.com \
    --cc=ryan.roberts@arm.com \
    --cc=shuah@kernel.org \
    --cc=song@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=wad@chromium.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox