From: Jens Axboe <axboe@kernel.dk>
To: Tejun Heo <tj@kernel.org>, Jan Kara <jack@suse.cz>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [block/for-next] writeback: don't access page->mapping directly in track_foreign_dirty TP
Date: Fri, 30 Aug 2019 19:54:51 -0600 [thread overview]
Message-ID: <ec4d9155-76bc-2586-7a56-d8f495537b80@kernel.dk> (raw)
In-Reply-To: <20190830233954.GC2263813@devbig004.ftw2.facebook.com>
On 8/30/19 5:39 PM, Tejun Heo wrote:
> page->mapping may encode different values in it and page_mapping()
> should always be used to access the mapping pointer.
> track_foreign_dirty tracepoint was incorrectly accessing page->mapping
> directly. Use page_mapping() instead. Also, add NULL checks while at
> it.
Applied, thanks.
--
Jens Axboe
next prev parent reply other threads:[~2019-08-31 1:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 23:39 [block/for-next] writeback: don't access page->mapping directly in track_foreign_dirty TP Tejun Heo
2019-08-31 1:54 ` Jens Axboe [this message]
2019-09-02 8:56 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec4d9155-76bc-2586-7a56-d8f495537b80@kernel.dk \
--to=axboe@kernel.dk \
--cc=jack@suse.cz \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox