From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20A7CC761AF for ; Wed, 29 Mar 2023 02:41:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229510AbjC2ClR (ORCPT ); Tue, 28 Mar 2023 22:41:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229953AbjC2ClO (ORCPT ); Tue, 28 Mar 2023 22:41:14 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83DB33C00; Tue, 28 Mar 2023 19:40:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4E674B81FAE; Wed, 29 Mar 2023 02:40:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2EFBC433EF; Wed, 29 Mar 2023 02:40:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680057645; bh=z3w8jCQ7oyDDkOoaUxLNZiisOncdpSmRzIZSu+yjkaU=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=Rbyq13eNuuLQkM23s7y+tHwSB/eE0toV7Ft8BAhP0YTHFfrxHTy+mmElac4uFlWmn ZAeL0+acNPDPd/OHa46N3fmQx5LTqiThLq7oenOBQAK/dLl/sSD7Qlik4C1Flw9/70 RXOd7vmqgozsNfkUXne83CzCsRKmHQt+8MGStnrj5S197xCfTH9q9SfCESUTFXgqtk cuJPIk6Kmn6i272YvMHyt3PtIruSpie012s/+vQdrFn4ShotxFA+skdLz7pj6V0M8P FUzU7S7Jg5MNarpdEYsOqmH65IKAgNLE/t8B6wCNDHwuee4AsmhVjbRk0FX/2wYQkr LGuCRNHBuJLcA== Message-ID: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230312161512.2715500-29-u.kleine-koenig@pengutronix.de> References: <20230312161512.2715500-1-u.kleine-koenig@pengutronix.de> <20230312161512.2715500-29-u.kleine-koenig@pengutronix.de> Subject: Re: [PATCH 28/30] clk: uniphier: Convert to platform remove callback returning void From: Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org To: Kunihiko Hayashi , Masami Hiramatsu , Michael Turquette , Uwe =?utf-8?q?Kleine-K=C3=B6nig?= Date: Tue, 28 Mar 2023 19:40:42 -0700 User-Agent: alot/0.10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Uwe Kleine-K=C3=B6nig (2023-03-12 09:15:10) > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. >=20 > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. >=20 > Signed-off-by: Uwe Kleine-K=C3=B6nig > --- Applied to clk-next