Re: [PATCH v3 4/4] platform/x86: intel_tdx_attest: Add TDX Guest attestation interface driver

Sathyanarayanan Kuppuswamy
2022-04-20T01:26:50Z

On 4/19/22 6:20 PM, Isaku Yamahata wrote:
> If timeout occurs, the state of adev->tdquote_buf is unknown. It's not safe
> to continue to using adev->tdquote_buf. VMM would continue to processing
> getquote request with this buffer. What if TDX_CMD_GEN_QUOTE is issued again,
> and tdquote_buf is re-used?

This part is not clearly discussed in the specification. May be spec
should define some reasonable timeout and teardown details.

Regarding not using this buffer again, what happens if we de-allocate
it on timeout and the host still updates it?

--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer