Re: [PATCH v3 4/4] platform/x86: intel_tdx_attest: Add TDX Guest attestation interface driver

Borislav Petkov
2022-04-19T08:13:52Z

On Tue, Apr 19, 2022 at 07:47:33PM +1200, Kai Huang wrote:
> From this perspective, I am not sure what's the value of having a dedicated
> INTEL_TDX_ATTESTATION Kconfig. The attestation support code should be turned on
> unconditionally when CONFIG_INTEL_TDX_GUEST is on. The code can also be just
> under arch/x86/coco/tdx/ I guess?
>
> But I'll leave this to maintainers.

Similar story with the unaccepted memory gunk. If it is not going to
be used outside of encrypted guests, why are we polluting our already
insanely humongous Kconfig space with more symbols?

--
Regards/Gruss,
Boris.