From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f0.google.com (mail-pj2-f0.google.com [74.125.227.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A24C82E11C7 for ; Sat, 8 Aug 2026 14:39:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.128 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786199961; cv=none; b=enrxHgFreTax3No/i1uq20YWY4yrlJipLrA4hiDrRA8jwg7TA/iaxPNYhiwP0wDlMkq+oSzgtKz/t4FU9VbD1QiTaa7gob39GJXQ+hgGf+hrdiOeEXZLBv3sjHWfLC7koIKW/f7mxNBIpC1H5ejQz9ffmpdArO9xn77vq/y+RqA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786199961; c=relaxed/simple; bh=GNZdbMnUJ+VqGa8a7gNHiTQSeSgxpLKBAsS0DNjAnew=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=nGPriz9Y2fePO2YXNNRQvwzc+qOkQnuq5/7PotZuO8+xzBsaGpwvVke5hcLc+fIPGyL1lLGrlVb3OG6Oqjl+Ne9zONFfz46JYReGYtymuQUNJBg1kY8D5amMRz1jwvWyqUxXQIqHL+7ysowBwyVheS3ja55DIEM/n3qZ8ZTI0dM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=D26+vpQv; arc=none smtp.client-ip=74.125.227.128 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D26+vpQv" Received: by mail-pj2-f0.google.com with SMTP id 98e67ed59e1d1-380f4166f80so526818a91.1 for ; Sat, 08 Aug 2026 07:39:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786199960; x=1786804760; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:subject:cc:to:from:message-id:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=gLPlagPSnxq9fTONnyyz/3ddba5KQ5Gz9V5u0Vh5tVQ=; b=D26+vpQvhZwWjfur4gExF4hKMVinXGQ8obSX9UAbU8f4ld5iF9Pm94eQ3TZBsRHat7 fGS8VUOKSbooARdm29094mB/TDc/gC2+RZoXTwImtkQ8TEpMNSezTACtE6BNV7omosgf ZG5bxKg9W7DpJVstLlKmpbPpC21cwjUnRj8TD/GOSNbucSFcdyfoURNJNBxyFS6pkWyW uDAjqu9Z5F2Db2j/lxJH7Meii1iltQKblF9l/8NeDat4mjRWXXGxx4jo4c28ilqXXYtj kt4tVac3ruTmKa54v8N8oJVbk3VZyEwKn9VVinio5Yn2yh84uiN2iQ+En55SWY5K9r3Q OYWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786199960; x=1786804760; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:subject:cc:to:from:message-id:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gLPlagPSnxq9fTONnyyz/3ddba5KQ5Gz9V5u0Vh5tVQ=; b=B7T9mjY61R0c1JvigsUfzYp2gE9S4AJfv/UuExoU644xFKquzE6yQ7kQwhzDlinlF7 g+lKxVZryiTZBJae99lUu/dPCZ2c6u15GTrxVL8/o9/3u0usOohtoqEiJNEA84t1vqv2 lB9ze+Jsebm+54sDtPSlz+lY4Uaip05U+EKECIWoLfQSlBmbhBnmdGuX7+9+2Gf6+Tlj mXH8XFaYhIiRfjHJTzXBAqV0Rp2MLhdEt9LeeQLK2bBgjQTXxuMFdVm/w/I2uGM5Xugn WGERxPkC+nkNgx2XEEN5jKHidRSxZnQZive3AqAvuH0TE5uTi4oYInbcepJDycIe0zrB iERA== X-Forwarded-Encrypted: i=1; AHgh+Rpkz14sfxcNf0ssIwfcXPxSx8UVQtTWThHL6A8u6JFC8z5Z7F0sj5qCX9YEdzgWUD7Y54DxPIC+I961Pps=@vger.kernel.org X-Gm-Message-State: AOJu0YzNZteOYrVCi+Y4SyJM+M3lAzPcW3J+JTiLVEWGN02Uw6lj60B3 eq/6ecdoSzvwowpaOegoH0fInZlChh/ll7aOexU9lfKhzSYviRdU9WPj X-Gm-Gg: AR+sD13HB2isRvL2KZaJkJzfrSlzXwu51R4kc/cojymtWwLQ0VJ/JHcxDuLwUB4UdT7 7QkGmvxwpFkF6fBS0LfQNCNNOq6Mrpg/UZ0FmY2uwf5SbAW0TmIaaRXedrBone7zqfH6DOOFoTh twkZRykBTuHDPopDeyQ2UwNASay5q/enlW0JcppzybI34Lw6JkEa1qGw3hA0xIfY/srBRpgduZd +hj2rl3iHghP8u26t1TywQRG054igTUv7ayhPp7fyqkx7UKS4K67lvJ9u/FM5mXBLDv6DfOours fspYt0ZLZXzeIQ3FAWSuBck3kggWyfHYq4Ab/cru2rAYoDb2AvkgZF2dLEcR+W91DTBMSMHyZYC XKoS/h4SleaMF8Ivde4kq2XtXpadIm1xRPRQcIL6DXpj/a5U0w3PzdUhji8VDB3WfTXdBsyeqWF C8tRXRibagcbgyieEDfEIyTwdKDs3C83gSCABpsrg= X-Received: by 2002:a17:90b:2585:b0:38e:bbf1:de34 with SMTP id 98e67ed59e1d1-39261fdab5amr13832835a91.7.1786199959787; Sat, 08 Aug 2026 07:39:19 -0700 (PDT) Received: from localhost ([2403:2c80:17:1e::20db]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3925fd95794sm6424491a91.7.2026.08.08.07.39.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 07:39:19 -0700 (PDT) Date: Sat, 08 Aug 2026 22:39:16 +0800 Message-ID: From: Cody Kang To: Rob Herring Cc: David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Vinod Koul , Neil Armstrong , Haylen Chu , Michael Turquette , Stephen Boyd , Brian Masney , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , dri-devel@lists.freedesktop.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [PATCH RESEND 03/17] dt-bindings: display: spacemit: add K3 Innosilicon DP/eDP controller In-Reply-To: <20260807230404.GA2211679-robh@kernel.org> References: <20260725-k3-display-v1-0-6de34d80e86c@gmail.com> <20260725-k3-display-v1-3-6de34d80e86c@gmail.com> <20260807230404.GA2211679-robh@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Hi Rob, On Fri, 07 Aug 2026 18:04:04 -0500, Rob Herring wrote: > On Sat, Jul 25, 2026 at 12:51:12AM -0400, Cody Kang wrote: > > Both K3 instances are the same IP and share one compatible; which one > > behaves as eDP is decided by what its downstream port is wired to, not by > > which register window it sits in, so the binding does not distinguish them. > > > > Signed-off-by: Cody Kang > > --- > > .../display/spacemit/spacemit,k3-inno-dp.yaml | 140 +++++++++++++++++++++ > > 1 file changed, 140 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/spacemit/spacemit,k3-inno-dp.yaml b/Documentation/devicetree/bindings/display/spacemit/spacemit,k3-inno-dp.yaml > > new file mode 100644 > > index 000000000000..865ea310daaf > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/spacemit/spacemit,k3-inno-dp.yaml > > @@ -0,0 +1,140 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/spacemit/spacemit,k3-inno-dp.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: SpacemiT K3 Innosilicon DisplayPort / embedded DisplayPort Controller > > + > > +maintainers: > > + - Cody Kang > > + > > +description: > > + Innosilicon DisplayPort transmit controller integrated in the SpacemiT K3 > > + SoC. The K3 has two instances of the same block sharing one compatible; > > + each acts as embedded or external DisplayPort depending on whether its > > + output port drives a panel or a connector. > > + > > +properties: > > + compatible: > > + const: spacemit,k3-inno-dp > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + description: Link and hot-plug events. > > + > > + clocks: > > + items: > > + - description: Pixel clock for the controller. > > + - description: > > + Pixel clock generated by the DP PHY PLL; the pixel clock above is > > + parented onto it in use. > > + > > + clock-names: > > + items: > > + - const: pxclk > > + - const: pll > > + > > + resets: > > + maxItems: 1 > > + description: Controller-wide reset signal. > > + > > + phys: > > + maxItems: 1 > > + description: Phandle to the K3 Innosilicon DP PHY. > > + > > + phy-names: > > + items: > > + - const: dp > > + > > + ports: > > + $ref: /schemas/graph.yaml#/properties/ports > > + > > + properties: > > + port@0: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: Video input from the DPU. > > + > > + port@1: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: Output to the panel or to the DisplayPort connector. > > + > > + required: > > + - port@0 > > Shouldn't port@1 be required too? Thanks for the review. Yes, will make port@1 required in v2 and describe the DP connector on the board side (dp-connector) so the graph is complete. > Otherwise, > > Reviewed-by: Rob Herring (Arm) Thanks! Will pick up your Reviewed-by with that change in v2. Cody