From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19BBB32571C for ; Thu, 8 Jan 2026 18:46:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.20 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767898002; cv=fail; b=pNIQjg3pXSu1xoZZRxR26iqOHCw67BvYrXTZegqRo/FSF2WkCfYRYRmZ2QMZRhBkxDzbd5/pTKS5RPWmfWnggV3YAS+VdivWEaQdvi8rDcWE4nuNWEkvpWw4B3M1TP8fBWPRbK+VFIdFYWzK+JRT0014C3Cx+yll/pldXS3zA64= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767898002; c=relaxed/simple; bh=MBp9SoYt5G75LjLcWCpSMBbtgbuzvGGnELRozZLFs8w=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=NOMYWGCM3JvRJLmlxfsSZArv1na6lEMgsAlThsNu0D91YjnB96VJyxBwMBA9WY/XLO0sylbf1CRUzy3tK0JhLzg02BlXikK0JTx90GARkp2SdA7WJqJzQf3Ro3DrlZFMb9B3udEUNRqr4/cbRGcrt9KowK9wmDOaY0aoBnMzYe8= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=eg5Z3xq2; arc=fail smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="eg5Z3xq2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1767897997; x=1799433997; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=MBp9SoYt5G75LjLcWCpSMBbtgbuzvGGnELRozZLFs8w=; b=eg5Z3xq29UOS+/bwXMC890L4ojG5UIb7YfzgfP6laNrSBvMcaMJEO5C/ aexeqlBBf5hw7he9JB7b1aZQIJP+7YbcFiDxA7HGRQ1eOCSKSm9Ngc2bh 3aeWb9hTSoccDGBSRoVrF7JQNTI9SeHCegm8wnJRHUTyZy6NaWnKDFWuw K4Gx4y9BOOm06wqgMuyzxHHx7N2Ud76FM7ZPC/xYtmSEe0mrjlGkr+GYf vkVl1fYBSwsEr89uA9AujAdgpOuSu/OVBZv86nqMmBfgLE1RdMI1CcYqr EOsEaIl5t81chUjLB96Ka5CyPsDz7vdKwyyKtIrdJ9fnDaGzv1mYENYMZ g==; X-CSE-ConnectionGUID: uD2EUc8LSpawEC9cFjl4iw== X-CSE-MsgGUID: Xgr8uywGRDeMwo4zG4rMCg== X-IronPort-AV: E=McAfee;i="6800,10657,11665"; a="69021675" X-IronPort-AV: E=Sophos;i="6.21,211,1763452800"; d="scan'208";a="69021675" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2026 10:46:35 -0800 X-CSE-ConnectionGUID: oL2BLaSRSQu4Mgm+ED+yGA== X-CSE-MsgGUID: k9+y7+3zR8Cwyn/S6L/6GQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,211,1763452800"; d="scan'208";a="204134311" Received: from fmsmsx903.amr.corp.intel.com ([10.18.126.92]) by fmviesa010.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2026 10:46:35 -0800 Received: from FMSMSX902.amr.corp.intel.com (10.18.126.91) by fmsmsx903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Thu, 8 Jan 2026 10:46:34 -0800 Received: from fmsedg903.ED.cps.intel.com (10.1.192.145) by FMSMSX902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29 via Frontend Transport; Thu, 8 Jan 2026 10:46:34 -0800 Received: from BL2PR02CU003.outbound.protection.outlook.com (52.101.52.27) by edgegateway.intel.com (192.55.55.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Thu, 8 Jan 2026 10:46:34 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vyTg558W8HphZAXKwuzMFBIYs3lfylr+u5b5Sz5d7BWz5j5WzPrAn7lM70uDL9JH8wK+9hw9AUyLQeRHinTNzWVTdpjBbMJELWtgpauIZukup1BjxxR7deg0HdddpGpUg86BLolEnpuZYU6mwKi9xu2ewq04egzcIGzlhtf5S3Z3DQ64QV/0JTo7UU6Ukb0iG0N6tP3M5Qu+9ai0rSEfmWiH6l2rHQGu2d27D2EM4ZvXLhj5UXqBn8L8adXNUE31V4CUHooFHVqBANWZou56pCTQHPeToyn+nzmtHqIaqs2Qqyeefy1MTsT8vLRNZuRJLHxvF1/fJN6zbV9PNfGAXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LXyuzzHGCaHtWnZ89cZz+5hBJCNM0PmAb5233SHvfAk=; b=rfppKk3LNww4AWPPdCx55HNZU4rJJ12uSsQo1z+pES7uASW5mA1PnyMKYulNYLyfqxPAI8Q6BNl8ro/GOmTdbaoAtvDzqJ9dMchGH6DIUPaQ1YUmIFH0xSx06fFnU9CvhVl63haRQDCI60CfNhA2JLhBlGiAr0t72JgedzogcL/xnpFu+ztWeOs8NJ5xnmMR1oO+dd4DK1xbjth/0LBMU3FvDBVe3uWQEB7sVI+4fMK8ua6SAcJmoxBI/jhNk9j3MiBzdi4A+zzL3kjmWImo7I+D5AvS953uyPz+XylEukGv4UvJ3T6/L7Zu2bJK9TkAcjVd/yUil6j2h6+A3kUsnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ2PR11MB7573.namprd11.prod.outlook.com (2603:10b6:a03:4d2::10) by MN0PR11MB6036.namprd11.prod.outlook.com (2603:10b6:208:377::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9499.2; Thu, 8 Jan 2026 18:46:31 +0000 Received: from SJ2PR11MB7573.namprd11.prod.outlook.com ([fe80::61a:aa57:1d81:a9cf]) by SJ2PR11MB7573.namprd11.prod.outlook.com ([fe80::61a:aa57:1d81:a9cf%3]) with mapi id 15.20.9499.002; Thu, 8 Jan 2026 18:46:30 +0000 Message-ID: Date: Thu, 8 Jan 2026 10:45:11 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [v3 PATCH 1/1] x86/resctrl: Add "*" shorthand to set io_alloc CBM for all domains To: Aaron Tomlin , , , , , , , , CC: , References: <20251231023549.2390630-1-atomlin@atomlin.com> <20251231023549.2390630-2-atomlin@atomlin.com> Content-Language: en-US From: Reinette Chatre In-Reply-To: <20251231023549.2390630-2-atomlin@atomlin.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW3PR06CA0023.namprd06.prod.outlook.com (2603:10b6:303:2a::28) To SJ2PR11MB7573.namprd11.prod.outlook.com (2603:10b6:a03:4d2::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR11MB7573:EE_|MN0PR11MB6036:EE_ X-MS-Office365-Filtering-Correlation-Id: e0dc6e83-b5e6-4998-5bff-08de4ee63cf0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Q0VGVHB1M0NPMDJZcmYvRzVRM1BXTUp1dlkxNFA1bFJHS1dTVlZqTmtMc3or?= =?utf-8?B?cEJIWTM3S2hmSG9WQkZRaldDRC9tU0hEZGEyYTM4eU0wcmNPdzRpcDlRdGdv?= =?utf-8?B?dVJQWmR6cDk5UGp2YkZjcTB6TDFhZmdxblBnWkIySTh1Z1QvellMNFpZNWVJ?= =?utf-8?B?V2xTc1FLRlhkQVlXTzc5a0FqNkhMRWsrM0Uvc054S3JBMkVwRXhOQTNwYXQv?= =?utf-8?B?aEo3QVVocjNLVzZxQkorclpTUTdZTkVpcDhPc01JcmFtVnJaMy9TYU5WOTBF?= =?utf-8?B?TkdIRm9xY2lPK2FIbkV0K0NoVjViMFJNRVJ5UjcwcXZMQ0xZZTJoRDNoaXR5?= =?utf-8?B?a3FyaGdhVXNsR0NlMEtNOTk3MDZOeTZ1ZVNzdGdLazRvd242N2hOeXgyZ1Vn?= =?utf-8?B?WjZsUEk5WHdDL3R2b1VNVTlNaStkdit6SjlsV2VHeGxyZ2Z0N0g5Y3o1MzBp?= =?utf-8?B?ay9YRzY0VFIrWUtvMUtyUWFCSmJuUXFCNVpmeGxzeUxlSGc2UjMwV1c4ZW52?= =?utf-8?B?eWJibk5uZzRaSWcyNmJFY0w2MWp6ZHVWbWRQbHREMGFZRE0xNUFOblFRRGNY?= =?utf-8?B?Y3hCQUswOFdBa3JHc1lOVUg4UjN0cFVXZHhxYjBDZlc5dHgwc2ZUSk1ST01J?= =?utf-8?B?SWRTb0dWQklodDJ2THZrcXZHOVR6MGtLYy9obytMUkVaZEF6LzFha0NSMVZi?= =?utf-8?B?am9kSVVMOTJLcjdPeStXMWtSVDc0bEZJTVRZTXpQTzFWdERKYzBMV0hLSVNh?= =?utf-8?B?YmFUemUxcElWcGRta0pqSVQ4cy92SmpKd1JpcnZkKzRDSDR6OVArMzJOdEd2?= =?utf-8?B?clFsdFJWdE11VEwxVXJ4a1Bhb2tHWi9HeUZuZ2JuZ295OVRHTGh6ZUVFQWRK?= =?utf-8?B?MG1wbTZObGt1YmZ4UVVXRWdrQlBXMWlUMXdOaElDVVdYd1Rkd21PNFkzbW5O?= =?utf-8?B?UngzVkpWeXhaTWlNRFp3UzRaUXpScHpnOFZKVzJpWG9SaldFK2JUeDBaOXY3?= =?utf-8?B?eC9oTlhiV0EzREtQM01PazJUVlhUNUhweWt6RGUvdUZkRUl0RVIydXM3UGZJ?= =?utf-8?B?aGpKNlRMVHZ0Z1lROEFXRzFtdGhjMFhHWFpkUjdzVlVHTU9VblZpRTdoUlo5?= =?utf-8?B?ckFqaFpxOGcwc1ZBRzJETGRwMkZ1TkVlMndkNk1QT3dxL0RYT1VwSUVDK0Ju?= =?utf-8?B?NjJMSC85OFE3YThQaDU1SFBvN0Z0NmExeTAzTjZvQUxyWGNWVGdEdGNxRWtv?= =?utf-8?B?V1RBUDJaRElxOU9aaGJlTmUvQnhQTE9tS09neFJKckkxNGJLM0hpT3k1MGxD?= =?utf-8?B?K3JEaVZMelE1QnhaR1M1R3ZBMHpVb3d0TC9zS2x6VGltbTdBeHRtM05wc0I0?= =?utf-8?B?TzBHZ3BmTDZ4eFFheUVPRCt3a1M5eUhJT1ErbnFjNWVUMVZ1bFVOd0xJTkFQ?= =?utf-8?B?MDRoVDV0bDdralF0OGQ3bzNid3VJRUxiT250NkZXRnhud295K0g4cHdNUVJt?= =?utf-8?B?SHd1Yy9EcnY3cUlMVkxBOVpKblc3RWVONHRPVHZLcHNPQVBPMXl3U09rQm1H?= =?utf-8?B?YkFoZ2hMZG1NSU8vMkVDNTdmUVd3aTc5eHRsQVczeUxnU25FNFZYK2NkUjNz?= =?utf-8?B?dTF5bXgzTTlHcStsZFhKZlJEOS9URG5jdFFIcjRsL0NwMUIwMjZOcForTUp6?= =?utf-8?B?STNUNXNvdExPc0tNelNpTEJ3Znl4aHdqeElTUXBNZ0REN005L3RZVDVqelg3?= =?utf-8?B?YnJZRERMS0krOWIwVkQ3WXBQaHlEUndRb1VlZEVFUGN2V25Jakd4ZE1BRXBO?= =?utf-8?B?OCtldlZEcS9lelNBVXV4QktIc3BtMklGdmJGUHg2bXNOZGJudFdsQTJwelFB?= =?utf-8?B?dTMzZzRGcWcrbDlVWVlSYk84MTBlRWR2Q1hKR3FyclY1MkVCcy9VTHR2U1lI?= =?utf-8?Q?XjyAkF8ysWbjz5K5iakcQoFCM6Oi/Zq1?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR11MB7573.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWpvamxXejUwK3I4eGQwaCtjc2hSQWZ0eWtXQWJKNTZuQUVHT2ZJcnJ1dHhw?= =?utf-8?B?WWM0YlEyUDJ5MERwcnh6dXFEMzRtNlE4RTZacUMwdFB3TEIxYVRWT04yRWlK?= =?utf-8?B?QlBwR1c2RllSRElSOHg3MUJqdVNLMExDMmV4WThFRjIwRWxwVkFUZGlnblBY?= =?utf-8?B?eTB0aHBWMzFCdWd5VFVpWmRpUzV2MFhYMDRqaStZQ1dDcE5GTEtqM2xOMTRH?= =?utf-8?B?bzBKaUdBdkhNYmtIRGxoTFlWdkNlYk1uckdCcFUrMTBTZ1hkVStIM3RFS1h2?= =?utf-8?B?bFdUWWgyV0lKTFB3emJMZmRSY0c4bnliekJJa0psUXQ0S1h3bEgyVmZicEZD?= =?utf-8?B?S2tYOUd5L2JkcnFqSm54Y0RHQ3JtRmFib2VMU2hEMnhKeERza2ozZkdaOW9W?= =?utf-8?B?azhaRnlUeDlxMGJLVkxnM2RFRUs5RmowVVRoZzNrOFdoREdSb0NZTjVRcnY2?= =?utf-8?B?N3ZiVU4xNHhpb2RYdzJ1U3Q2UDJrbkFqeDFPM0JjL0xUSGNzRHA1R2xDamVn?= =?utf-8?B?c1BTbERvcDZ2ZHB0UHlNbU1WMEpKMkIrbEFtL2VpRGU4cUt4L1hZRU9NNGpr?= =?utf-8?B?UnVzbEVOZFo1TVFRZ0N3SVBpL1NLZDloRnNqS0V1YUFadmZMZ2NiT0VxTG1v?= =?utf-8?B?T2lKU29hRkFDUndJa2xPWk5RVkV5RFdESDlZWFpZV0pCWWJiM3FqcXNKaWZu?= =?utf-8?B?Qkt0U3owc1BlOHdVSkh6c1pQOEZ2Z3VVT05odTVpVUZoZXByVDFYOEI3YlB2?= =?utf-8?B?YWNLK0ovVGRBM0JoOVhzSmVHODNSQmJBNkkxYmdpbFJ4SWVtR3NYVWl4YytT?= =?utf-8?B?NGIxd1F0QUdKTGNzZkI5eHRRdEhveUJrNGFXbDF3RUtLQzY4Q0dJTjhRUUdR?= =?utf-8?B?TWkvWFY5R0E0eFVxOEF6WUszY3JZaEZEU2Q5K05DVUtwN0dmWDJQMGV2WUlt?= =?utf-8?B?RmFrYisrNm5XS2Yra0NXQmxBZ0o5VjNNaldEekw3OHJiMS9qZzVvOGxQN0sw?= =?utf-8?B?TzZWSnhtQkRaN0oxOUxtaTJ6QkhLazdhS3Z0akZhWkhFdHAxZkpHQ2VIZ21r?= =?utf-8?B?MlRJV2xHN1RBUUtQTVRJQVIzZDVYK296TDJzeWY4emUwNXo5YVNTUy9wZTdL?= =?utf-8?B?SHlYNE0zcHI2Y1ZqZ3FpeUY4cWhIVkp6dURqZlQ3bTZpYnlLamxCZmd1d0h2?= =?utf-8?B?ZFlsZDhDVkJEUzk5QlNmVTZWaTQyUjJHZ1hKWW5PSmJjajBkcFZjalVkbWpu?= =?utf-8?B?cVlJREhvMkhIZ3A0Ui9Wa3d6UTBBckhjaW9RN0M0Zkw3MXBTdE1nbnNOdGFY?= =?utf-8?B?U1ZlMjVmTTJhTHhIak1PM2ZkdGdMMzhONGdNVE9zcDdnZk5iT3llNC9MTjEr?= =?utf-8?B?WWxYUTFZQmdTZHRqTGdpc2pEY2Y0SXcxVGtmMnUrbG5nQVhXejFuT0UwUmtk?= =?utf-8?B?V0pjditIUmlyMVA2WlZqNU1xT29rdCs5UndVY0kvck5ubkMvZ25IVEw0SzM4?= =?utf-8?B?VnJ5TzIyUmYzUG1HZVB4NWhvYi90d1B4UWtGKzhhRlI3VXJwbVFrVTdWelhm?= =?utf-8?B?bnh3UVdySFh3a2pOTitTRUxNRTUzMkpxUXB6YnlWWkN4dzVCMXV1MERTYnQv?= =?utf-8?B?em9walUrdk5XaHhrVzkzTm9lUThQWDRJZk1tUGtqbXVvazY1eW5zNHJTdUpx?= =?utf-8?B?aGU5a3g4QTVZS09LN2F1NStsV284ai9EVmhSaUsyT0xqMzRTVGVNbUNIRE1T?= =?utf-8?B?cnRpZXdwL3doZUZMRll3cFhyS1BBREh5N1hqSkN5a1FwcU9uMkJDRjNNMGwy?= =?utf-8?B?aHZQRHBhVkNYQzdxVlRVcTVTWjY3M1JENzhYN2dueXdjcjdUN1F4eEdiYml0?= =?utf-8?B?cU5lYXM2ZENPRUVBZ283MnF2L1RrQWZXVWFDcThaejJMR3Y1T2xRYmlDWlNG?= =?utf-8?B?QUh5YWpkQktZazdtMDlSSUJmL09XZndJRnB3MHpDQXFFZDJqWWsxUG1Cejd0?= =?utf-8?B?M01ZS09JNjU5eGdBQXZEbXNBdEp4NkVBNm93enFIeG9qSXZxZzFJUVBEaEdL?= =?utf-8?B?b2UvT2NsZ0ZhSm9KRm00MFFXaHE1eHNCeUVKaU5ZRUgraFlOcC9Gb3B3S09Z?= =?utf-8?B?SWVBNkhTZmxKWkRld0lRYU5KSGVzTXBxUFZqbFB3eTRRQXdTSlJUSFN5TWxT?= =?utf-8?B?M3FaWDZiNW45bVdDWkZBUVRUQ2FqbHowWXRUcXBQMEg4dk1zWVFWekdqUzlC?= =?utf-8?B?MStYTlZFOWJYK3FrWTN6SS91QlJmdEkydytwQVJ2aURLc1pnaFdaUFM3S2V4?= =?utf-8?B?NHF5N0lIQUpQRElQVlJwNlovVG9CaVdqaFNXZDlnblB1ZjBYNVZuNktqbEs1?= =?utf-8?Q?f6ePt/151SXviiKk=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: e0dc6e83-b5e6-4998-5bff-08de4ee63cf0 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2026 18:46:30.6800 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T5W3AM1LUoUFKlFuZ7Bn0BvoshXj3GhePHkbcbpBYATqlNoxmYu93Mp2uYTFgrFZFmQnLo4Z9WhGtn0Jzy4zLrmWGP+wLWBlLyvA/TLhhj4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6036 X-OriginatorOrg: intel.com Hi Aaron, On 12/30/25 6:35 PM, Aaron Tomlin wrote: > Introduce a wildcard domain ID selector "*" for the io_alloc_cbm > interface. This allows a user to update the Capacity Bitmask (CBM) > across all cache domains in a single operation. > > Currently, configuring io_alloc_cbm requires an explicit ID for each > domain, which is cumbersome on systems with high core counts and > numerous cache clusters. Supporting a wildcard selector simplifies > automation and management tasks. > > For example, a user can now write "*=0" to the io_alloc_cbm file to > program every domain to the hardware-defined minimum CBM. Note that the > value provided must still adhere to the constraints defined in the > resource's min_cbm_bits. > > Signed-off-by: Aaron Tomlin > --- > Documentation/filesystems/resctrl.rst | 8 ++++ > fs/resctrl/ctrlmondata.c | 60 ++++++++++++++------------- > 2 files changed, 40 insertions(+), 28 deletions(-) > > diff --git a/Documentation/filesystems/resctrl.rst b/Documentation/filesystems/resctrl.rst > index 8c8ce678148a..e4d92c865e44 100644 > --- a/Documentation/filesystems/resctrl.rst > +++ b/Documentation/filesystems/resctrl.rst > @@ -215,6 +215,14 @@ related to allocation: > # cat /sys/fs/resctrl/info/L3/io_alloc_cbm > 0=00ff;1=000f > > + Set each CBM to a specified value. > + > + A special value "*" is required to represent all cache IDs. nit: the value is not "required". Compare with, for example, "An ID of '*' configures all domains with provided CBM" > + > + Example:: > + > + # echo "*=0" > /sys/fs/resctrl/info/L3/io_alloc_cbm > + > When CDP is enabled "io_alloc_cbm" associated with the CDP_DATA and CDP_CODE > resources may reflect the same values. For example, values read from and > written to /sys/fs/resctrl/info/L3DATA/io_alloc_cbm may be reflected by > diff --git a/fs/resctrl/ctrlmondata.c b/fs/resctrl/ctrlmondata.c > index b2d178d3556e..7b3119f91b9d 100644 > --- a/fs/resctrl/ctrlmondata.c > +++ b/fs/resctrl/ctrlmondata.c > @@ -873,41 +873,45 @@ static int resctrl_io_alloc_parse_line(char *line, struct rdt_resource *r, > struct rdt_ctrl_domain *d; > char *dom = NULL, *id; > unsigned long dom_id; > + bool update_all; > > -next: > - if (!line || line[0] == '\0') > - return 0; > + while (line && line[0] != '\0') { Why is it necessary to change to a while loop? From what I can tell this is not required to support this particular feature and thus makes this patch consist of two logical changes instead of one (see "Separate your changes" in Documentation/process/submitting-patches.rst). Since the focus of this patch is to support "*" the switch to a while loop distracts from the core change due to generating so many line changes. I have two concerns with a switch to a while loop: The switch to the while loop has a subtle but significant consequence that changes the behavior of this flow to return "success" when the user provides an invalid domain ID. The caller, resctrl_io_alloc_cbm_write(), expects "success" to mean that the configuration has been staged and can be configured on hardware. Now it may be possible that hardware configuration attempted without a configuration staged? Apart from the user interface change the switch to the while loop changes the common pattern in resctrl used for parsing similar content from user space. See fs/resctrl/ctrlmondata.c:parse_line(), fs/resctrl/monitor.c:resctrl_parse_mbm_assignment(), fs/resctrl/rdtgroup.c:mon_config_write(). When working with resctrl I prefer to use common patterns. If there is an issue with a particular pattern then all instances should be changed. Please just change the code needed to support the new feature. > + update_all = false; > + dom = strsep(&line, ";"); > + id = strsep(&dom, "="); > > - dom = strsep(&line, ";"); > - id = strsep(&dom, "="); > - if (!dom || kstrtoul(id, 10, &dom_id)) { > - rdt_last_cmd_puts("Missing '=' or non-numeric domain\n"); > - return -EINVAL; > - } > + if (id && !strcmp(id, "*")) { > + update_all = true; Have you tried this feature with some edge cases? When considering, for example, a user just providing "*" then from this point on "dom" is assumed to point to a valid CBM but is actually NULL. Since this parses user input it is required to be robust against any input. Reinette