From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D11513B58C for ; Tue, 5 May 2026 07:18:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777965504; cv=none; b=i7DCRmmpXXYqFCKQPDStw33AlXWOnIyWdcZLLAmJUQ0FcIG418bcJtNEBoWyR4zR5wSmoGsz1qyZWhsKb2zd7/jHOlxhFbXwMuwW77nTVbaeOczV2ay+mWrN/UbpSTqszoEMYVNdMM2A6D2sLME9sikRZgrFaXIqlDWZw0YAgoA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777965504; c=relaxed/simple; bh=ltn9RQ2TtDo/j1rZFblN44gApen+CnmKKPI54V54DWY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=A3T/KNZoNQz5HRqmQA5qTiFwOWiPWvIWsA4I0pODXhL06BjirfcXjjzPYsUsASJtZOmGtAVcZy0vJd2L+iUXbcDeSDi0DpENO7F1LttNGaASrGYbqGEvIxQuAqwBvgs96RooIP1GvOrpTgaoibe1i9QNzeNIT/uZQxHxanesc3Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Tmf7EFp+; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=YXmiZ+a9; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Tmf7EFp+"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="YXmiZ+a9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777965499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U8Okzffkmp0X0il5ChdwD7WwCI7y675UlHMmtZ9sMKU=; b=Tmf7EFp+eRyh+tKEllHkWX2TOT14mimKwIQeMg380iiyyKdKW2L58yXfo00xO+skPuNJA5 bLVfKqtIoZ4YVBGqeTF8051UmuJ2ydPeM9ptKOvCOU+uvbv8WbzWxeJbyUrSx9Sq/PDz95 En8sS7n8OLlRB0LS+2npAkCmopPo5Go= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-164-78qobJbWOQSnK7-qpT0Xng-1; Tue, 05 May 2026 03:18:17 -0400 X-MC-Unique: 78qobJbWOQSnK7-qpT0Xng-1 X-Mimecast-MFC-AGG-ID: 78qobJbWOQSnK7-qpT0Xng_1777965496 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-5a407fad7e0so2420408e87.0 for ; Tue, 05 May 2026 00:18:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1777965496; x=1778570296; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=U8Okzffkmp0X0il5ChdwD7WwCI7y675UlHMmtZ9sMKU=; b=YXmiZ+a9CZNI/TZYQIVR+tDzrCSUONvplqSgI3hHxidBWhvdnW6iT4EKuXr4mXwkUk GZRoBjUBsje98u7K9hyUPtACG7cCTb9WHUEbQMKjQpd9Eh7cXdqeK3CtytQib6cwz7f8 YYvzAGD5tTvLa3ppeVQSF1IOZP0D4GjUs2KG0HjxPCJN7k/+vFmZfvKcOpP9xtxU7/Z+ rJlFv/HHCYaegVG1cvca8e5E/DbxrjyllnM1jQ3pDFZ/qsiOaSmTDCkoIHjes4KpA3Hu 3WB0FMOQq+wU4YtYeMHKcb/9KJ8SKmvQ0INKf4iwlMCPH+/3Fw2nRlxqubbwn2fl3ZkS nAgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777965496; x=1778570296; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=U8Okzffkmp0X0il5ChdwD7WwCI7y675UlHMmtZ9sMKU=; b=kSfUtnOGZ7L6AxZ6q8FpUu/TO6mGvXLF7Ox6/lRdchB601z9zxFqXzSYgh2D7UOEG8 64KJVHtzIzj7REvvSfVgTH53Mz3jp8a3ZJAyaedExBe6bUYUSQaRpk9ZXmcCurWpUlrs 281C5Z4+w7dgRDsc3+CF43mPvusu4d7HgXLO1QZ9vaSVzrg5QE2wo6vzn7pT9SsOh0Nu wSfwiH5X8/Y1+Og6Jp1M7UfAWfcmPalFe5gDGCHR4PZVDU/V0KmdYwdLCxS4QVVm0kOh dS0uBVhA7LwwbcuJJc1Fs/NtfYD/LRPAQm/1KZQCaIBricflCvvYqvuFQ5U0Ma1WnJgx 1SMg== X-Forwarded-Encrypted: i=1; AFNElJ+W5DCcOykMXwUCOuLM8djC9LVah8oHs9X6xNutwwE4sOAx8k2AjE8AfNrhrNKEwInOicnBoBRdISuEe3M=@vger.kernel.org X-Gm-Message-State: AOJu0YxJhsiJauIRBsMV177ZF6ehR1CrexqWqjlRcHd6AAVhBNMzQWKo Wm3jeCbyahTCT7mt7T7qIU+/zsPu5N41QYSN1TvuJZxc4sncEVoMSw2OnEhI1JWiIu1rDGMUSgV Nwb1rJbOdZKPQiR7JG2yCxQ80IBtC4V/bPH4n4LCOowVru+4zKa3cHBqrV36fLXuE X-Gm-Gg: AeBDieteNRRFPywMnIAUubxWYUpiIC9qCyW55YPStAGuvebglwJu0AqM+Zuy2FhwO7g fC0vtv0LOoOnSVmEdD8NFVQLrTqVaJTCmvKCBHez/gDDu6YAKsjDE3P9aUJn4p38NZoPHWfXQaD 9AW/jSujfAdacHP1yRcQmGRu7RqYt7cGBzfcB3XsSxYazPaxrXTX2fbZ3ogZtT8MQLG+fwnOyIQ HB4IWLGEA4m4lPbHPYtOoO3SKKuwV5/jJcxzjugsgS86TLTvEBVa5aOH9CIyf2chBtH6yfh2Ps5 HrMb+xf/z9QkhNiGAtDIdpBo3NkRYj2trW+bMYVMwGa8wy01SrgYw/8pKuVAjRluJo6ESBDA0gJ blVQkb90mUH6TBplT8NWRYiOAgqnSAcjD4c4Pcp/Q+JSpoZ98vrojkmrmLQ== X-Received: by 2002:a05:6512:2527:b0:5a8:64cd:4d7d with SMTP id 2adb3069b0e04-5a864cd4d86mr4224302e87.37.1777965496055; Tue, 05 May 2026 00:18:16 -0700 (PDT) X-Received: by 2002:a05:6512:2527:b0:5a8:64cd:4d7d with SMTP id 2adb3069b0e04-5a864cd4d86mr4224268e87.37.1777965495404; Tue, 05 May 2026 00:18:15 -0700 (PDT) Received: from [192.168.1.86] (85-23-51-1.bb.dnainternet.fi. [85.23.51.1]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a87791b4a2sm1029451e87.1.2026.05.05.00.18.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 May 2026 00:18:14 -0700 (PDT) Message-ID: Date: Tue, 5 May 2026 10:18:14 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 0/5] Migrate on fault for device pages To: Alistair Popple Cc: linux-mm@kvack.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-kernel@vger.kernel.org, David Hildenbrand , Jason Gunthorpe , Leon Romanovsky , Balbir Singh , Zi Yan , Matthew Brost , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko References: <20260505051658.2219537-1-mpenttil@redhat.com> Content-Language: en-US From: =?UTF-8?Q?Mika_Penttil=C3=A4?= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 5/5/26 10:09, Alistair Popple wrote: > Thanks for doing this work Mika. I've been meaning to take a look at this series > for a while. I'm currently at LSFMM but will try and take a look this week or > next as it sounds quite useful. > > - Alistair Thanks Alistair and no problem, appreciate your insights whenever you have time. --Mika > > On 2026-05-05 at 15:16 +1000, mpenttil@redhat.com wrote... >> From: Mika Penttilä >> >> Currently, the way device page faulting and migration works >> is not optimal, if you want to do both fault handling and >> migration at once. >> >> Being able to migrate not present pages (or pages mapped with incorrect >> permissions, eg. COW) to the GPU requires doing either of the >> following sequences: >> >> 1. hmm_range_fault() - fault in non-present pages with correct permissions, etc. >> 2. migrate_vma_*() - migrate the pages >> >> Or: >> >> 1. migrate_vma_*() - migrate present pages >> 2. If non-present pages detected by migrate_vma_*(): >> a) call hmm_range_fault() to fault pages in >> b) call migrate_vma_*() again to migrate now present pages >> >> The problem with the first sequence is that you always have to do two >> page walks even when most of the time the pages are present or zero page >> mappings so the common case takes a performance hit. >> >> The second sequence is better for the common case, but far worse if >> pages aren't present because now you have to walk the page tables three >> times (once to find the page is not present, once so hmm_range_fault() >> can find a non-present page to fault in and once again to setup the >> migration). It is also tricky to code correctly. One page table walk >> could costs over 1000 cpu cycles on X86-64, which is a significant hit. >> >> We should be able to walk the page table once, faulting >> pages in as required and replacing them with migration entries if >> requested. >> >> Add a new flag to HMM APIs, HMM_PFN_REQ_MIGRATE, >> which tells to prepare for migration also during fault handling. >> Also, for the migrate_vma_setup() call paths, a flag, MIGRATE_VMA_FAULT, >> is added to tell to add fault handling to migrate. >> >> One extra benefit of migrating with hmm_range_fault() path >> is the migrate_vma.vma gets populated, so no need to >> retrieve that separataly. >> >> Tested in X86-64 VM with HMM test device, passing the selftests. >> For performance, the migrate throughput tests from the selftests >> show similar numbers (within error margin) as unmodified kernel. >> Tested also rebased on the >> "Remove device private pages from physical address space" series: >> https://lore.kernel.org/linux-mm/20260130111050.53670-1-jniethe@nvidia.com/ >> plus a small patch to adjust with no problems. >> >> Changes v8-v9 >> - rebase on drm-tip >> - fixed uaf around migrate_vma_split_folio() usage >> - added missing pmd unlock >> >> Changes v7-v8 >> - rebase on 7.0 >> - fixed subject in two patches >> - enhanced commit messages >> - squashed patch 6 into patch 4 to fix kernel test robot warning >> - readded dropped Cc block from cover letter >> - fixed white space >> >> Changes v6-v7 >> - rebase on 7.0.0-rc6 >> - added documentation and comments >> - denote to be migrated zero page as HMM_PFN_MIGRATE alone >> - got rid of HMM_PFN_INOUT_FLAGS movement in patch 2 >> - picked up Acked-By from David for patch 1 >> >> Changes v5-v6 >> - rebase on 7.0.0-rc4 >> - use range based TLB flushing while unmapping ptes >> - gate migration behind HMM_PFN_REQ_MIGRATE for fault and >> migrate paths >> - always infer migration flags from migrate->flags only >> >> Changes v4-v5 >> - rebase on 6.19 >> - fixed David's email address >> - fixed link issue without CONFIG_TRANSPARENT_HUGEPAGE >> - refactored into smaller commits >> - added more comments to code >> >> Changes v3-v4: >> - rebase on 6.19-rc8 >> - fixed issues found by kernel test robot with random configs >> - fixed typos >> >> Changes v2-v3: >> - rebase on 6.19-rc7 >> - fixed issues found by kernel test robot >> - fixed smatch issues reported by Dan Carpenter >> - fixes to lock handling (pmd/pte) on errors >> - added assertions for pmd/pte lock states >> - other issues discovered by Matthew, thanks! >> >> Changes v1-v2: >> - rebase on 6.19-rc6 >> - fixed issues found by kernel test robot >> - fixed locking (pmd/ptl) to cover handle_ and prepare_ regions >> parts if migrating >> - other issues discovered by Matthew, thanks! >> >> Changes RFC-v1: >> - rebase on 6.19-rc5 >> - adjust for the device THP >> - changes from feedback >> >> Revisions: >> - RFC https://lore.kernel.org/linux-mm/20250814072045.3637192-1-mpenttil@redhat.com/ >> - v1: https://lore.kernel.org/all/20260114091923.3950465-1-mpenttil@redhat.com/ >> - v2: https://lore.kernel.org/all/20260119112502.645059-1-mpenttil@redhat.com/ >> - v3: https://lore.kernel.org/all/20260126111939.1332983-2-mpenttil@redhat.com/ >> - v4: https://lore.kernel.org/all/20260202112622.2104213-1-mpenttil@redhat.com/ >> - v5: https://lore.kernel.org/linux-mm/20260211081301.2940672-1-mpenttil@redhat.com/ >> - v6: https://lore.kernel.org/linux-mm/20260316062407.3354636-1-mpenttil@redhat.com/ >> - v7: https://lore.kernel.org/linux-mm/20260330115611.347988-1-mpenttil@redhat.com/ >> - v8: https://lore.kernel.org/linux-mm/20260414041226.1539439-1-mpenttil@redhat.com/ >> >> Cc: David Hildenbrand >> Cc: Jason Gunthorpe >> Cc: Leon Romanovsky >> Cc: Alistair Popple >> Cc: Balbir Singh >> Cc: Zi Yan >> Cc: Matthew Brost >> Cc: Andrew Morton >> Cc: Lorenzo Stoakes >> Cc: "Liam R. Howlett" >> Cc: Vlastimil Babka >> Cc: Mike Rapoport >> Cc: Suren Baghdasaryan >> Cc: Michal Hocko >> >> Mika Penttilä (5): >> mm/Kconfig: changes for migrate on fault for device pages >> mm: Add helper to convert HMM pfn to migrate pfn >> mm/hmm: do the plumbing for HMM to participate in migration >> mm: setup device page migration in HMM pagewalk >> lib/test_hmm:: add a new testcase for the migrate on fault >> >> include/linux/hmm.h | 19 +- >> include/linux/migrate.h | 26 +- >> lib/test_hmm.c | 101 ++- >> lib/test_hmm_uapi.h | 19 +- >> mm/Kconfig | 2 + >> mm/hmm.c | 835 +++++++++++++++++++++++-- >> mm/migrate_device.c | 583 +++-------------- >> tools/testing/selftests/mm/hmm-tests.c | 54 ++ >> 8 files changed, 1066 insertions(+), 573 deletions(-) >> >> drm-tip >> base-commit: 94d56a898a2db27f841b17f6966a81ba502fe63c >> -- >> 2.50.0 >>