From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>,
Brent Lu <brent.lu@intel.com>,
alsa-devel@alsa-project.org,
Bard liao <yung-chuan.liao@linux.intel.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Jie Yang <yang.jie@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
Yong Zhi <yong.zhi@intel.com>,
Vamshi Krishna Gopal <vamshi.krishna.gopal@intel.com>,
linux-kernel@vger.kernel.org, Rander Wang <rander.wang@intel.com>,
Bard Liao <bard.liao@intel.com>,
Malik_Hsu <malik_hsu@wistron.corp-partner.google.com>,
Libin Yang <libin.yang@intel.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Paul Olaru <paul.olaru@oss.nxp.com>,
Curtis Malainey <cujomalainey@chromium.org>,
Mac Chiang <mac.chiang@intel.com>,
Gongjun Song <gongjun.song@intel.com>
Subject: Re: [PATCH 3/3] ASoC: Intel: sof_rt5682: use id_alt to enumerate rt5682s
Date: Wed, 6 Oct 2021 12:24:33 -0500 [thread overview]
Message-ID: <ecde4150-2782-9529-3288-b1eb9e247883@linux.intel.com> (raw)
In-Reply-To: <fdcdf447-352f-3dbc-f55d-b3bb3588dca3@redhat.com>
>> @@ -196,6 +201,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_baytrail_machines[] = {
>> },
>> {
>> .id = "10EC5682",
>> + .id_alt = &rt5682s_hp,
>> .drv_name = "sof_rt5682",
>> .sof_fw_filename = "sof-byt.ri",
>> .sof_tplg_filename = "sof-byt-rt5682.tplg",
>
> So this is only useful if there actually are any BYT devices using the "RTL5682"
> ACPI HID, the 100+ BYT/CHT DSDTs which I've gather over time say there aren't any.
>
> Actually there also aren't any using the non alt "10EC5682" ACPI HID either...
>
> Bard Liao, you added this in commit f70abd75b7c6 ("ASoC: Intel: add sof-rt5682 machine driver")
> but I wonder how useful this is. I guess it may be available as (and tested on?) some dev-kit.
>
> But I don't think there us any hardware out there in the wild using this ?
In the past we used this configuration for SOF CI tests with the
MinnowBoard + an RT5682 eval board. We gradually fried most boards and
no longer check this capability for each SOF PR.
So I would agree we can avoid changing anything for BYT/CHT and possibly
APL, it'd be an untested configuration.
in other words, let's add this compatible/alt_id for platforms where we
know it'll be used.
next prev parent reply other threads:[~2021-10-06 17:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 16:18 [PATCH 0/3] Multiple headphone codec driver support Brent Lu
2021-10-06 16:18 ` [PATCH 1/3] ASoC: soc-acpi: add alternative id field for machine driver matching Brent Lu
2021-10-06 16:44 ` Andy Shevchenko
2021-10-06 16:50 ` Pierre-Louis Bossart
2021-10-06 16:18 ` [PATCH 2/3] ASoC: Intel: sof_rt5682: detect codec variant in probe function Brent Lu
2021-10-06 16:18 ` [PATCH 3/3] ASoC: Intel: sof_rt5682: use id_alt to enumerate rt5682s Brent Lu
2021-10-06 16:46 ` Andy Shevchenko
2021-10-06 17:18 ` Hans de Goede
2021-10-06 17:24 ` Pierre-Louis Bossart [this message]
2021-10-07 2:46 ` Liao, Bard
2021-10-07 13:49 ` Lu, Brent
2021-10-06 18:34 ` Curtis Malainey
2021-10-06 18:43 ` Pierre-Louis Bossart
2021-10-06 19:21 ` Curtis Malainey
2021-10-06 19:58 ` Pierre-Louis Bossart
2021-10-06 20:07 ` Curtis Malainey
2021-10-06 16:50 ` [PATCH 0/3] Multiple headphone codec driver support Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecde4150-2782-9529-3288-b1eb9e247883@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=brent.lu@intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=cujomalainey@chromium.org \
--cc=gongjun.song@intel.com \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=libin.yang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mac.chiang@intel.com \
--cc=malik_hsu@wistron.corp-partner.google.com \
--cc=paul.olaru@oss.nxp.com \
--cc=perex@perex.cz \
--cc=rander.wang@intel.com \
--cc=tiwai@suse.com \
--cc=vamshi.krishna.gopal@intel.com \
--cc=yang.jie@linux.intel.com \
--cc=yong.zhi@intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox