From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F9633F1AB8 for ; Fri, 10 Jul 2026 13:42:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783690954; cv=none; b=obCcoDUWzqRj6+nDDj/rknql78ceG93837FAhsBQ41r1o9IgAZEKy9BXDqD63FdQINsh4rLaCOUU2xNiHHNO0QdMbb47W6ODoFqUYnsSzD3yhCZMG1iydScmFd9/UrXsHLz9HBIrlvrIgiA3MKdhE84rbalsMPMTeCyFpesiUo8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783690954; c=relaxed/simple; bh=viqNB94kmYTMbwChWMqSai3g7NaUSU3hhsbnphI0AvM=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=ToKXOiSQ2tWElQficKqcVUEJACUVPH2FPC1fsl2kvIOIDhyWtAPLZkkKk2mwYpsDKpAOjm5Bov3VoMQYlEROC0CEtqQ1OzY/kcKmt2BW0FR3Fh3DjvrKJEvs/RdrVv8e2kGE1ujcf5gFjaJESwvpTX7CtJgouqSxDtEMxmRmKGk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=I9PhVDzh; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="I9PhVDzh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC9411F00A3A; Fri, 10 Jul 2026 13:42:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783690953; bh=Gy1g/paZIE02F7m1+8gBbskshB8NzZFc5mvfCjHhyEI=; h=Date:Subject:To:References:From:In-Reply-To; b=I9PhVDzhkc3d3rud0kmEHfWSOh3PWWre3T03I9lzNPd3BzMyyhtwQTve1O6O5nI0v Ej1c22XwwLfiFfiKwyKTILn8VmAfGlIVA/oUPSdlSnQAqbenBXQp0xp5u+c8zZncru g1vjlNFizrkYJyfbyn5jiBVjwG1jENr6Oroh5NWLsZvHhi3rjr79am2t8eHXqpPnX4 ta9eKBwLoQBFJF1aDOUY8OhAuFqPUVm5EcfcInIcsj8Z+hN/RT0ohfP01q/CFr/o0J 5SxxhPQFcTL+929MAlFVYJqEpZ8i1Dy+isZtkpDwWCTUy8ZIIszObGRUa6cj1OrI49 VzPnQ2nxceiDQ== Message-ID: Date: Fri, 10 Jul 2026 08:42:31 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/3] firmware: stratix10-rsu: remove async client before freeing channel in remove() Content-Language: en-US To: tze.yee.ng@altera.com, linux-kernel@vger.kernel.org References: From: Dinh Nguyen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/10/26 01:52, tze.yee.ng@altera.com wrote: > From: Tze Yee Ng > > After stratix10_svc_add_async_client() succeeds in probe, remove() must > call stratix10_svc_remove_async_client() before > stratix10_svc_free_channel(). Otherwise async state is left allocated while > the channel is released. > > Signed-off-by: Tze Yee Ng > --- > Changes in v4: > - Rebased onto dinguyen/socfpga_svc_fixes_for_v7.2. > - Narrowed scope to stratix10_rsu_remove() only (+1 line). Probe error > paths, return 0 on success, Fixes:, and Cc: stable@ dropped; probe > teardown is covered by bfd2eb9bba54 on the new base. > - Title updated: "... in remove()" (was "... on probe errors" in v3). > > Changes in v3: > - No code changes in all patches, only put Cc: stable@vger.kernel.org # 6.19+ > in the sign-off block for the Fixes: tag in Patch 3. > > Changes in v2: > - Fix patch title. > - Move the fix description to the end of the patch. > --- > drivers/firmware/stratix10-rsu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/firmware/stratix10-rsu.c b/drivers/firmware/stratix10-rsu.c > index a36c4e3d6975..cdda0c4410f8 100644 > --- a/drivers/firmware/stratix10-rsu.c > +++ b/drivers/firmware/stratix10-rsu.c > @@ -1054,6 +1054,7 @@ static void stratix10_rsu_remove(struct platform_device *pdev) > { > struct stratix10_rsu_priv *priv = platform_get_drvdata(pdev); > > + stratix10_svc_remove_async_client(priv->chan); > stratix10_svc_free_channel(priv->chan); > } > Your original patch has a Fixes tag. Dinh