From: Robin Murphy <robin.murphy@arm.com>
To: Sergey Senozhatsky <senozhatsky@chromium.org>,
Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Rob Clark <robdclark@chromium.org>,
Petr Mladek <pmladek@suse.com>,
John Ogness <john.ogness@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] dma-debug: don't call __dma_entry_alloc_check_leak() under free_entries_lock
Date: Thu, 24 Aug 2023 15:13:25 +0100 [thread overview]
Message-ID: <ecf738a3-e8e5-85ac-c435-d4aa0e320b17@arm.com> (raw)
In-Reply-To: <20230824031542.GB610023@google.com>
On 24/08/2023 4:15 am, Sergey Senozhatsky wrote:
> On (23/08/16 11:32), Sergey Senozhatsky wrote:
>> __dma_entry_alloc_check_leak() calls into printk -> serial console
>> output (qcom geni) and grabs port->lock under free_entries_lock
>> spin lock, which is a reverse locking dependency chain as qcom_geni
>> IRQ handler can call into dma-debug code and grab free_entries_lock
>> under port->lock.
>>
>> Move __dma_entry_alloc_check_leak() call out of free_entries_lock
>> scope so that we don't acquire serial console's port->lock under it.
>
> Hello folks,
>
> Have you got a chance to take a look at the patch?
[ For some reason Microsoft seem convinced all your emails are spam, so
I have to keep digging them out of quarantine :( ]
The patch itself looks reasonable enough to me, thanks for respinning.
Acked-by: Robin Murphy <robin.murphy@arm.com>
next prev parent reply other threads:[~2023-08-24 14:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 2:32 [PATCHv2] dma-debug: don't call __dma_entry_alloc_check_leak() under free_entries_lock Sergey Senozhatsky
2023-08-24 3:15 ` Sergey Senozhatsky
2023-08-24 14:13 ` Robin Murphy [this message]
2023-08-30 9:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecf738a3-e8e5-85ac-c435-d4aa0e320b17@arm.com \
--to=robin.murphy@arm.com \
--cc=hch@lst.de \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=pmladek@suse.com \
--cc=robdclark@chromium.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox