From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C110FEE4993 for ; Tue, 22 Aug 2023 07:42:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233511AbjHVHmw (ORCPT ); Tue, 22 Aug 2023 03:42:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231375AbjHVHms (ORCPT ); Tue, 22 Aug 2023 03:42:48 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3E98198; Tue, 22 Aug 2023 00:42:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692690166; x=1724226166; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=PtfQlBNpQEHy7YglStwyz4T6JAjzzd90JE4ZiwNrUUI=; b=Dv54Nnu70iQjEoeWMY4044tPs1kZ3vXgVd8Y8GxW91lF5VA4E3BnKCNA pRpdOm0V6dZVloeLLhvg5oLIbm2DRB5q0nio/c3SAgE4djZYy9+oo3Qmj kTRFsKwLW1xBudQzMxfD5oHofXlPlQTwRNF2yTiXdryF62NRgFxRpyOeg nHTljIr+3diZSIjF6DWeLQzv9qwNHbLkklOUOH8TP/LF4ZR84cRxZ2mkx BKWS2rrBYUKAQQM/MbcjpGP0BaLG7mOJztAkpQTxN7Eg/3lb8ZWWxGHm8 GriS0I3q6YBTnnyWiyzXLEETX2QOGrMFzQBv0XRpiehkSDafT5zAYFUjr A==; X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="440176174" X-IronPort-AV: E=Sophos;i="6.01,192,1684825200"; d="scan'208";a="440176174" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2023 00:42:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="771268894" X-IronPort-AV: E=Sophos;i="6.01,192,1684825200"; d="scan'208";a="771268894" Received: from blu2-mobl.ccr.corp.intel.com (HELO [10.252.189.107]) ([10.252.189.107]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2023 00:42:41 -0700 Message-ID: Date: Tue, 22 Aug 2023 15:42:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Cc: baolu.lu@linux.intel.com, Joerg Roedel , Will Deacon , Robin Murphy , Kevin Tian , Jean-Philippe Brucker , Nicolin Chen , Yi Liu , Jacob Pan , iommu@lists.linux.dev, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 05/11] iommu: Merge iopf_device_param into iommu_fault_param Content-Language: en-US To: Jason Gunthorpe References: <20230817234047.195194-1-baolu.lu@linux.intel.com> <20230817234047.195194-6-baolu.lu@linux.intel.com> From: Baolu Lu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/8/22 1:04, Jason Gunthorpe wrote: > On Fri, Aug 18, 2023 at 07:40:41AM +0800, Lu Baolu wrote: >> @@ -472,21 +473,31 @@ struct iommu_fault_event { >> * struct iommu_fault_param - per-device IOMMU fault data >> * @handler: Callback function to handle IOMMU faults at device level >> * @data: handler private data >> - * @faults: holds the pending faults which needs response >> * @lock: protect pending faults list >> + * @dev: the device that owns this param >> + * @queue: IOPF queue >> + * @queue_list: index into queue->devices >> + * @partial: faults that are part of a Page Request Group for which the last >> + * request hasn't been submitted yet. >> + * @faults: holds the pending faults which needs response >> */ >> struct iommu_fault_param { >> iommu_dev_fault_handler_t handler; >> void *data; >> - struct list_head faults; >> - struct mutex lock; >> + struct mutex lock; >> + >> + struct device *dev; >> + struct iopf_queue *queue; >> + struct list_head queue_list; >> + >> + struct list_head partial; >> + struct list_head faults; >> }; > Don't add the horizontal spaces Fixed. Thanks! Best regards, baolu