From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EE63363C6E for ; Wed, 17 Dec 2025 13:23:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765977790; cv=none; b=PNaPg6bK8hUD88aR56KRnzju4nl5l3eXDAlFKnuRuLbUXwlSNphvcfhlEXzgOGfFM2IG52Qy8RaVRTdistW5XAXcTvZA1AR7EHWG6ae3PanD9YAt7oFAojcyzC2ccLbzLndhK5Xh6zge0XWMCc79PP5oTiD43Ai8lOtHyaRRVgs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765977790; c=relaxed/simple; bh=Zlc0vBXqq0Irlne4XboZzabyObkVAwR0n1DevPWYfaQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aegC5ZCN1+dCgld8JArzd6lg2k1u5iZcoLpa31tiwFd1P0ZWQk47q5///SVe8WWw67NwF2ONPhA5K1aOPFMpuNGo78X8d+zodVHeVtqzwKDL10sMfDUjxs58gvMSISnYhx8o9G/lp65jbSCDCZ7FfCYZix2Zt0x0cSTP1UFLdoM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Vh0VhrlR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NoTWZZBM; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Vh0VhrlR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NoTWZZBM" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BHCKp0S3048740 for ; Wed, 17 Dec 2025 13:23:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bs68MhyXjy7fggb+VYhXusf+j0KV8hvgnqpT+o0xydA=; b=Vh0VhrlRe+qfdspW Ke+P6MKuPj3SkYIbkzCss2knZCvJ57jGNEOImc+7DLIZBSqgdy6B+Mc+Y/e7KFZb DLhGjmiNDw+C8qqyuLVK2qnURttWKh09KVZ8UYJUnbkPqYpogVFNGzYZbnJMLRDc cyaynSEmqSHXVokaJM1+xzD43eYtRdRAlMK4YZwT9nSTCtdCDUrEll+kEUorsTH1 NhnzXfiPNRGo41vXulp88CmIMK6wd/ASjDkk2huGxpgn/NXXVS8OCfATGfwic4sG /7pjJUPg1vm24XLtan8VSK92c/DlxLcYHiqmuRCkgfud/IZoWQxVPILZozhugJZR hZ/74Q== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b3jgqa234-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 17 Dec 2025 13:23:04 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4ee23b6b6fdso13125051cf.0 for ; Wed, 17 Dec 2025 05:23:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765977784; x=1766582584; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bs68MhyXjy7fggb+VYhXusf+j0KV8hvgnqpT+o0xydA=; b=NoTWZZBMZv43B5wAqdgxB0Qwgz+SyYcsTnOWpP/Goo2CJHY6/5n+rsUiDh6pYJVPcG PCXKsvNTrNnP2enJSs0Xe7AowKnwsV2oqt56JLdkfE1dyYF2tW+ttjgR0cYJvH7M9/uO NyOSP/5FqXZ2nmgZk92rDlTOtIITtkd5X0nCIt7BOoiUGJ6xtHFhxv6Kkl2ImWNfrHPU 0pGWq7wEjiHCC8ns59LY+CQNbWP/xbw9cAdFhJXyjx3WnKae7Z058i60Zvje1Be3IrGx SBvD98BkxY4c/knPrf0HH0jC9MJMpowy+IFHIFaM/rBX7AiqwOShnHBZt555KuJ0g0CA g3+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765977784; x=1766582584; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bs68MhyXjy7fggb+VYhXusf+j0KV8hvgnqpT+o0xydA=; b=a1ridtfh14YLJ9jRO9xuR7gMWBh7hOj+ncQaYfHbzN9pqY/XcWSqXWYBoYHPXBcRdx nK5Vkgg6UBx+1/7wWFu30H8w/MSd++JFSdzMA9q06Atits5HspmJ181Hn7K7a9/j4k+V DYQKtkjpG9FPW3NQd5wfr7XxngWoNGPZmdUTfba5pbmb6owLEjI57Nk3J/FyYI43/K6Z GaBSfH2OycmOnZzmJZCqcdESwOfVpOM0qR9zmxggLTnEAOH1pbdVSVMqf425x7sMGZqQ 1vEgocEiUbHRhg5myRDbYaEth+8Lj6q5DZVPm1fo0q0UnyHiGaq3itLHn/zhd02tXAW2 u/SQ== X-Forwarded-Encrypted: i=1; AJvYcCUB/fyjkGC1eURLKicx3myaB9x0qH19GctrwUpS+Jw03bHREwslSHvaK37lPpPpCvwHND/oY2aDXq0buYQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzF8R6+MvFsVbDlD907UA/t4KmR6hnTeVB/f80xSPuW2qekjFgS 74iv0A0TtyR/iqItNBKHx230LUFoUYC7WSHONWs8HsuR8YD6yJ0/cDDf2VdV5QReXTXvYHyNCs6 J9UBZTOWM1ZjR0x6em/urppuWcEzkV7aqBhgQzYxWzUF9LZ+zoUE4MxwrIAhAizlpaPc= X-Gm-Gg: AY/fxX6xIbCLn5fa0T6JdIUcUTo31cqQmihv8cu7g3qGA/Is8dc5tvFd5yblPGfPe+H fC2ZOCjZUeMnGeBAqET8+3vqEAeRdqK9xouc7PESGK9rJVnl7zBp54gKPIE55QS99/jeOTQIU+1 fXWobe/GXv4kTXiZUxM+rP0hrugR9QpATehnY/cBy7cN+9zA10aJixchCa9RabUjjNQ1SzRnuhL LEsun9zU5hA2cpdojMuBw95rvgnD1CdLpb3qKvUBwOiKcT2YDqXtU9iKpjNgQOP/6bcdh/380mm w5dtOwWs71UFAKahWbJgicdoI8ypVYctKzR5EXQRAr4b8SwK4m46S86FcIu1AYLP4OmHHYxrimi DNP+sxQz76/dl18EHlkUgXi2hyFO8Hz5uPhom3I6HmwzdXC752tLOIMv0GXPwlb9uNQ== X-Received: by 2002:a05:622a:4b:b0:4ee:2638:ea2 with SMTP id d75a77b69052e-4f1d05fc5acmr193029151cf.9.1765977783900; Wed, 17 Dec 2025 05:23:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IHpn5aLn1iOCruV7FBHk9VV/Ny6pCd5cdcHqaZz8vOqqKcrW2tjqlTPVxasp9W9wjhhdHf/Rw== X-Received: by 2002:a05:622a:4b:b0:4ee:2638:ea2 with SMTP id d75a77b69052e-4f1d05fc5acmr193028721cf.9.1765977783290; Wed, 17 Dec 2025 05:23:03 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7cfa29eb76sm1969402266b.12.2025.12.17.05.23.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Dec 2025 05:23:02 -0800 (PST) Message-ID: Date: Wed, 17 Dec 2025 14:22:59 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 11/11] clk: qcom: Add support for GPUCC and GXCLK for Kaanapali To: Taniya Das , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Maxime Coquelin , Alexandre Torgue , Vladimir Zapolskiy , Konrad Dybcio Cc: Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org References: <20251125-kaanapali-mmcc-v2-v2-0-fb44e78f300b@oss.qualcomm.com> <20251125-kaanapali-mmcc-v2-v2-11-fb44e78f300b@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251125-kaanapali-mmcc-v2-v2-11-fb44e78f300b@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=VLjQXtPX c=1 sm=1 tr=0 ts=6942aeb8 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=91OgtvA7_0Jf-gwRHFQA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE3MDEwMyBTYWx0ZWRfX2Y5TcG8AmBOI G+5cRSO7M57t6TSikQrTrWf36wHY0vPVrO5kEeX8DMqGH65w3d+UDYAvA1crZVhp7AzaO1peVCa i06vqYgUrTGx6imWPZhRa0OexY+JTaeLzl+00WJuB7MsQPnTPY92Bb21f4LTNJVNpLxETrfxBO5 rHuC+lrq0F85y76+UHDrC/jledPJtF6B1NeyqdIpd2f4jcithF1tpzjgHjYJ/AkNXND3QlsS+Fd MjL6ZArXaOrJaI7RyFeOqnvpMo6FpEC+EDDpDi5NRsCsPDqobtqov1kSvxhM2OMwxjQD6ZMwCxW ourfenoVD7eUJUbj1QmtbqGEcvGqnF0NqCPxKnwzAWN+AEirnq5qoot5/1QhkUJ3m+lSkzE/lrQ SwCz/gHaGXuAWMglyeNMhFqOmZXRKw== X-Proofpoint-ORIG-GUID: V7BvvApiApyco_-qYG1-ESBD6iN7cNEi X-Proofpoint-GUID: V7BvvApiApyco_-qYG1-ESBD6iN7cNEi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-17_01,2025-12-16_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 suspectscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512170103 On 11/25/25 6:45 PM, Taniya Das wrote: > Support the graphics clock controller for Kaanapali for Graphics SW > driver to use the clocks. GXCLKCTL (Graphics GX Clock Controller) is a > block dedicated to managing clocks for the GPU subsystem on GX power > domain. The GX clock controller driver manages only the GX GDSC and the > rest of the resources of the controller are managed by the firmware. > > Signed-off-by: Taniya Das > --- > drivers/clk/qcom/Kconfig | 9 + > drivers/clk/qcom/Makefile | 1 + > drivers/clk/qcom/gpucc-kaanapali.c | 494 ++++++++++++++++++++++++++++++++++ > drivers/clk/qcom/gxclkctl-kaanapali.c | 76 ++++++ I previously proposed bunching the little guy with the other object file: https://lore.kernel.org/linux-arm-msm/20250723-topic-8750_gpucc-v2-2-56c93b84c390@oss.qualcomm.com/ And I still think that's a better idea. Alternatively, we could create a small "gxclkctl.c" and make it common across all such platforms, but I'm not sure that makes sense, if for each one of them we're already going to carry a gpucc-xyz.c anyway Konrad