public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Kim Phillips <kim.phillips@amd.com>,
	"V, Narasimhan" <Narasimhan.V@amd.com>,
	Borislav Petkov <bp@alien8.de>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Jan Dabros <jsd@semihalf.com>, Andi Shyti <andi.shyti@kernel.org>,
	"Limonciello, Mario" <Mario.Limonciello@amd.com>
Subject: Re: i2c-designware: NULL ptr at RIP: 0010:regmap_read+0x12/0x70
Date: Thu, 11 Jan 2024 15:01:48 +0200	[thread overview]
Message-ID: <ed4db18f-5590-40a6-adbe-53062d0f382b@linux.intel.com> (raw)
In-Reply-To: <27cf56b5-d21b-4906-823f-a9e567fc26e2@amd.com>

Hi

On 1/11/24 00:56, Kim Phillips wrote:
> Hi,
> 
> On 1/9/24 4:11 AM, Jarkko Nikula wrote> On 1/9/24 09:56, V, Narasimhan 
> wrote:
>>>   * Looks like the issue is with this below commit:
>>>   * i2c: designware: Fix lock probe call order in dw_i2c_plat_probe()
>>>
>> Hmm... This makes me even more confused since your device AMDI0010 
>> should not even use the access semaphore.
>>
>> So linux-next works if you run a commit before it or revert these 
>> three patches? (commit 2f571a725434 ("i2c: designware: Fix lock probe 
>> call order in dw_i2c_plat_probe()") doesn't revert without reverting 
>> two other related commits after it)
>>
>> git show f9b51f600217b38f46ea39d6aa445e594bf3eb30 |patch -p1 -R
>> git show b8034c7d28a988be82efbf4d65faa847334811f7 |patch -p1 -R
>> git show 2f571a72543463ef07dc3ac61e7b703b9ad997f9 |patch -p1 -R
> 
> Narasimhan is right, if I check out, build and boot this commit:
> 
>        2f571a725434 i2c: designware: Fix lock probe call order in 
> dw_i2c_plat_probe()
> 
> I get the same stacktrace on the serial console.
> 
> If I try the previous commit (174a0c565cea "efi/loongarch: Directly 
> position the loaded image file"),
> the system boots fine.
> 
> The same thing happens with the three reversions above:
> next-20240110 gets the stacktrace, but with the three
> reversions, it doesn't.
> 
Thanks, I just sent a fix reverting those commits.

> Is your parallel post probe runtime suspending time window
> theory no longer applicable?  These AMD EPYC systems have a
> lot more cores than their client equivalents, and AMD power
> management code has had a lot of improvements lately.
> 
It still a mystery to me but I let Andy to figure out it if he wants to 
during next development cycle :-)

      reply	other threads:[~2024-01-11 13:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-29 12:08 i2c-designware: NULL ptr at RIP: 0010:regmap_read+0x12/0x70 Borislav Petkov
2024-01-02 13:42 ` Jarkko Nikula
     [not found]   ` <DM4PR12MB508654DF49FE079D6C283D658961A@DM4PR12MB5086.namprd12.prod.outlook.com>
2024-01-03 15:25     ` Jarkko Nikula
     [not found]       ` <DM4PR12MB5086DE2882C7C5044697B1C38967A@DM4PR12MB5086.namprd12.prod.outlook.com>
2024-01-04 13:40         ` Jarkko Nikula
2024-01-06 16:06           ` Andy Shevchenko
     [not found]           ` <DM4PR12MB508652E9A422CF639C2FEEC0896A2@DM4PR12MB5086.namprd12.prod.outlook.com>
2024-01-09 10:11             ` Jarkko Nikula
2024-01-10 22:56               ` Kim Phillips
2024-01-11 13:01                 ` Jarkko Nikula [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed4db18f-5590-40a6-adbe-53062d0f382b@linux.intel.com \
    --to=jarkko.nikula@linux.intel.com \
    --cc=Mario.Limonciello@amd.com \
    --cc=Narasimhan.V@amd.com \
    --cc=andi.shyti@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=jsd@semihalf.com \
    --cc=kim.phillips@amd.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox