public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Baolu Lu <baolu.lu@linux.intel.com>
To: "Tian, Kevin" <kevin.tian@intel.com>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>
Cc: baolu.lu@linux.intel.com, "Liu, Yi L" <yi.l.liu@intel.com>,
	Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] iommu/vt-d: Remove caching mode check before devtlb flush
Date: Wed, 10 Apr 2024 13:40:09 +0800	[thread overview]
Message-ID: <ed515555-06e1-43e2-a2cc-63ad7bcb0cb1@linux.intel.com> (raw)
In-Reply-To: <BN9PR11MB52764F42C20B6B18DDE7E66B8C072@BN9PR11MB5276.namprd11.prod.outlook.com>

On 4/9/24 3:30 PM, Tian, Kevin wrote:
>> Remove the caching mode check before device TLB invalidation to ensure
>> compatibility with the scalable mode use cases.
>>
>> Fixes: 792fb43ce2c9 ("iommu/vt-d: Enable Intel IOMMU scalable mode by
>> default")
>> Signed-off-by: Lu Baolu<baolu.lu@linux.intel.com>
>> ---
>>   drivers/iommu/intel/iommu.c | 5 ++---
>>   1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
>> index 493b6a600394..681789b1258d 100644
>> --- a/drivers/iommu/intel/iommu.c
>> +++ b/drivers/iommu/intel/iommu.c
>> @@ -1501,7 +1501,7 @@ static void iommu_flush_iotlb_psi(struct
>> intel_iommu *iommu,
>>   	else
>>   		__iommu_flush_iotlb_psi(iommu, did, pfn, pages, ih);
>>
>> -	if (!cap_caching_mode(iommu->cap) && !map)
>> +	if (!map)
>>   		iommu_flush_dev_iotlb(domain, addr, mask);
> as commented earlier better squash this in patch1.

Okay, let me squash them into a single patch and make the commit message 
more descriptive.

Best regards,
baolu

  reply	other threads:[~2024-04-10  5:41 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-07 14:42 [PATCH 1/2] iommu/vt-d: Avoid unnecessary device TLB flush in map path Lu Baolu
2024-04-07 14:42 ` [PATCH 2/2] iommu/vt-d: Remove caching mode check before devtlb flush Lu Baolu
2024-04-08  7:21   ` Ethan Zhao
2024-04-08  7:23     ` Baolu Lu
2024-04-08  7:43       ` Ethan Zhao
2024-04-08 21:03   ` Jacob Pan
2024-04-09  3:12     ` Baolu Lu
2024-04-09 17:31       ` Jacob Pan
2024-04-10  0:32         ` Tian, Kevin
2024-04-10 16:19           ` Jacob Pan
2024-04-10 23:23             ` Tian, Kevin
2024-04-11 16:17               ` Jacob Pan
2024-04-12  3:13                 ` Tian, Kevin
2024-04-09  7:30   ` Tian, Kevin
2024-04-10  5:40     ` Baolu Lu [this message]
2024-04-10 23:49     ` Zhang, Tina
2024-04-11 12:15       ` Baolu Lu
2024-04-09  8:36   ` Yi Liu
2024-04-09  7:20 ` [PATCH 1/2] iommu/vt-d: Avoid unnecessary device TLB flush in map path Tian, Kevin
2024-04-09  7:21 ` Tian, Kevin
2024-04-09  8:27 ` Yi Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed515555-06e1-43e2-a2cc-63ad7bcb0cb1@linux.intel.com \
    --to=baolu.lu@linux.intel.com \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    --cc=yi.l.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox