From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758394AbdACMQE (ORCPT ); Tue, 3 Jan 2017 07:16:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35830 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758342AbdACMPp (ORCPT ); Tue, 3 Jan 2017 07:15:45 -0500 Subject: Re: [PATCH v2 1/6] KVM: x86: don't allow kernel irqchip with split irqchip To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <20161216151006.11776-1-rkrcmar@redhat.com> <20161216151006.11776-2-rkrcmar@redhat.com> Cc: Paolo Bonzini From: David Hildenbrand Organization: Red Hat GmbH Message-ID: Date: Tue, 3 Jan 2017 13:15:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20161216151006.11776-2-rkrcmar@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 03 Jan 2017 12:15:46 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 16.12.2016 um 16:10 schrieb Radim Krčmář: > Split irqchip cannot be created after creating the kernel irqchip, but > we forgot to restrict the other way. This is an API change. > > Reviewed-by: Paolo Bonzini > Signed-off-by: Radim Krčmář > --- > v2: r-b Paolo > --- > arch/x86/kvm/x86.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 1f0d2383f5ee..e670591337af 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -3939,7 +3939,7 @@ long kvm_arch_vm_ioctl(struct file *filp, > > mutex_lock(&kvm->lock); > r = -EEXIST; > - if (kvm->arch.vpic) > + if (irqchip_in_kernel(kvm)) > goto create_irqchip_unlock; > r = -EINVAL; > if (kvm->created_vcpus) > Reviewed-by: David Hildenbrand -- David