From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261247AbVG0X1Z (ORCPT ); Wed, 27 Jul 2005 19:27:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261160AbVG0XZV (ORCPT ); Wed, 27 Jul 2005 19:25:21 -0400 Received: from wproxy.gmail.com ([64.233.184.203]:27306 "EHLO wproxy.gmail.com") by vger.kernel.org with ESMTP id S261238AbVG0XXk convert rfc822-to-8bit (ORCPT ); Wed, 27 Jul 2005 19:23:40 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=WukZzhyYjnKbgfuu69/AfoQGHxSYXKasgMxy50BtPnRizy8Onv6ZL/CGfD/ZijFp5DKxfFBhOOT1dbQm/6trJD5Xif64SURDotWAxjP4WhtzhYrhGGlyKRCGEio7DjEVO2L5Naehn2G6xgGk+5H0oclywonRyE00HHLXg4Tz+Lc= Message-ID: Date: Wed, 27 Jul 2005 16:23:37 -0700 From: david mosberger Reply-To: David.Mosberger@acm.org To: Andrew Morton Subject: Re: Add prefetch switch stack hook in scheduler function Cc: "Chen, Kenneth W" , mingo@elte.hu, linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org In-Reply-To: <20050727161316.0593d762.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Content-Disposition: inline References: <200507272207.j6RM7fg18695@unix-os.sc.intel.com> <20050727161316.0593d762.akpm@osdl.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Also, should this be called prefetch_stack() or perhaps even just prefetch_task()? Not every architecture defines a switch_stack structure. --david -- Mosberger Consulting LLC, voice/fax: 510-744-9372, http://www.mosberger-consulting.com/ 35706 Runckel Lane, Fremont, CA 94536 On 7/27/05, Andrew Morton wrote: > "Chen, Kenneth W" wrote: > > > > +#ifdef ARCH_HAS_PREFETCH_SWITCH_STACK > > +extern void prefetch_switch_stack(struct task_struct*); > > +#else > > +#define prefetch_switch_stack(task) do { } while (0) > > +#endif > > It is better to use > > static inline void prefetch_switch_stack(struct task_struct *t) { } > > in the second case, rather than a macro. It provides typechecking. > - > To unsubscribe from this list: send the line "unsubscribe linux-ia64" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >