From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67C5F3E3D94 for ; Mon, 4 May 2026 16:53:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777913620; cv=none; b=e1CZMeZZu5e/6tKEU8BgTwFFLTDw1LOZcbreti1Bv6GRFC4G4GirsD+ssLveWU+RXemzVVIPWHSFkOJcZYyrTJWsPJy7W5cItFxSEwa+H9bggxpe7q5Q1znE8UuHwKAptJT/JKdO/voXmsr9OR5RC21pk5PCCgQ9z1GuiAy32kk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777913620; c=relaxed/simple; bh=6aDoCDaH2DT+KGLoUMWcSaPgguhvxaT71nKCCAnCZ2c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ljAAZZHszI60qsx3hmmmjfuomoqQRvO7xkEOYaw2yW79lT4eGqF2vUtxcWo5EiIbg5WL4YODo78gyWBUY5PrzSlOlUjThnS5g6aK6Lb5B2PHq1EJHnVVxG/baLut8Nr6AGOAel5WSSSPjsuf+rVzIuulbalQ165Ic+mRbT/1SM0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=sCovopAk; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="sCovopAk" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=2WVzZ9GmbB+FVObMpzZGUB3oQElcwYh5kIlgy1BGmtU=; b=sCovopAkniAAAo7unacgLLW/j0 k6MIqJ86gcr1WzGUyqKT3dU29Ba9WkFTy6dwxFa6WM1C9iX95SV53Hjdk1NCXUTDW7sL4aB0rdOF0 yjFe54jWh3+FIZ0VkNQ49vN2Rq+F+PAzAeZUXO/ZlKfg7q2k1rBfDE1ZneSzi9DGuBWIOm4UIehsy ehZtWdifcTVz5S2wqZb+4bVuH34+6lGYuj5FtJCh3iOHhPl+T2IZ0KAf+iOSRi9/VDMCwfPo2hUIk 6RZ4c9F8fnSWFtvbUjJ08AOCOCf8mvRZWae4RIxenNYQmJ9C8C+rV+6qlM43m56TqnBbvDo869DsO ZYvspMWQ==; Received: from [50.53.43.113] (helo=[192.168.254.34]) by bombadil.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1wJwXv-0000000Dlk3-0cfq; Mon, 04 May 2026 16:53:27 +0000 Message-ID: Date: Mon, 4 May 2026 09:53:26 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ARM: kprobes: test: add MODULE_DESCRIPTION To: Arnd Bergmann , Russell King Cc: Jeff Johnson , Arnd Bergmann , Kees Cook , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260504065957.2040055-1-arnd@kernel.org> Content-Language: en-US From: Randy Dunlap In-Reply-To: <20260504065957.2040055-1-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/3/26 11:59 PM, Arnd Bergmann wrote: > From: Arnd Bergmann > > All loadable modules must have a description, and since commit > 6c6c1fc09de3 ("modpost: require a MODULE_DESCRIPTION()"), the kernel build > warns about it missing: > > WARNING: modpost: missing MODULE_DESCRIPTION() in arch/arm/probes/kprobes/test-kprobes.o > > Add the missing description tags. Noticing that the existing license tag > is unnecessarily hidden in an #ifdef section, remove the #ifdef and > use conventional placing of the initcall and module_exit tags as well > as the license and description. > > Signed-off-by: Arnd Bergmann Tested-by: Randy Dunlap # build-tested Reviewed-by: Randy Dunlap Thanks. > --- > arch/arm/probes/kprobes/test-core.c | 14 +++----------- > 1 file changed, 3 insertions(+), 11 deletions(-) > > diff --git a/arch/arm/probes/kprobes/test-core.c b/arch/arm/probes/kprobes/test-core.c > index 7a2baa135f0f..2de28088dac8 100644 > --- a/arch/arm/probes/kprobes/test-core.c > +++ b/arch/arm/probes/kprobes/test-core.c > @@ -1649,24 +1649,16 @@ static int __init run_all_tests(void) > > return ret; > } > - > +late_initcall(run_all_tests); > > /* > * Module setup > */ > > -#ifdef MODULE > - > static void __exit kprobe_test_exit(void) > { > } > - > -module_init(run_all_tests) > module_exit(kprobe_test_exit) > -MODULE_LICENSE("GPL"); > > -#else /* !MODULE */ > - > -late_initcall(run_all_tests); > - > -#endif > +MODULE_DESCRIPTION("Test code for ARM kprobes"); > +MODULE_LICENSE("GPL"); -- ~Randy