From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jacobe Zang <jacobe.zang@wesion.com>,
Kalle Valo <kvalo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
van Spriel <arend@broadcom.com>,
Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com
Subject: Re: [PATCH v13 3/5] dt-bindings: net: wireless: brcm4329-fmac: change properties enum structure
Date: Wed, 28 Aug 2024 15:04:51 +0200 [thread overview]
Message-ID: <ed670624-2b97-41e0-a243-26b8c5cda70b@kernel.org> (raw)
In-Reply-To: <20240828-wireless-mainline-v13-3-9998b19cfe7e@wesion.com>
On 28/08/2024 10:49, Jacobe Zang wrote:
> Add "brcm,bcm4329-fmac" as fallback compatible for wireless devices that
> used PCI ID based compatible. So that can pass the compatible check in
> driver.
Driver? Why this has to pass compatible check?
I think I asked to provide proper rationale based on hardware... if not,
then let me ask here: Please provide proper rationale explaining how
this hardware is compatible, especially considering these are entirely
different buses (SDIO and PCI!).
It feels you patch up bindings and DTS, because of buggy driver. Sorry
no, fix the driver.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-28 13:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 8:49 [PATCH v13 0/5] Add AP6276P wireless support Jacobe Zang
2024-08-28 8:49 ` [PATCH v13 1/5] dt-bindings: net: wireless: brcm4329-fmac: add pci14e4,449d Jacobe Zang
2024-08-28 8:49 ` [PATCH v13 2/5] dt-bindings: net: wireless: brcm4329-fmac: add clock description for AP6275P Jacobe Zang
2024-08-28 8:49 ` [PATCH v13 3/5] dt-bindings: net: wireless: brcm4329-fmac: change properties enum structure Jacobe Zang
2024-08-28 13:04 ` Krzysztof Kozlowski [this message]
2024-08-28 13:20 ` Jacobe Zang
2024-08-28 8:49 ` [PATCH v13 4/5] wifi: brcmfmac: Add optional lpo clock enable support Jacobe Zang
2024-08-28 15:20 ` Simon Horman
2024-08-29 0:05 ` Jacobe Zang
2024-08-29 16:31 ` kernel test robot
2024-08-29 16:41 ` kernel test robot
2024-08-28 8:49 ` [PATCH v13 5/5] wifi: brcmfmac: add flag for random seed during firmware download Jacobe Zang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed670624-2b97-41e0-a243-26b8c5cda70b@kernel.org \
--to=krzk@kernel.org \
--cc=arend.vanspriel@broadcom.com \
--cc=arend@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=jacobe.zang@wesion.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox