Re: [PATCH v2 2/4] perf record: bind the AIO user space buffers to nodes

Jiri Olsa
2019-01-01T21:39:46Z

On Mon, Dec 24, 2018 at 03:24:36PM +0300, Alexey Budankov wrote:

SNIP

> +#else
> +static void perf_mmap__aio_alloc(void **data, size_t len)
> +{
> + *data = malloc(len);
> +}
> +
> +static void perf_mmap__aio_free(void **data, size_t len __maybe_unused)
> +{
> + zfree(data);
> +}
> +
> +static void perf_mmap__aio_bind(void *data __maybe_unused, size_t len __maybe_unused,
> + int cpu __maybe_unused, int affinity __maybe_unused)
> +{
> +}
> +#endif
> +
> static int perf_mmap__aio_mmap(struct perf_mmap *map, struct mmap_params *mp)
> {
> int delta_max, i, prio;
> @@ -177,11 +220,13 @@ static int perf_mmap__aio_mmap(struct perf_mmap *map, struct mmap_params *mp)
> }
> delta_max = sysconf(_SC_AIO_PRIO_DELTA_MAX);
> for (i = 0; i < map->aio.nr_cblocks; ++i) {
> - map->aio.data[i] = malloc(perf_mmap__mmap_len(map));
> + size_t mmap_len = perf_mmap__mmap_len(map);

WARNING: Missing a blank line after declarations

and plenty of othres from scripts/checkpatch.pl,
please run that

jirka