RE: [PATCH 1/3] drm: zynqmp: Check property creation status

Klymenko, Anatoliy
2025-11-13T23:05:41Z

[AMD Official Use Only - AMD Internal Distribution Only]

Hi Sean,

> -----Original Message-----
> From: Sean Anderson <sean.anderson@linux.dev>
> Sent: Thursday, November 13, 2025 12:37 PM
> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>; Tomi Valkeinen
> <tomi.valkeinen@ideasonboard.com>; dri-devel@lists.freedesktop.org
> Cc: linux-kernel@vger.kernel.org; Mike Looijmans <mike.looijmans@topic.nl>;
> David Airlie <airlied@gmail.com>; Thomas Zimmermann
> <tzimmermann@suse.de>; Maarten Lankhorst
> <maarten.lankhorst@linux.intel.com>; Klymenko, Anatoliy
> <Anatoliy.Klymenko@amd.com>; Maxime Ripard <mripard@kernel.org>; linux-
> arm-kernel@lists.infradead.org; Simona Vetter <simona@ffwll.ch>; Simek,
> Michal <michal.simek@amd.com>; Sean Anderson
> <sean.anderson@linux.dev>
> Subject: [PATCH 1/3] drm: zynqmp: Check property creation status
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Make sure to return an error in the event that we can't create our
> properties.
>
> Fixes: 650f12042b85 ("drm: xlnx: zynqmp_dpsub: Add global alpha support")
> Fixes: 8c772f0b2b8e ("drm: xlnx: zynqmp_dpsub: Expose plane ordering to
> userspace")
>
> Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
> ---
>
> drivers/gpu/drm/xlnx/zynqmp_kms.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c
> b/drivers/gpu/drm/xlnx/zynqmp_kms.c
> index 2bee0a2275ed..c80a2d4034f3 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_kms.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c
> @@ -174,9 +174,15 @@ static int zynqmp_dpsub_create_planes(struct
> zynqmp_dpsub *dpsub)
>
> drm_plane_helper_add(plane, &zynqmp_dpsub_plane_helper_funcs);
>
> - drm_plane_create_zpos_immutable_property(plane, i);
> - if (i == ZYNQMP_DPSUB_LAYER_GFX)
> - drm_plane_create_alpha_property(plane);
> + ret = drm_plane_create_zpos_immutable_property(plane, i);
> + if (ret)
> + return ret;
> +
> + if (i == ZYNQMP_DPSUB_LAYER_GFX) {
> + ret = drm_plane_create_alpha_property(plane);
> + if (ret)
> + return ret;
> + }
> }
>
> return 0;
> --
> 2.35.1.1320.gc452695387.dirty

Looks good to me.

Reviewed-by: Anatoliy Klymenko <anatoliy.klymenko@amd.com>

Thank you,
Anatoliy