public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Barnes <jeffbarnes@linux.microsoft.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
	Joachim Vandersmissen <git@jvdsn.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jeff Barnes <jeffbarnes@microsoft.com>
Subject: Re: [PATCH] crypto: aead: add service indicator flag for RFC4106 AES-GCM
Date: Mon, 2 Mar 2026 16:34:55 -0500	[thread overview]
Message-ID: <edc8b5da-022b-4e64-8364-dca2cac410e2@linux.microsoft.com> (raw)
In-Reply-To: <aaWB3RkW4AeJ-c9z@gondor.apana.org.au>


On 3/2/26 07:26, Herbert Xu wrote:
> On Sun, Mar 01, 2026 at 02:41:28PM -0600, Joachim Vandersmissen wrote:
>> However, Cryptographic Module Validation Program has also recently made it
>> clear that xxhash64 cannot be FIPS approved the way it is currently
>> implemented in the kernel. Even though the designers of xxhash publicly
>> state that it is a non-cryptographic hash, the kernel offers it as part of
>> the shash interface, the same interface as the approved algorithms. The
>> interface / API also has "crypto" in the name, which according to CMVP
>> implies security. CMVP feels that there could be confusion with the approved
>> hash algorithms, so there needs to be some indication that xxhash64 is not
>> FIPS approved. I think blocking xxhash64 in FIPS mode would break btrfs,
>> where it is used for checksumming.
> xxhash64 should be converted to lib/crypto and removed from the
> Crypto API.
>
> Thanks,


I believe Eric Biggers commitfe11ac191ce0ad910f6fda0c628bcff19fcff47d 
did this already.
Best,
Jeff



  reply	other threads:[~2026-03-02 21:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-29 21:04 [PATCH] crypto: aead: add service indicator flag for RFC4106 AES-GCM jeffbarnes
2026-01-30  5:10 ` Herbert Xu
2026-02-17 20:59   ` Jeff Barnes
2026-02-28  8:56     ` Herbert Xu
2026-03-01 20:41       ` Joachim Vandersmissen
2026-03-02 12:26         ` Herbert Xu
2026-03-02 21:34           ` Jeff Barnes [this message]
2026-03-02 21:51         ` Jeff Barnes
2026-03-03  3:37           ` Herbert Xu
2026-03-12 14:00             ` Jeff Barnes
2026-03-14 19:37               ` Eric Biggers
2026-03-03 15:14           ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=edc8b5da-022b-4e64-8364-dca2cac410e2@linux.microsoft.com \
    --to=jeffbarnes@linux.microsoft.com \
    --cc=davem@davemloft.net \
    --cc=git@jvdsn.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jeffbarnes@microsoft.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox