From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941335AbcIHNue (ORCPT ); Thu, 8 Sep 2016 09:50:34 -0400 Received: from mout.web.de ([212.227.15.4]:52504 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932244AbcIHNuc (ORCPT ); Thu, 8 Sep 2016 09:50:32 -0400 To: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, Chas Williams <3chas3@gmail.com> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Subject: [PATCH] ATM-ForeRunnerHE: Use kmalloc_array() in he_init_group() Message-ID: Date: Thu, 8 Sep 2016 15:50:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:JGgL9yP32BJ3qQbrdF/T/zn7Tp+wwDXnw9qGN1VECGXbfi71uGB gsqCZxwnj7KDQns80ZjgQg1DIO8CwuLpZEBd/hJQR66tGVRHcTUTQMiZKyRqHkZRa/INip6 KrPHP+WmbvlruBoY/tgyiIF4S9ZU4LuTo0YEGDRfjD3yrvyAiO4neW6Xfwzg85JtTFWJz5C DDn1//dCcqS/z2Ws12OIw== X-UI-Out-Filterresults: notjunk:1;V01:K0:GrlrSffaMOw=:p7oF297zVRNn8gVa0KrmNt 9offkiQ+n6C93SyPipMezfDDBlANHzlrICrjP2oVbSBYVRUVEYj5Mh0hNuD63b91tRSpR7LGR Gei56elXbwzuuISfOB7xeJpqRQPmt/bWfuFmlhJPbVkymD01EeiOlnT2bKxmG6Dzjeful2oE7 XW6P1OmpoXEjH8p3SkVYRo1ax69O2JMVkj1sjeqYjWXYK36IiVeApI1KWe3Fdj44NeE4IcLco wS0miGHnq3NpLy2BnvDjEtcci4W7sxG/0N6lZ8mYmONfV7G6sLGfxgrogg3uzIJPMhoqxhWsf rdJ4+CIA5I37yNNEmrl+6qQPKSkaCaJirTT1jH5kZaibhLT1LqxY4W1SsGw5xt5FmFYlHsrLc qsY+z+Qi9WfL/7mI5K5lt8rlJhIZwG8zQxfdpjDIN7L9HpKjaAtkfxwjhh0OE1hJAFC8NuzkW vvYKpY9V8Y3wyr5KOCn3tzfAbJ6BEybiemkjKHRu4AfwYbFjNL5NNJwo89ji8p/7pkhRVghAy RSqO8QHZzFQ1nBb22Ok+X7CE29FIPpdIp4Wem14a5US5czkVPm10oX5MBN5XVT/btnGOCfQd0 BJnLXYyO/kPur34PnAwn/VI0YqcnSmNubfCsZ3UvUxingvb54UyPsvx2mxunariTP8ZLlxGUx QSkKt8jO8bw1rf8uSQCBjs8p5VKU9GUa1Rc0axg3r7xanLeXTUsf2NCU+F6M8ZmeqTv7Bf7ar JIPYVCMCXAbm6NM7l3XXQV3g/E6rRIFNOx6s+e8kXtCpG4EqS3SUMWtUddJR3SajNVhsMmM6u oDHHJ4C Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 8 Sep 2016 15:43:37 +0200 * Multiplications for the size determination of memory allocations indicated that array data structures should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of data types by pointer dereferences to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/atm/he.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/atm/he.c b/drivers/atm/he.c index 0f5cb37..31b513a 100644 --- a/drivers/atm/he.c +++ b/drivers/atm/he.c @@ -779,8 +779,9 @@ static int he_init_group(struct he_dev *he_dev, int group) G0_RBPS_BS + (group * 32)); /* bitmap table */ - he_dev->rbpl_table = kmalloc(BITS_TO_LONGS(RBPL_TABLE_SIZE) - * sizeof(unsigned long), GFP_KERNEL); + he_dev->rbpl_table = kmalloc_array(BITS_TO_LONGS(RBPL_TABLE_SIZE), + sizeof(*he_dev->rbpl_table), + GFP_KERNEL); if (!he_dev->rbpl_table) { hprintk("unable to allocate rbpl bitmap table\n"); return -ENOMEM; @@ -788,8 +789,9 @@ static int he_init_group(struct he_dev *he_dev, int group) bitmap_zero(he_dev->rbpl_table, RBPL_TABLE_SIZE); /* rbpl_virt 64-bit pointers */ - he_dev->rbpl_virt = kmalloc(RBPL_TABLE_SIZE - * sizeof(struct he_buff *), GFP_KERNEL); + he_dev->rbpl_virt = kmalloc_array(RBPL_TABLE_SIZE, + sizeof(*he_dev->rbpl_virt), + GFP_KERNEL); if (!he_dev->rbpl_virt) { hprintk("unable to allocate rbpl virt table\n"); goto out_free_rbpl_table; -- 2.10.0