From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D6A1CA9EAE for ; Tue, 29 Oct 2019 17:59:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 347632087E for ; Tue, 29 Oct 2019 17:59:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="A/NChKpM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730307AbfJ2R7x (ORCPT ); Tue, 29 Oct 2019 13:59:53 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:59332 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727379AbfJ2R7w (ORCPT ); Tue, 29 Oct 2019 13:59:52 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9THnDC8141162; Tue, 29 Oct 2019 17:59:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=NibxEBGYCnjU+gMxJTzBvOQSJh74N1uoQV8IyZK77hs=; b=A/NChKpM7JIuo4fcwZ0W0q7pFMnedx/bPjsJ+aGobzi6iRYZ6+1qtDpoMRfkf4Oq/e+c ijwA8v9OANZydb8P5NdYpaNk3GGW5VIu74LqcyqwAhbrMW3cGw9O4BiRbF7QW2O2PVGI QG75Nng9tPzAYJQZEw1x/VMaoP3zpD3mJUu+IZfhsZVYI2g4rUdBUy3iKl6KyZUG23I1 IFMTgHKgCVfg/Join7p9YEiw53iKBolAZDiQ5OZJZZcU34ECYwCtm/QN56f3hdwNt5Zj YbWv83YSBaJFWQvou2nE7PZ9kCG1FM89yiyZFahKuiM1fw/BpK3rezOJiZM/HV6uz55I 7Q== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 2vve3qaxc6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 29 Oct 2019 17:59:38 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9THn4LK120202; Tue, 29 Oct 2019 17:59:37 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3020.oracle.com with ESMTP id 2vxpfdff8a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 29 Oct 2019 17:59:37 +0000 Received: from abhmp0022.oracle.com (abhmp0022.oracle.com [141.146.116.28]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x9THxZlo028919; Tue, 29 Oct 2019 17:59:35 GMT Received: from dhcp-10-159-132-196.vpn.oracle.com (/10.159.132.196) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 29 Oct 2019 10:59:35 -0700 Subject: Re: [PATCH -next] soc: ti: omap-prm: fix return value check in omap_prm_probe() To: Wei Yongjun , Santosh Shilimkar , Tero Kristo Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org References: <20191011052436.76075-1-weiyongjun1@huawei.com> From: "santosh.shilimkar@oracle.com" Organization: Oracle Corporation Message-ID: Date: Tue, 29 Oct 2019 10:59:34 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191011052436.76075-1-weiyongjun1@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9425 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=3 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=945 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910290159 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9425 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=3 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910290159 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/10/19 10:24 PM, Wei Yongjun wrote: > In case of error, the function devm_ioremap_resource() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check should > be replaced with IS_ERR(). > > Fixes: 3e99cb214f03 ("soc: ti: add initial PRM driver with reset control support") > Signed-off-by: Wei Yongjun > --- Applied