Re: [PATCH 01/13] ASoC: amd: acp: Add acp6.3 pci legacy driver support

[Krzysztof Kozlowski <krzk@kernel.org>]

On 21/10/2023 16:50, Syed Saba Kareem wrote:
> Add pci legacy driver support and create platform driver for
> acp6.3 based platforms.
> 
> Signed-off-by: Syed Saba Kareem <Syed.SabaKareem@amd.com>
> ---
>  sound/soc/amd/acp/acp-legacy-common.c |   4 +
>  sound/soc/amd/acp/acp-pci.c           |   4 +
>  sound/soc/amd/acp/acp63.c             | 314 ++++++++++++++++++++++++++
>  sound/soc/amd/acp/amd.h               |   4 +
>  4 files changed, 326 insertions(+)
>  create mode 100644 sound/soc/amd/acp/acp63.c
> 


> +
> +static const struct dev_pm_ops acp63_dma_pm_ops = {
> +	SET_SYSTEM_SLEEP_PM_OPS(NULL, acp63_pcm_resume)
> +};
> +
> +static struct platform_driver acp63_driver = {
> +	.probe = acp63_audio_probe,
> +	.remove_new = acp63_audio_remove,
> +	.driver = {
> +		.name = "acp_asoc_acp63",
> +		.pm = &acp63_dma_pm_ops,
> +	},
> +};
> +
> +module_platform_driver(acp63_driver);
> +
> +MODULE_DESCRIPTION("AMD ACP acp63 Driver");
> +MODULE_IMPORT_NS(SND_SOC_ACP_COMMON);
> +MODULE_LICENSE("Dual BSD/GPL");
> +MODULE_ALIAS("platform:" DRV_NAME);

You should not need MODULE_ALIAS() in normal cases. If you need it,
usually it means your device ID table is wrong.


Best regards,
Krzysztof