Re: [PATCH v7 08/13] fs: drop the timespec64 argument from update_time

Mike Marshall
2023-08-09T18:38:26Z

I've been following this patch on fsdevel... is there a
remote I could fetch with a branch that has this in it?

-Mike

On Wed, Aug 9, 2023 at 8:32 AM Christian Brauner <brauner@kernel.org> wrote:
>
> On Mon, Aug 07, 2023 at 03:38:39PM -0400, Jeff Layton wrote:
> > Now that all of the update_time operations are prepared for it, we can
> > drop the timespec64 argument from the update_time operation. Do that and
> > remove it from some associated functions like inode_update_time and
> > inode_needs_update_time.
> >
> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
> > ---
> > fs/bad_inode.c | 3 +--
> > fs/btrfs/inode.c | 3 +--
> > fs/btrfs/volumes.c | 4 +---
> > fs/fat/fat.h | 3 +--
> > fs/fat/misc.c | 2 +-
> > fs/gfs2/inode.c | 3 +--
> > fs/inode.c | 30 +++++++++++++-----------------
> > fs/overlayfs/inode.c | 2 +-
> > fs/overlayfs/overlayfs.h | 2 +-
> > fs/ubifs/file.c | 3 +--
> > fs/ubifs/ubifs.h | 2 +-
> > fs/xfs/xfs_iops.c | 1 -
> > include/linux/fs.h | 4 ++--
>
> This was missing the conversion of fs/orangefs orangefs_update_time()
> causing the build to fail. So at some point kbuild will yell here.
> Fwiw, I've fixed that up in-tree.