From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5139C20C47A for ; Thu, 24 Apr 2025 11:53:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745495627; cv=none; b=dNQyH8opeKSUxX52GDZETSlYN3Aw75xl+tYgGr6BrS/ajLbYD5PAvXQ8dNHo29pkGNAocz336gMwJgXsbGdgxfEU2J3o/UNuj+9dnU9VVB355BST7lPKuvj5ko1S8JPnNrX2hlSwOX2T0Cf/8C8lyrCruwvAxFZhg49hIdVpqeg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745495627; c=relaxed/simple; bh=Fpd73RRnHn/l4PYVjhLh24iJQjof1gdaW83Nyo/GhgU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=j16B+A/BNpCvUyuDqF9gmPgmFUdooFhTfQ7IQpQqEpItu3l5pvc1xBD3+nIbx2Iqfw3rp6Japfi7ZJXBWTPL0f/tW7F85PcSA4DMCpnmlsgpDF1O/4kvZDOUDiH5mtAZIceF5RbugR/YaEFZakvcd9MNLVpI75K7eWScAPtRm4k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=U0x6VSFZ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="U0x6VSFZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745495624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7O71wS6omUP4Za+qu8KkJ9Z+HYsi5jrXQRVuEjbLS/Y=; b=U0x6VSFZpsG194wzvpvDS5puCDW1O4c6T2wxbF4VaeOkTqTz8aUnoZ8dIdiCV/bFQlsJSZ B23RuiJbzuIAYP2Xey7gg9+hQdr3WC79uHcoQquf/Fi6bzAfYF2wBwlEraZgplsbU8nYh0 NP2+iAKn90MetYoSuwWcWga6M4nmHfA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-128-1N7Uj2yvN2CJWOwmjR7pLA-1; Thu, 24 Apr 2025 07:53:43 -0400 X-MC-Unique: 1N7Uj2yvN2CJWOwmjR7pLA-1 X-Mimecast-MFC-AGG-ID: 1N7Uj2yvN2CJWOwmjR7pLA_1745495622 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43efa869b0aso5598945e9.3 for ; Thu, 24 Apr 2025 04:53:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745495622; x=1746100422; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7O71wS6omUP4Za+qu8KkJ9Z+HYsi5jrXQRVuEjbLS/Y=; b=wYc5eUfWD50F7/L/F/QCxzLx77W20xOZQ7moPWl+nrrGI1QGfFB2i+MMk8wE0x+rnz oopARyaVcYTiGFlj+B5Jns+20Huq/KZtizZZ90wwj3u35mrax8gAWYu2i4Lxn4PE+jwj Jtq7cQXNA9se8gDPH2IBURoIzYQOkjZ8Snh+P1s6OdafTUdFSIILQgPbuuraPRIvF/O1 vqg/5jRsNIPwJKjHRXvukrs0nydqFXpxf7aU8C1Gxddzq3SV3jjbsvMKZvdGYtuLAoZi 5t5p2vpeMdIIq3Qjvy2PVWs9Z0D/HjI50o1sm+Itx9RO8B9kZNhhSoue7sjVwHbbR7SX 2iCA== X-Forwarded-Encrypted: i=1; AJvYcCW6XTry+CzDMlTS+sStT44lXz4BhxHN+wrsMz2QP8eEcqQLMoAIQmiKl9bB2zQ53NXrBwhoOyzTEQuLapY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0VDMf5ezALvce5gF2rTHZ0xBFrts1NFgSYC+5QasXKnchNT4Z EF1uy9Ue70dVNck3VSANHA54mSHUaz7R+bg1kZx8ndIZNSqECEiF2KxeH4dIl5qzNytVFbk6ICk Ekatg+XwfpsHfHX/xJKwpOK3c1sZN1Uj8SigAyzmwk2otHFPvF+N/9DB0QsGelA== X-Gm-Gg: ASbGnctiIigdGqpg2w4wlgCwgqwLa34awHOBoHNIHQETnnfi0QuDS0FME8Dn4U/M89D t3xKCYLmgY8bom/XiggMax4Ue3WhtSA/q/Jkg/0SrJxb3VwrNIypqWtGukg+FgQU3xnP6jDnOLA sp/hWwT0JBpfnvC6sRCSKcJtTyDUcYj+GKwwdhpnMkbTkfP+LkSV7+9MIzd2rZWsWpsO5FDxvFv 49dxElSt2+RDQxiES1XL+F5D3mDuEiLjyj5n0D5Qc/yXwy6J+K11uCpd1UIST/GUxcLpXOb/Anh g12DDAP7NHhdDTBsQXN2u2KEl4zheQV2k05Ymt8= X-Received: by 2002:a05:600c:4e0a:b0:43c:f513:9585 with SMTP id 5b1f17b1804b1-4409bd210eemr25352645e9.13.1745495621866; Thu, 24 Apr 2025 04:53:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEUAI2NQUKhz4qnOoSRg3Qvi8tq8xdza5SLA8RiijZXZRu9gfA8tceguZucQbwMmFsJdyoLyg== X-Received: by 2002:a05:600c:4e0a:b0:43c:f513:9585 with SMTP id 5b1f17b1804b1-4409bd210eemr25352255e9.13.1745495621516; Thu, 24 Apr 2025 04:53:41 -0700 (PDT) Received: from [192.168.88.253] (146-241-7-183.dyn.eolo.it. [146.241.7.183]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a06d54c246sm1831740f8f.86.2025.04.24.04.53.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Apr 2025 04:53:40 -0700 (PDT) Message-ID: Date: Thu, 24 Apr 2025 13:53:39 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v4 2/2] net: stmmac: dwxgmac2: Add support for HW-accelerated VLAN stripping To: Boon Khai Ng , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Cc: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Maxime Coquelin , Alexandre Torgue , Russell King , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Furong Xu <0x1207@gmail.com>, Matthew Gerlach , Tien Sung Ang , Mun Yew Tham , G Thomas Rohan References: <20250421162930.10237-1-boon.khai.ng@altera.com> <20250421162930.10237-3-boon.khai.ng@altera.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20250421162930.10237-3-boon.khai.ng@altera.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/21/25 6:29 PM, Boon Khai Ng wrote: > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c > index 389aad7b5c1e..55921c88efd0 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c > @@ -4,6 +4,7 @@ > * stmmac XGMAC support. > */ > > +#include > #include > #include "common.h" > #include "dwxgmac2.h" > @@ -69,6 +70,21 @@ static int dwxgmac2_get_tx_ls(struct dma_desc *p) > return (le32_to_cpu(p->des3) & XGMAC_RDES3_LD) > 0; > } > > +static u16 dwxgmac2_wrback_get_rx_vlan_tci(struct dma_desc *p) > +{ > + return (le32_to_cpu(p->des0) & XGMAC_RDES0_VLAN_TAG_MASK); > +} > + > +static inline bool dwxgmac2_wrback_get_rx_vlan_valid(struct dma_desc *p) Please, avoid 'inline' function in .c files, especially for functions that will land into function pointer like this one. Thanks, Paolo