From: "Nuno Sá" <noname.nuno@gmail.com>
To: Tom Rix <trix@redhat.com>,
jic23@kernel.org, lars@metafoo.de, angelo.dureghello@timesys.com
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: dac: set varaiable max5522_channels storage-class-specifier to static
Date: Tue, 04 Apr 2023 08:43:32 +0200 [thread overview]
Message-ID: <ee03cecef9139720a9818aa434dd34ae433d8e9d.camel@gmail.com> (raw)
In-Reply-To: <20230404013828.1914523-1-trix@redhat.com>
On Mon, 2023-04-03 at 21:38 -0400, Tom Rix wrote:
> smatch reports
> drivers/iio/dac/max5522.c:55:28: warning: symbol
> 'max5522_channels' was not declared. Should it be static?
>
> This variable is only used in one file so it should be static.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
next prev parent reply other threads:[~2023-04-04 6:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 1:38 [PATCH] iio: dac: set varaiable max5522_channels storage-class-specifier to static Tom Rix
2023-04-04 6:43 ` Nuno Sá [this message]
2023-04-07 18:01 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee03cecef9139720a9818aa434dd34ae433d8e9d.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=angelo.dureghello@timesys.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox