Re: [tip: timers/core] time/kunit: Use correct format specifier

David Gow
2024-02-23T07:01:59Z

[-- Attachment #1: Type: text/plain, Size: 1315 bytes --]

Hi,

On Thu, 22 Feb 2024 at 02:21, tip-bot2 for David Gow
<tip-bot2@linutronix.de> wrote:
>
> The following commit has been merged into the timers/core branch of tip:
>
> Commit-ID: e0a1284b293bdf91a68a6d1a0479ad476d0d8ec2
> Gitweb: https://git.kernel.org/tip/e0a1284b293bdf91a68a6d1a0479ad476d0d8ec2
> Author: David Gow <davidgow@google.com>
> AuthorDate: Wed, 21 Feb 2024 17:27:17 +08:00
> Committer: Thomas Gleixner <tglx@linutronix.de>
> CommitterDate: Wed, 21 Feb 2024 12:00:42 +01:00
>
> time/kunit: Use correct format specifier
>
> 'days' is a s64 (from div_s64), and so should use a %lld specifier.
>
> This was found by extending KUnit's assertion macros to use gcc's
> __printf attribute.
>
> Fixes: 276010551664 ("time: Improve performance of time64_to_tm()")
> Signed-off-by: David Gow <davidgow@google.com>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Link: https://lore.kernel.org/r/20240221092728.1281499-5-davidgow@google.com
>

We're hoping to take this series in via the KUnit tree, so that we can
enable the warning in one place without annoying Linus with lots of
dependencies between PRs.
(See, e.g,. https://lore.kernel.org/linux-kselftest/CAHk-=wgafXXX17eKx9wH_uHg=UgvXkngxGhPcZwhpj7Uz=_0Pw@mail.gmail.com/
)

Would that cause a problem?

Thanks,
-- David

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4014 bytes --]