From: Brijesh Singh <brijesh.singh@amd.com>
To: Borislav Petkov <bp@alien8.de>, Joerg Roedel <jroedel@suse.de>
Cc: brijesh.singh@amd.com, Tom Lendacky <thomas.lendacky@amd.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH -v2] x86/sev: Make the #VC exception stacks part of the default stacks storage
Date: Tue, 5 Oct 2021 15:32:24 -0500 [thread overview]
Message-ID: <ee362ce2-b2cc-026e-3137-c4860becd269@amd.com> (raw)
In-Reply-To: <YVt1IMjIs7pIZTRR@zn.tnic>
On 10/4/21 4:41 PM, Borislav Petkov wrote:
> Yap,
>
> here's v2, now tested. It seems we do need that optional_stack_size
> second arg to ESTACKS_MEMBERS(), thx Tom.
>
> ---
> From: Borislav Petkov <bp@suse.de>
>
> The size of the exception stacks was increased by the commit in Fixes,
> resulting in stack sizes greater than a page in size. The #VC exception
> handling was only mapping the first (bottom) page, resulting in an
> SEV-ES guest failing to boot.
>
> Make the #VC exception stacks part of the default exception stacks
> storage and allocate them with a CONFIG_AMD_MEM_ENCRYPT=y .config. Map
> them only when a SEV-ES guest has been detected.
>
> Rip out the custom VC stacks mapping and storage code.
>
> [ bp: Steal and adapt Tom's commit message. ]
>
> Fixes: 7fae4c24a2b8 ("x86: Increase exception stack sizes")
> Signed-off-by: Borislav Petkov <bp@suse.de>
> ---
Tested-by: Brijesh Singh <brijesh.singh@amd.com>
thanks
next prev parent reply other threads:[~2021-10-05 20:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 4:40 [PATCH] x86/sev: Fully map the #VC exception stacks Tom Lendacky
2021-10-01 4:49 ` Tom Lendacky
2021-10-01 8:57 ` Borislav Petkov
2021-10-01 11:50 ` Joerg Roedel
2021-10-01 12:58 ` Borislav Petkov
2021-10-01 13:00 ` Joerg Roedel
2021-10-01 13:29 ` Peter Zijlstra
2021-10-01 13:52 ` Borislav Petkov
2021-10-01 20:39 ` Borislav Petkov
2021-10-04 15:08 ` [PATCH] x86/sev: Make the #VC exception stacks part of the default stacks storage Borislav Petkov
2021-10-04 21:41 ` [PATCH -v2] " Borislav Petkov
2021-10-05 16:28 ` Tom Lendacky
2021-10-05 20:32 ` Brijesh Singh [this message]
2021-10-06 19:56 ` [tip: x86/core] " tip-bot2 for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee362ce2-b2cc-026e-3137-c4860becd269@amd.com \
--to=brijesh.singh@amd.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox