[irqchip: irq/irqchip-next] irqchip/mchp-eic: Fix return value check in mchp_eic_init()

irqchip-bot for Yang Yingliang
2021-10-25T08:11:56Z

The following commit has been merged into the irq/irqchip-next branch of irqchip:

Commit-ID: 68a6e0c63c76128d403e8ca016c0bcb732ff1b05
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/68a6e0c63c76128d403e8ca016c0bcb732ff1b05
Author: Yang Yingliang <yangyingliang@huawei.com>
AuthorDate: Mon, 25 Oct 2021 13:00:55 +08:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Mon, 25 Oct 2021 09:02:18 +01:00

irqchip/mchp-eic: Fix return value check in mchp_eic_init()

In case of error, the function of_iomap() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20211025050055.1129845-1-yangyingliang@huawei.com
---
drivers/irqchip/irq-mchp-eic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-mchp-eic.c b/drivers/irqchip/irq-mchp-eic.c
index 09b7a8c..c726a19 100644
--- a/drivers/irqchip/irq-mchp-eic.c
+++ b/drivers/irqchip/irq-mchp-eic.c
@@ -209,7 +209,7 @@ static int mchp_eic_init(struct device_node *node, struct device_node *parent)
return -ENOMEM;

eic->base = of_iomap(node, 0);
- if (IS_ERR(eic->base)) {
+ if (!eic->base) {
ret = -ENOMEM;
goto free;
}