public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: lizhe <sensor1010@163.com>
Cc: Jiri Slaby <jirislaby@kernel.org>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 linux-serial <linux-serial@vger.kernel.org>,
	 LKML <linux-kernel@vger.kernel.org>
Subject: Re:Re: [PATCH v6] serial: linflexuart: Remove redundant uart type assignment
Date: Fri, 5 Jan 2024 16:48:17 +0200 (EET)	[thread overview]
Message-ID: <ee52b724-799f-1be5-b455-8e82aba55ee2@linux.intel.com> (raw)
In-Reply-To: <7a49d3a4.1e16.18cd8564671.Coremail.sensor1010@163.com>

[-- Attachment #1: Type: text/plain, Size: 1346 bytes --]

On Fri, 5 Jan 2024, lizhe wrote:

> HI,all
> 
>        How should I wirte these comments ? please help me, 
>        i am not sure how to properly write these comments, 
>        i want to merge this patch into the mainline
> 
> 
> 
> 
> 
> 
> At 2023-01-06 15:16:56, "Jiri Slaby" <jirislaby@kernel.org> wrote:
> >On 05. 01. 23, 18:04, 李哲 wrote:
> >> in linflex_config_port() the member variable type will be
> >> assigned again. see linflex_connfig_port()
> >
> >I wrote to v5:
> >Please use capitals when you start a sentence. And periods at the ends 
> >of them.
> >> Signed-off-by: 李哲 <sensor1010@163.com>
> >
> >
> >> V4 -> V5: Link: https://lore.kernel.org/all/ddcf396b-7b91-00f3-8c16-7de5d
> c891aef@kernel.org/
> >> V3 -> V4: Link: https://lore.kernel.org/all/2f726128-29c-b7dd-ad8-f8b536f
> be5f@linux.intel.com/
> >> V2 -> V3: Link: https://lore.kernel.org/all/8f433e5-fb46-d3b8-431b-4bddcc
> 938f6b@linux.intel.com/
> >> V1 -> V2: Link: https://lore.kernel.org/all/1c33a2af-cd0d-cdde-5bc7-49b41
> 8665784@kernel.org/
> >
> >This is not the proper way. PLease see:
> >https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-
> canonical-patch-format

For this you need to spell out the changes you made between versions.

E.g.,

v6:
- Used Chinese letters for From and Signed-off-by


-- 
 i.

  parent reply	other threads:[~2024-01-05 14:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-05 17:04 [PATCH v6] serial: linflexuart: Remove redundant uart type assignment 李哲
2023-01-06  7:16 ` Jiri Slaby
     [not found]   ` <7a49d3a4.1e16.18cd8564671.Coremail.sensor1010@163.com>
2024-01-05 14:48     ` Ilpo Järvinen [this message]
2023-01-12 20:13 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee52b724-799f-1be5-b455-8e82aba55ee2@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=sensor1010@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox