From: Dave Hansen <dave.hansen@intel.com>
To: "Huang, Ying" <ying.huang@intel.com>,
kernel test robot <oliver.sang@intel.com>,
Rui Zhang <rui.zhang@intel.com>, Chen Yu <yu.c.chen@intel.com>,
Len Brown <len.brown@intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
0day robot <lkp@intel.com>, Yang Shi <shy828301@gmail.com>,
Zi Yan <ziy@nvidia.com>, Michal Hocko <mhocko@suse.com>,
Wei Xu <weixugc@google.com>, Oscar Salvador <osalvador@suse.de>,
David Rientjes <rientjes@google.com>,
Dan Williams <dan.j.williams@intel.com>,
David Hildenbrand <david@redhat.com>,
Greg Thelen <gthelen@google.com>, Keith Busch <kbusch@kernel.org>,
Yang Shi <yang.shi@linux.alibaba.com>,
LKML <linux-kernel@vger.kernel.org>,
lkp@lists.01.org, feng.tang@intel.com,
zhengjun.xing@linux.intel.com, dave.hansen@linux.intel.com,
linux-mm@kvack.org, mm-commits@vger.kernel.org,
torvalds@linux-foundation.org
Subject: Re: [mm/migrate] 9eeb73028c: stress-ng.memhotplug.ops_per_sec -53.8% regression
Date: Sun, 5 Sep 2021 20:57:55 -0700 [thread overview]
Message-ID: <ee55e83e-d8bd-2888-3159-154706aa5173@intel.com> (raw)
In-Reply-To: <87y28aii58.fsf@yhuang6-desk2.ccr.corp.intel.com>
On 9/5/21 6:53 PM, Huang, Ying wrote:
>> in testcase: stress-ng
>> on test machine: 96 threads 2 sockets Intel(R) Xeon(R) Gold 6252 CPU @ 2.10GHz with 192G memory
>> with following parameters:
>>
>> nr_threads: 10%
>> disk: 1HDD
>> testtime: 60s
>> fs: ext4
>> class: os
>> test: memhotplug
>> cpufreq_governor: performance
>> ucode: 0x5003006
>>
> Because we added some operations during online/offline CPU, it's
> expected that the performance of online/offline CPU will decrease. In
> most cases, the performance of CPU hotplug isn't a big problem. But
> then I remembers that the performance of the CPU hotplug may influence
> suspend/resume performance :-(
>
> It appears that it is easy and reasonable to enclose the added
> operations inside #ifdef CONFIG_NUMA. Is this sufficient to restore the
> performance of suspend/resume?
It's "memhotplug", not CPUs, right?
I didn't do was to actively go out and look for changes that would
affect the migration order. The code just does regenerates and writes
the order blindly when it sees any memory hotplug event. I have the
feeling the synchronize_rcu()s are what's killing us.
It would be pretty easy to go and generate the order, but only do the
update and the RCU bits when the order changes from what was there.
I guess we have a motivation now.
next prev parent reply other threads:[~2021-09-06 3:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210902215909.0aWLE2-rh%akpm@linux-foundation.org>
2021-09-05 13:59 ` [mm/migrate] 9eeb73028c: stress-ng.memhotplug.ops_per_sec -53.8% regression kernel test robot
2021-09-06 1:53 ` Huang, Ying
2021-09-06 3:57 ` Dave Hansen [this message]
2021-09-06 5:57 ` Huang, Ying
2021-09-06 6:09 ` Chen Yu
2021-09-06 8:31 ` Huang, Ying
2021-09-17 3:14 ` Huang, Ying
2021-10-21 14:29 ` Oliver Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee55e83e-d8bd-2888-3159-154706aa5173@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=feng.tang@intel.com \
--cc=gthelen@google.com \
--cc=kbusch@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=lkp@lists.01.org \
--cc=mhocko@suse.com \
--cc=mm-commits@vger.kernel.org \
--cc=oliver.sang@intel.com \
--cc=osalvador@suse.de \
--cc=rafael.j.wysocki@intel.com \
--cc=rientjes@google.com \
--cc=rui.zhang@intel.com \
--cc=shy828301@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=weixugc@google.com \
--cc=yang.shi@linux.alibaba.com \
--cc=ying.huang@intel.com \
--cc=yu.c.chen@intel.com \
--cc=zhengjun.xing@linux.intel.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox