From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89DD32D77E6 for ; Thu, 7 May 2026 15:37:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778168246; cv=none; b=WYHJRzPqeCzeZiO7zrFRuhDxrNsMpDF+4NFYVCLfD/BDIQe3wU5Kn/6enZkvm9Mjy85+VA0EqzhMPHROeXiYC3ATcDi7+kAb42d/bW0uOe5G1VEJ331cYrBnYrKhKxhMKD14NhAuzZPw4bF8gFGyw5gEWp2S3SGJdFF8Lv1hiWA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778168246; c=relaxed/simple; bh=ZQH6n2Zn6sFPllhmYGCWJhHf3MuQBf8ZVrL+C+SGiRw=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=oJa+qU/p8MamAfp3vBuobPdIR/tjp2hTrbSHTnNJXuE0C1gWTbsXkEW36VoW49kM6VQrq/vCRg8OhZb+CWdD2vqGytILm1/ny0HcyuwuQs+Zd9dYpCc92PH7Y81ZhuoiwNoO7dqMgx52k6lRXLptGte6T5w5f0mNPFZl9z5HHcc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=BIDz4A4l; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BIDz4A4l" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-44a74032ff8so792639f8f.1 for ; Thu, 07 May 2026 08:37:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778168243; x=1778773043; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=FR5wZFgikhLRQ2djaH08NzpUj2HNfqrfQYUASHjPXMA=; b=BIDz4A4lcECxyaOiZ+dAwwH8m09Doxc5GVfckORzI4AdI0OySUdjWRda9nyHiQ3Fu6 f3Tj8aYIWMQCOo94u/uLLXbCD/7EJX63fGVAvk41QWsp5IFZPOIAdzTAwqSmYY0pwreG tAHhxDC7Qcc7rDSWkzXgt96ujPkhLa+Ut79+orI1do44a4pXum7STTVuORWAodA377NQ Pqm2FNXj4n6tcvH6+pIqGflXhCm94meCnwBd7b3ynPlDX2CKXZHEKG7Jb2wTvhg2NFnY GMh125gtPuRFpnnWfB0nX8uZYpavSKnu3TTUeLDv5J+F2zGF/Po/c7O70eZRloPJaFsE Mw7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778168243; x=1778773043; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FR5wZFgikhLRQ2djaH08NzpUj2HNfqrfQYUASHjPXMA=; b=JhWQJFq1T9+C8T1KC5WVbvsVA8KDGYQSIsRzUIbRrt5w8xhIP8T+Nk9ITUeEtLyBVp 58/wbtZTGGZAHIlMRxDjDflR2AO4BG0+ZFK/vOARIhW4lD9XdJogeOV6KvNQUwV93WG7 CaBIEC1p8l2qcT9RNbbKdR6qJZzw/ZN46TU+wgtdBHuVDKMKXcFu+MciizPsCCcY4Cb4 0QSc1jzNuzUtzllkNRD536f3X7FXvzyR+wyWpRnrmCmpbWS1E66G1um4nYqiU3dLwuA0 wqwxEFlEmkaVV+hFUCnKgddctdWWZobA1M1+c+KlhoK1NVRAgTnqVD8vLVtxKWDv4Hse QwBA== X-Forwarded-Encrypted: i=1; AFNElJ/ZAjVGpuTWo0tR3JYlSI48LfndLawfZjsjKm5SPK4EJykUtZJ+90KEVdQLG1GKw1OoeyR9BSvHMazeJgo=@vger.kernel.org X-Gm-Message-State: AOJu0YwtxautVH/Rcshhhut+0JBm97y62UHYnOOzlGuP/TPd06CPOxLO uIp0JvA+CtLgsPpGs5MtgkrjdClLfnsNHZ3XPSKUeZKc+FUxElqG/Q8x9uLuHg1h+sE= X-Gm-Gg: AeBDieuyasJ1z1qzH2JI4U0gA4nAdtVcBHS9PWuUynKfsYruFJ6ElnmNa2JCNwu2UEY X0Trej5gCILfOMkSdW5bGVv3RVxSmliSOseUDBkGtlJ9wiWrbjG/T7LAbbnIOcikId42h0h/LRp l2VJLmhcYGt4cMecDAI2MNRdIQYkNiXdMgSPb6/3hXXPasqgmKKhPu60fPpHcMfl33l4FkFQHUu nmoA3szaxfgnsO9c+j/LgWolN8k02tv66YGqvNZAfbNbyywaRIRafOJpfqc7AL2sB7DJKVGhSx6 2rUMhrfX+Vh3RMbVixTeaWPCkSrzhy5OvUPnDMrwvgSIeqEoltnljfqAybcrCRcgCMPOEEmYDN3 ItPkfPpMyW1PrMH7gQ+CyoP1w4Pys1fUibKL0RNDaKpJYMzmEZ9BjZK8wyMq9vK69aawPg5KUHA 2UbLcgOpFtjNJcqby2pu2wwQcq4LT7mymDyxI8PpmfgPhB8oNBg81VZon9gOf8q/t/mtu+hCZYx 9FP6/L0h43aqL8keA== X-Received: by 2002:a05:6000:2c01:b0:43e:a72e:ec5a with SMTP id ffacd0b85a97d-4515ce1c804mr13704951f8f.20.1778168242629; Thu, 07 May 2026 08:37:22 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:6762:47bb:1e06:ff70? ([2a01:e0a:106d:1080:6762:47bb:1e06:ff70]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45055960902sm23025743f8f.28.2026.05.07.08.37.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2026 08:37:21 -0700 (PDT) Message-ID: Date: Thu, 7 May 2026 17:37:21 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH 09/10] drm/panel/startek-kd070fhfid015: Use refcounted allocation in place of devm_kzalloc() To: Albert Esteve , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Michael Tretter , Michael Walle , Dario Binacchi Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260507-drm_panel_init_rm-v1-0-51f448c7c291@redhat.com> <20260507-drm_panel_init_rm-v1-9-51f448c7c291@redhat.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260507-drm_panel_init_rm-v1-9-51f448c7c291@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/7/26 13:53, Albert Esteve wrote: > Move to using the new API devm_drm_panel_alloc() to allocate the > panel. In the call to the new API, avoid using explicit type and use > __typeof() for more type safety. > > Signed-off-by: Albert Esteve > --- > drivers/gpu/drm/panel/panel-startek-kd070fhfid015.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-startek-kd070fhfid015.c b/drivers/gpu/drm/panel/panel-startek-kd070fhfid015.c > index c0c95355b7435..7f04b7b404e7d 100644 > --- a/drivers/gpu/drm/panel/panel-startek-kd070fhfid015.c > +++ b/drivers/gpu/drm/panel/panel-startek-kd070fhfid015.c > @@ -286,9 +286,6 @@ static int stk_panel_add(struct stk_panel *stk) > return ret; > } > > - drm_panel_init(&stk->base, &stk->dsi->dev, &stk_panel_funcs, > - DRM_MODE_CONNECTOR_DSI); > - > drm_panel_add(&stk->base); > > return 0; > @@ -303,9 +300,12 @@ static int stk_panel_probe(struct mipi_dsi_device *dsi) > dsi->format = MIPI_DSI_FMT_RGB888; > dsi->mode_flags = (MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_LPM); > > - stk = devm_kzalloc(&dsi->dev, sizeof(*stk), GFP_KERNEL); > - if (!stk) > - return -ENOMEM; > + stk = devm_drm_panel_alloc(&dsi->dev, __typeof(*stk), base, > + &stk_panel_funcs, > + DRM_MODE_CONNECTOR_DSI); > + > + if (IS_ERR(stk)) > + return PTR_ERR(stk); > > mipi_dsi_set_drvdata(dsi, stk); > > Reviewed-by: Neil Armstrong Thanks, Neil