From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF8921391 for ; Sun, 15 Feb 2026 16:16:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771172214; cv=none; b=A6H3xTkspCSDrymxVw2IEsgvNawuIR5DKgnH+pk0Qq8q+s/x0Ukq6htYrIDHo+g6huT/O5PmCNoqyWovAt6XLWIJXaU14KYzxNu2LOhOTMWGsHaefbb28Z5gnM4QsaVb9g3iCypevRVNCQnoLHq3BHxSc+Q7bKo2p97tLNnDbSk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771172214; c=relaxed/simple; bh=QkftsrPYieFk9d+UCflvzlWm6/5nK+3y4WbIIuVt1C0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CJ1fami2irU/51ve1SWy1/z1blPf05ed7yL5TUtZZRhOty6eHLhCi+JtetrXgKcmjMx1qvFuMnqwBECWCn/N1cpV81NrIshk2XndJrEqO5kP8pQzaYjabe4gr3l1EX0y+JAQLGMpsnq332nrSLfMFuHa9VyklcdEhY18g9YcDaQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ODlXG0Ad; arc=none smtp.client-ip=209.85.128.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ODlXG0Ad" Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-7927261a3acso21054727b3.0 for ; Sun, 15 Feb 2026 08:16:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771172212; x=1771777012; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0MzbHaBcl2BA9jnP7VQLQ7usDren2db0/Uzo8UfIv1Y=; b=ODlXG0AdjtizbMudBbgltHy8QNPfO4yVR4s3wvfqsVfqK1KIEoakV9yihdFrSx7Cf3 92woa7QdDoAQz6qzpZDs10fTP7hIIMG/eBZXZuTO5xb0HD/YIG8JkEdZWuPfvPILOVSz 4h8CLwpqjWyKH12PsqGcDQIs+/+uwMmKSa4IDwPlZIoTxQSBmnbFtJZCwz+ZEXgxvZuh WdgxsTl4KmvJP7ygFO3p8j64Pf09gFNqFiaxC22iBAvEWihNVbB2A+vZv9WP1c6tiqbD hwtF0IZi+9+HZXMmAUS47LLIZxzTZ8yh7tP1KIZmbg+D0qVV8gXbya9StW4VO3pCoSUR Kbqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771172212; x=1771777012; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0MzbHaBcl2BA9jnP7VQLQ7usDren2db0/Uzo8UfIv1Y=; b=p8647EgGtrBiS3A3bmfipu6n88vW9jM4mzHjdVwJJIiolKHZlfAYiqzMzqyLn3AHD7 0YK8O3xRX4hlLLK30JdVL26yrDRRMyz7HFVleU76St13LFKrDZuhK1BQhhCpPjJtwg+0 hqYgP6UW9EuoRwcusJcuUqdKQNHkZRdBE09mz+tlRFLQvG7dueNA1716OZWJQGvQrRgE ijcKZK7M1FVw7adqiOq3JunxRAZUaGCmhdRMQyIA7xWWg1bbg2ppcAX+Sn43pqU7Ham7 mPANBoPYfONYdq4kg7CGpv8ZCm7/q7uRG+ZnOU/SxndSl/oENYqsWbAowTmSy894PTee I+kw== X-Forwarded-Encrypted: i=1; AJvYcCUftXhMZfR6CJbFMtkdrVgcbi7DENQN11zs+wp40yWkHtcPaGduBj0o8zXG7g2NegroJO7Xp4s5CDLO0uU=@vger.kernel.org X-Gm-Message-State: AOJu0YzlJL5GQJtJBeDm/v8SwJ0T3UAPaYslrc8LI60wfUwe7R7jAgyh +VFCXxLPMEBrCeXO+NpEmhK4sGTbez2tCd/0KoPIzs5sgZ/60nesFHGabW+0/w== X-Gm-Gg: AZuq6aI5tPyqvG3we4ufSwxJ3C6/yGyEYfQrdZBR15tPJZf/LDO3oL5pt4PmApzSSWb 1T9pk8fYiYhwR2tt6J4Uv8KzkECoY84C2XTeF3gOTwL7IglxzzgwEwPvFIv6fE+kjwBVEAl3NF1 ycFKqkMvtZVRgXkk/jUTZy0CwcOSM65DRB6BALwPo/ZruEXNfLSP9yJ7u871rtNR0hk9hlKdRuk k0Pd/+U0oBfIs+/Dnas2UTquf/iYVUuh5a3j0+31/wir/BSJcNmSAfgRskbJ+vYDCl30moCzh+O z30BvIj7e8EiY1ESM4xAR+1dKbNVy0x6M6fhp4DJEquY05o6iIPDQlOMw+dTOEn64y7bif1aQbM Z2LktyOnI/7mbkVPZCjXo/5Odbt+qdy/sfsvK8C3wyMLX3syqPEjBiEBeSawLzwd3qIndpAfab7 sN7WX0LmCYYyLq5dDhYdUKUf/Ymw== X-Received: by 2002:a05:690c:ed6:b0:796:37bb:9eaf with SMTP id 00721157ae682-797ac4ddaa0mr37247267b3.7.1771172211823; Sun, 15 Feb 2026 08:16:51 -0800 (PST) Received: from [192.168.0.40] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c267f40sm90580437b3.52.2026.02.15.08.16.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 Feb 2026 08:16:51 -0800 (PST) Message-ID: Date: Sun, 15 Feb 2026 18:16:45 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/2] dt-bindings: iio: light: vcnl4000: add Capella CM36686 and CM36672P To: David Lechner , Krzysztof Kozlowski Cc: Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20260212-cm36686-v4-0-8f587d4a72bf@gmail.com> <20260212-cm36686-v4-1-8f587d4a72bf@gmail.com> <20260213-unyielding-pistachio-ape-deda74@quoll> <3a20c906-647c-458f-a118-c7927495e7ef@gmail.com> <8fb27a7a-82dc-443b-bcc4-21007783fc54@kernel.org> <880ddcad-a92e-43bb-ad5c-d6f2f353d182@baylibre.com> From: Erikas Bitovtas Content-Language: en-US In-Reply-To: <880ddcad-a92e-43bb-ad5c-d6f2f353d182@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/14/26 6:44 PM, David Lechner wrote: > On 2/13/26 2:56 AM, Erikas Bitovtas wrote: >> >> >> On 2/13/26 10:51 AM, Krzysztof Kozlowski wrote: >>> On 13/02/2026 09:29, Erikas Bitovtas wrote: >>>>>> Signed-off-by: Erikas Bitovtas >>>>>> --- >>>>>> .../devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 17 +++++++++++------ >>>>>> 1 file changed, 11 insertions(+), 6 deletions(-) >>>>>> >>>>>> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml >>>>>> index 4d1a225e8868..2ba4d5de4ec4 100644 >>>>>> --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml >>>>>> +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml >>>>>> @@ -18,12 +18,17 @@ allOf: >>>>>> >>>>>> properties: >>>>>> compatible: >>>>>> - enum: >>>>>> - - vishay,vcnl4000 >>>>>> - - vishay,vcnl4010 >>>>>> - - vishay,vcnl4020 >>>>>> - - vishay,vcnl4040 >>>>>> - - vishay,vcnl4200 >>>>>> + oneOf: >>>>>> + - enum: >>>>>> + - capella,cm36672p >>>>> >>>>> CM36672P is compatible with CM36686, but this is not expressed. >>>>> Confusing commit msg and code. >>>> >>>> For CM36672P we create a dedicated compatible because it is a >>>> proximity-only sensor which has the same proximity sensor configuration, >>>> but ambient light sensor registers are missing (reserved). >>> >>> I don't understand this. You just wrote "fully compatible with CM36686" >>> and now you imply that not. >>> >>> Decide. >>> >> It is not. CM36672P supports only a subset of CM36686 features, in >> particular the proximity sensor. That is what I meant initially. >> I am sorry if the previous phrasing caused any confusion. > > But CM36686 is fully compatible with CM36672P, right? > > So this would make sense? > > - items: > - const: capella,cm36686 > - const: vishay,vcnl4040 > - const: capella,cm36686p > > If you try to use CM36686 compatible for CM36672P, proximity channels will work, but in_illuminance_raw will return 0 and changing illuminance parameters will have no effect. That is because CM36672P is a proximity sensor only and the register fields for ambient light are reserved. And if you try to use CM36672P compatible with CM36686, it will work, but only proximity channel will be available, even though CM36686 also can sense light.