From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E478E3FFAA2 for ; Mon, 15 Jun 2026 15:01:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781535671; cv=none; b=b9P7nmqSiyilm/ulFW+ehRnEWe/y5/QCN5QdW+b9DxP3POC5LKnkhYlImzG21g+Ocdu1VaHf7a8vS4T65fr0stq459R7hlKTeAL2qpWsLqCNp7Ple4XvWTekfgQQFvKR5L6llg7hNkwo0yyOH8x8AHD5gxt9145lr2eOATh5fek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781535671; c=relaxed/simple; bh=/9k6sT4MtrkT6HKWvvkUyJQlITanHuZy5nOkg8tNSqs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JtvrzNjK7ijQD6WnJcsyz6oj8HS1NGGG1dNekytDU2kJHmMJ1Vlccesl4DsN5D0ErJafMz2JteSOWfH6X1/xjw3RRn7BXwz7tqT82nx0AnoTaqyQ+RLOcY7RydboprWJupQQWPeTCai2gDGkLEeGbqzD2X54ZJkzAE5e+YV8eec= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qYTKn/oT; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qYTKn/oT" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-490ac10e337so24051755e9.3 for ; Mon, 15 Jun 2026 08:01:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781535667; x=1782140467; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=khnpdZ2IamFmJh+fpxC56x6GA1zuKN5sdVLEGs525B8=; b=qYTKn/oT4I+IpLaxpqlQn9eQX99VzRNenvy81z5MqVSTo1toWHm9StrH4ElHSnsQRH X0E6HCJxYDCa9y/PeOQTO0A+H+g7blVwLVCnHj94HjWT6ytsAPiG4n11D1wNRR4mU8pP KcSWe0IGQhsAXcd8T7hfXuLvMZNVt4YMwedQBvMrMzQR/hGM73p6KlG9hIdT1UlgT4bc A1PNwuQg0p9Qr4jLyLMfLUvSd0XFfTaUJXUWQzceOiPk9C+NLqltJI02zc1vmXZUan2M gMshcDQy7UAeks9uq0ctMSB3+yqRXqPg+dXNo49hNqplig9t0+HCPtSovhnGQLOgBEFb 5zmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781535667; x=1782140467; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=khnpdZ2IamFmJh+fpxC56x6GA1zuKN5sdVLEGs525B8=; b=b6Hkkx5USaEE5V69E9hiZIyIuUausLYEIo98506WOU/Unlq2XlHIrntENoYwtlgSyu 8ZVSomv/Hk8IfBpYEoxzOcZrLibcgXp+1YyyYawGJ5b4CvWPrn3x8dhqBntuEMeFPMM8 rRPPGjB458Db9hzcth1ndNQwosVpj4sm0zPCrfAjXD0xDmlzM2yXWQZgYVhrnf2lyVXN NYmOf5obTmKuqIFipGxWSuyJOTxDXcIWQMENoPJitpZ/4Evbapg8bupRk4yC2C5J04mB eHsptEdym8+jeHWtTHKEeCZBFZliNlYw8eTWMS0bxDKmGnu9oTLbz1XMBceqwQpw0qN7 LF7Q== X-Forwarded-Encrypted: i=1; AFNElJ/nyqMMeQUVhHJrcd7XNpFisFobohTftlUW27GQ9ZIU90oE6COQ2wwvw4LOV/U5gk+0bsNqWPYklS1JbA0=@vger.kernel.org X-Gm-Message-State: AOJu0Yxd8yQtzMr2nHpi7xXYBFHZvmHYASCdEofdPqVaNKedXYU2nwz6 gryQvuwAyf3hneCKV0gvLbE7qkbmM76rjsMisf5Gg667F4IokPOFZrTz X-Gm-Gg: Acq92OGRoQ8Q8wrdFKh2UBWeNa1pLqWiylDOFg/JDUA13766+kwkWtz3ZzPmYB7VoW5 6elofKh1DTeOhd8l2Hxn+LixYDtH6RFe0KbTeKo9qyrajgLk4K1dliO+7N+jzmwZjoLqusOwvWr nDU3l7+vxcV3rgH83L63/gKaNMHbbD885vriFJfek2nIrFOqCj7rAR6bzeIhb8pguey+I+hnqaT kRq+hvF0TJi4L0q79QMyoKGREFmtFD+Mhoh719RApG6TDrXPJLjhvauMS64AyOhTUsnn6v4k0BT Ex56gqKOSnocIHNCac9dK71u00c6tv9nxQ00hvsTt5UUDy0B3gd8xPHxX5sOfZAAldqLnSY6DQF DOpSMI2OXTRXb+rAngr3GxwEQRhCMmR1/AUPf2EA8cTcplOlKdbK4069I3TYGP5i+PGqebSLDDQ O4ef+S/qbjXpBbyhxWJRoK3bZvW3UHP4Jb/DiIXsLYxV0ABaKkD5/MhrzYbc27tZO84qOxwu90v DD+MBazBdGydqOUbueT1lkoEzLN2Q== X-Received: by 2002:a05:600c:c0c3:10b0:490:b724:dbd6 with SMTP id 5b1f17b1804b1-4922005087emr113879755e9.6.1781535666481; Mon, 15 Jun 2026 08:01:06 -0700 (PDT) Received: from [10.128.10.215] (195-23-151-163.net.novis.pt. [195.23.151.163]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4619a041986sm11773154f8f.23.2026.06.15.08.01.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2026 08:01:05 -0700 (PDT) Sender: Julian Braha Message-ID: Date: Mon, 15 Jun 2026 16:01:04 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RESEND PATCH v1] net: dsa: motorcomm: add yt92xx dsa driver To: Kyle Switch , mmyangfl@gmail.com, andrew@lunn.ch, olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: ming.xu@motor-comm.com, xiaolin.xu@motor-comm.com, jianmin.wang@motor-comm.com, de.ge@motor-comm.com References: <20260615111235.3544282-1-kyle.switch@motor-comm.com> Content-Language: en-US From: Julian Braha In-Reply-To: <20260615111235.3544282-1-kyle.switch@motor-comm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Kyle, On 6/15/26 12:12, Kyle Switch wrote: > diff --git a/drivers/net/dsa/motorcomm/Kconfig b/drivers/net/dsa/motorcomm/Kconfig > new file mode 100644 > index 000000000000..f40d75e2a3f2 > --- /dev/null > +++ b/drivers/net/dsa/motorcomm/Kconfig > @@ -0,0 +1,30 @@ > +# SPDX-License-Identifier: GPL-2.0-only > + > +config MOTORCOMM > + tristate "Motorcomm YT92XX switch family support" > + depends on NET_DSA > + select FIXED_PHY > + help > + This driver adds support for Motorcomm switch chips. It supports > + YT921X and YT922X switch. > + > +choice > + prompt "Motorcomm switch series selection" > + depends on MOTORCOMM > + > +config MOTORCOMM_YT921X > + bool "Motorcomm YT921X series." > + > +config MOTORCOMM_YT922X > + bool "Motorcomm YT922X series." > +endchoice > + > +config NET_DSA_MOTORCOMM > + tristate "Motorcomm YT92XX switch DSA driver" > + depends on MOTORCOMM > + depends on (MOTORCOMM_YT921X || MOTORCOMM_YT922X) > + select NET_DSA_TAG_MOTORCOMM > + select NET_IEEE8021Q_HELPERS if DCB > + help > + Select to enable support for Motorcomm driver. > + > diff --git a/drivers/net/dsa/motorcomm/Makefile b/drivers/net/dsa/motorcomm/Makefile NET_DSA_MOTORCOMM already depends on: (MOTORCOMM_YT921X || MOTORCOMM_YT922X) with both of those options depending on MOTORCOMM due to the 'choice' that they're in, so this additional dependency on MOTORCOMM is unnecessary. You could also consider using a comment to document that this option is depended on indirectly. - Julian Braha