From: Krzysztof Kozlowski <krzk@kernel.org>
To: Puma Hsu <pumahsu@google.com>,
mathias.nyman@intel.com, gregkh@linuxfoundation.org,
Thinh.Nguyen@synopsys.com
Cc: badhri@google.com, royluo@google.com, howardyen@google.com,
albertccwang@google.com, raychi@google.com,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: usb: Add xhci glue driver support
Date: Mon, 19 Feb 2024 13:18:12 +0100 [thread overview]
Message-ID: <eeb97fc2-326c-4d0c-97a8-7973e95f8047@kernel.org> (raw)
In-Reply-To: <20240219061008.1761102-2-pumahsu@google.com>
On 19/02/2024 07:10, Puma Hsu wrote:
> Currently the dwc3 driver always probes xhci-plat driver
Not a DT property, at least at first glance. NAK.
> by hardcode in driver. Introduce a property to make this
> flexible that a user can probe a xhci glue driver by the
> generic dwc3 driver.
>
> Signed-off-by: Puma Hsu <pumahsu@google.com>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline), work on fork of kernel
(don't, instead use mainline) or you ignore some maintainers (really
don't). Just use b4 and everything should be fine, although remember
about `b4 prep --auto-to-cc` if you added new patches to the patchset.
You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time, thus I will skip this patch entirely till you follow
the process allowing the patch to be tested.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-02-19 12:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 6:10 [PATCH 0/3] usb: xhci: Add support for Google XHCI controller Puma Hsu
2024-02-19 6:10 ` [PATCH 1/3] dt-bindings: usb: Add xhci glue driver support Puma Hsu
2024-02-19 12:18 ` Krzysztof Kozlowski [this message]
2024-02-19 6:10 ` [PATCH 2/3] usb: xhci: Add support for Google XHCI controller Puma Hsu
2024-02-19 6:30 ` Greg KH
2024-02-21 9:22 ` Puma Hsu
2024-02-19 12:21 ` Krzysztof Kozlowski
2024-02-21 9:31 ` Puma Hsu
2024-02-21 9:52 ` Krzysztof Kozlowski
2024-02-22 9:45 ` Puma Hsu
2024-02-19 6:10 ` [PATCH 3/3] MAINTAINERS: Add maintainer for Google USB XHCI driver Puma Hsu
2024-02-19 6:31 ` Greg KH
2024-02-19 8:35 ` Puma Hsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eeb97fc2-326c-4d0c-97a8-7973e95f8047@kernel.org \
--to=krzk@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=albertccwang@google.com \
--cc=badhri@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=howardyen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=pumahsu@google.com \
--cc=raychi@google.com \
--cc=royluo@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox