From: Krzysztof Kozlowski <krzk@kernel.org>
To: Cheng Jiang <quic_chejiang@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_jiaymao@quicinc.com,
quic_shuaz@quicinc.com, quic_zijuhu@quicinc.com,
quic_mohamull@quicinc.com
Subject: Re: [PATCH v1 1/1] arm64: dts: qcom: qcs8300-ride: enable BT on qcs8300-ride
Date: Tue, 11 Feb 2025 12:03:36 +0100 [thread overview]
Message-ID: <eebcc0e7-4f87-45d5-8ad4-9d24145ef5b2@kernel.org> (raw)
In-Reply-To: <20250211104421.1172892-2-quic_chejiang@quicinc.com>
On 11/02/2025 11:44, Cheng Jiang wrote:
> };
> };
>
> +&uart2 {
> + status = "okay";
> + bluetooth: bluetooth {
Why do you need the label?
> + compatible = "qcom,wcn6855-bt";
> + firmware-name = "QCA6698/hpnv21", "QCA6698/hpbtfw21.tlv";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&bt_en_state>;
> + enable-gpios = <&tlmm 55 GPIO_ACTIVE_HIGH>; /* BT_EN */
> +
> + vddio-supply = <&vreg_conn_pa>; /* bt-vdd-ctrl1-supply */
> + vddbtcxmx-supply = <&vreg_conn_1p8>; /* bt-vdd-ctrl2-supply */
Only one space before '='.
I think this has multiple test failures.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-11 11:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 10:44 [PATCH v1 0/1] Enable BT for qcs8300-ride Cheng Jiang
2025-02-11 10:44 ` [PATCH v1 1/1] arm64: dts: qcom: qcs8300-ride: enable BT on qcs8300-ride Cheng Jiang
2025-02-11 11:03 ` Krzysztof Kozlowski [this message]
2025-02-13 5:56 ` Cheng Jiang
2025-02-13 7:36 ` Krzysztof Kozlowski
2025-02-13 10:35 ` Cheng Jiang
2025-02-11 14:34 ` Konrad Dybcio
2025-02-13 5:59 ` Cheng Jiang
2025-03-26 16:24 ` Dmitry Baryshkov
2025-02-11 11:01 ` [PATCH v1 0/1] Enable BT for qcs8300-ride Krzysztof Kozlowski
2025-02-13 6:04 ` Cheng Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eebcc0e7-4f87-45d5-8ad4-9d24145ef5b2@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_chejiang@quicinc.com \
--cc=quic_jiaymao@quicinc.com \
--cc=quic_mohamull@quicinc.com \
--cc=quic_shuaz@quicinc.com \
--cc=quic_zijuhu@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox