From: Jocelyn Falempe <jfalempe@redhat.com>
To: "Miguel Ojeda" <ojeda@kernel.org>,
"Thomas Böhler" <witcher@wiredspace.de>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Alex Gaynor" <alex.gaynor@gmail.com>
Cc: dri-devel@lists.freedesktop.org,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@lists.linux.dev
Subject: Re: [PATCH 2/2] drm/panic: fix overindented list items in documentation
Date: Mon, 3 Mar 2025 10:41:40 +0100 [thread overview]
Message-ID: <eecf227f-8f79-4572-95ae-7370f907579d@redhat.com> (raw)
In-Reply-To: <20250301231602.917580-2-ojeda@kernel.org>
On 02/03/2025 00:16, Miguel Ojeda wrote:
> Starting with the upcoming Rust 1.86.0 (to be released 2025-04-03),
> Clippy warns:
>
> error: doc list item overindented
> --> drivers/gpu/drm/drm_panic_qr.rs:914:5
> |
> 914 | /// will be encoded as binary segment, otherwise it will be encoded
> | ^^^ help: try using ` ` (2 spaces)
> |
> = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items
>
> The overindentation is slightly hard to notice, since all the items
> start with a backquote that makes it look OK, but it is there.
>
> Thus fix it.
Thanks, it looks good to me.
Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
>
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
> ---
> drivers/gpu/drm/drm_panic_qr.rs | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_panic_qr.rs b/drivers/gpu/drm/drm_panic_qr.rs
> index 8bb5e52d75cc..6903e2010cb9 100644
> --- a/drivers/gpu/drm/drm_panic_qr.rs
> +++ b/drivers/gpu/drm/drm_panic_qr.rs
> @@ -911,16 +911,16 @@ fn draw_all(&mut self, data: impl Iterator<Item = u8>) {
> ///
> /// * `url`: The base URL of the QR code. It will be encoded as Binary segment.
> /// * `data`: A pointer to the binary data, to be encoded. if URL is NULL, it
> -/// will be encoded as binary segment, otherwise it will be encoded
> -/// efficiently as a numeric segment, and appended to the URL.
> +/// will be encoded as binary segment, otherwise it will be encoded
> +/// efficiently as a numeric segment, and appended to the URL.
> /// * `data_len`: Length of the data, that needs to be encoded, must be less
> -/// than data_size.
> +/// than data_size.
> /// * `data_size`: Size of data buffer, it should be at least 4071 bytes to hold
> -/// a V40 QR code. It will then be overwritten with the QR code image.
> +/// a V40 QR code. It will then be overwritten with the QR code image.
> /// * `tmp`: A temporary buffer that the QR code encoder will use, to write the
> -/// segments and ECC.
> +/// segments and ECC.
> /// * `tmp_size`: Size of the temporary buffer, it must be at least 3706 bytes
> -/// long for V40.
> +/// long for V40.
> ///
> /// # Safety
> ///
next prev parent reply other threads:[~2025-03-03 9:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-01 23:16 [PATCH 1/2] drm/panic: use `div_ceil` to clean Clippy warning Miguel Ojeda
2025-03-01 23:16 ` [PATCH 2/2] drm/panic: fix overindented list items in documentation Miguel Ojeda
2025-03-02 6:54 ` Miguel Ojeda
2025-03-02 16:50 ` Jarkko Sakkinen
2025-03-02 17:45 ` Miguel Ojeda
2025-03-02 18:31 ` Jarkko Sakkinen
2025-03-02 19:52 ` Miguel Ojeda
2025-03-03 8:04 ` Alice Ryhl
2025-03-03 9:41 ` Jocelyn Falempe [this message]
2025-03-02 6:54 ` [PATCH 1/2] drm/panic: use `div_ceil` to clean Clippy warning Miguel Ojeda
2025-03-03 8:05 ` Alice Ryhl
2025-03-03 9:40 ` Jocelyn Falempe
2025-03-10 7:49 ` Jocelyn Falempe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eecf227f-8f79-4572-95ae-7370f907579d@redhat.com \
--to=jfalempe@redhat.com \
--cc=a.hindborg@kernel.org \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=ojeda@kernel.org \
--cc=patches@lists.linux.dev \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=tzimmermann@suse.de \
--cc=witcher@wiredspace.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox