From: "Guilherme G. Piccoli" <gpiccoli@canonical.com>
To: Vlastimil Babka <vbabka@suse.cz>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Cc: linux-doc@vger.kernel.org, mcgrof@kernel.org,
keescook@chromium.org, yzaikin@google.com, tglx@linutronix.de,
penguin-kernel@I-love.SAKURA.ne.jp, akpm@linux-foundation.org,
cocci@systeme.lip6.fr, linux-api@vger.kernel.org,
kernel@gpiccoli.net, randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH V2] kernel/hung_task.c: Introduce sysctl to print all traces when a hung task is detected
Date: Tue, 24 Mar 2020 09:45:40 -0300 [thread overview]
Message-ID: <eee335a2-e673-39bf-ae64-e49c66f74255@canonical.com> (raw)
In-Reply-To: <b73a6519-0529-e36f-fac5-e4b638ceb3cf@suse.cz>
On 24/03/2020 05:27, Vlastimil Babka wrote:
> [...]
> Before adding a new thing as both kernel parameter and sysctl, could we perhaps
> not add the kernel parameter, in favor of the generic sysctl parameter solution?
> [1] There were no objections and some support from Kees, so I will try to send a
> new version ASAP that will work properly with all "static" sysctls - we don't
> need to be blocked by a full solution for dynamically registered sysctls yet, I
> guess?
>
> Thanks,
> Vlastimil
>
> [1] https://lore.kernel.org/linux-api/20200317132105.24555-1-vbabka@suse.cz/
>
Thanks Randy and Vlastimil for the comments. I really liked your
approach Vlastimil, I agree that we have no reason to not have a generic
sysctl setting via cmdline mechanism - I'll rework this patch removing
the kernel parameter (same for other patch I just submitted).
If you can CC me on the new iterations of the generic sysctl patches
Vlastimil, I appreciate - I can maybe test that, I'd like to see it in
kernel.
Thanks,
Guilherme
next prev parent reply other threads:[~2020-03-24 12:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 21:46 [PATCH V2] kernel/hung_task.c: Introduce sysctl to print all traces when a hung task is detected Guilherme G. Piccoli
2020-03-23 21:51 ` Kees Cook
2020-03-23 23:39 ` Randy Dunlap
2020-03-24 8:27 ` Vlastimil Babka
2020-03-24 12:45 ` Guilherme G. Piccoli [this message]
2020-03-24 18:20 ` Kees Cook
2020-03-25 9:33 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eee335a2-e673-39bf-ae64-e49c66f74255@canonical.com \
--to=gpiccoli@canonical.com \
--cc=akpm@linux-foundation.org \
--cc=cocci@systeme.lip6.fr \
--cc=keescook@chromium.org \
--cc=kernel@gpiccoli.net \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox