From: Roger Quadros <rogerq@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] mtd: onenand: omap2: add dependency on GPMC
Date: Mon, 7 Nov 2022 10:44:56 +0200 [thread overview]
Message-ID: <eef60a26-ef23-1b79-22f7-adaee3be9360@kernel.org> (raw)
In-Reply-To: <20221104194934.384371-1-krzysztof.kozlowski@linaro.org>
Hello Krzysztof,
On 04/11/2022 21:49, Krzysztof Kozlowski wrote:
> OMAP2 OneNAND driver uses gpmc_omap_onenand_set_timings() provided by
> OMAP GPMC driver, so the latter cannot be module if OneNAND driver is
> built-in:
>
> /usr/bin/arm-linux-gnueabi-ld: drivers/mtd/nand/onenand/onenand_omap2.o: in function `omap2_onenand_probe':
> onenand_omap2.c:(.text+0x520): undefined reference to `gpmc_omap_onenand_set_timings'
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 854fd9209b20 ("memory: omap-gpmc: Allow building as a module")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> drivers/mtd/nand/onenand/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/onenand/Kconfig b/drivers/mtd/nand/onenand/Kconfig
> index 34d9a7a82ad4..fa94c514626d 100644
> --- a/drivers/mtd/nand/onenand/Kconfig
> +++ b/drivers/mtd/nand/onenand/Kconfig
> @@ -26,6 +26,7 @@ config MTD_ONENAND_OMAP2
> tristate "OneNAND on OMAP2/OMAP3 support"
> depends on ARCH_OMAP2 || ARCH_OMAP3 || (COMPILE_TEST && ARM)
> depends on OF || COMPILE_TEST
> + depends on OMAP_GPMC || !OMAP_GPMC
Why did you add !OMAP_GPMC?
If OMAP_GPMC is not set we don't want to be able to build this driver correct?
> help
> Support for a OneNAND flash device connected to an OMAP2/OMAP3 SoC
> via the GPMC memory controller.
cheers,
-roger
next prev parent reply other threads:[~2022-11-07 8:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 19:49 [PATCH] mtd: onenand: omap2: add dependency on GPMC Krzysztof Kozlowski
2022-11-07 8:44 ` Roger Quadros [this message]
2022-11-07 8:55 ` Krzysztof Kozlowski
2022-11-07 9:01 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eef60a26-ef23-1b79-22f7-adaee3be9360@kernel.org \
--to=rogerq@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=lkp@intel.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox